2013-03-10 05:05:25

by Hillf Danton

Subject: [PATCH] vmscan: minor cleanup for kswapd

The local variable, total_scanned, is no longer used, so clean up now.

Signed-off-by: Hillf Danton <[email protected]>
---

--- a/mm/vmscan.c Thu Feb 21 20:01:02 2013
+++ b/mm/vmscan.c Sun Mar 10 12:52:10 2013
@@ -2619,7 +2619,6 @@ static unsigned long balance_pgdat(pg_da
bool pgdat_is_balanced = false;
int i;
int end_zone = 0; /* Inclusive. 0 = ZONE_DMA */
- unsigned long total_scanned;
struct reclaim_state *reclaim_state = current->reclaim_state;
unsigned long nr_soft_reclaimed;
unsigned long nr_soft_scanned;
@@ -2639,7 +2638,6 @@ static unsigned long balance_pgdat(pg_da
.gfp_mask = sc.gfp_mask,
};
loop_again:
- total_scanned = 0;
sc.priority = DEF_PRIORITY;
sc.nr_reclaimed = 0;
sc.may_writepage = !laptop_mode;
@@ -2730,7 +2728,6 @@ loop_again:
order, sc.gfp_mask,
&nr_soft_scanned);
sc.nr_reclaimed += nr_soft_reclaimed;
- total_scanned += nr_soft_scanned;

/*
* We put equal pressure on every zone, unless
@@ -2765,7 +2762,6 @@ loop_again:
reclaim_state->reclaimed_slab = 0;
nr_slab = shrink_slab(&shrink, sc.nr_scanned, lru_pages);
sc.nr_reclaimed += reclaim_state->reclaimed_slab;
- total_scanned += sc.nr_scanned;

if (nr_slab == 0 && !zone_reclaimable(zone))
zone->all_unreclaimable = 1;
--

2013-03-13 16:32:41

by Rik van Riel

Subject: Re: [PATCH] vmscan: minor cleanup for kswapd

On 03/10/2013 12:05 AM, Hillf Danton wrote:
> The local variable, total_scanned, is no longer used, so clean up now.
>
> Signed-off-by: Hillf Danton <[email protected]>

Acked-by: Rik van Riel <[email protected]>


--
All rights reversed