mediatek,gce-events is read by mutex node.
Signed-off-by: Hsin-Yi Wang <[email protected]>
Reviewed-by: Enric Balletbo i Serra <[email protected]>
---
arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index c5e822b6b77a..cf22d71161e5 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -1250,6 +1250,8 @@ mutex: mutex@14016000 {
reg = <0 0x14016000 0 0x1000>;
interrupts = <GIC_SPI 217 IRQ_TYPE_LEVEL_LOW>;
power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
+ mediatek,gce-events = <CMDQ_EVENT_MUTEX_STREAM_DONE0>,
+ <CMDQ_EVENT_MUTEX_STREAM_DONE1>;
};
larb0: larb@14017000 {
--
2.31.1.527.g47e6f16901-goog
This property is used by gce clients.
Signed-off-by: Hsin-Yi Wang <[email protected]>
---
v2->v3: move definition to Documentation/devicetree/bindings/mailbox/mtk-gce.txt
---
.../devicetree/bindings/mailbox/mtk-gce.txt | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
index 7771ecaac586..2ef7ff67cb2b 100644
--- a/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
+++ b/Documentation/devicetree/bindings/mailbox/mtk-gce.txt
@@ -35,6 +35,10 @@ Optional properties for a client device:
start_offset: the start offset of register address that GCE can access.
size: the total size of register address that GCE can access.
+Optional properties for a client mutex node:
+- mediatek,gce-events: GCE events used by clients. The event numbers are
+ defined in 'dt-bindings/gce/<chip>-gce.h'.
+
Some vaules of properties are defined in 'dt-bindings/gce/mt8173-gce.h',
'dt-binding/gce/mt8183-gce.h' or 'dt-bindings/gce/mt6779-gce.h'. Such as
sub-system ids, thread priority, event ids.
@@ -62,3 +66,14 @@ Example for a client device:
<&gce SUBSYS_1401XXXX 0x2000 0x100>;
...
};
+
+Example for a client mutex node:
+ mutex: mutex@14020000 {
+ compatible = "mediatek,mt8173-disp-mutex";
+ reg = <0 0x14020000 0 0x1000>;
+ interrupts = <GIC_SPI 169 IRQ_TYPE_LEVEL_LOW>;
+ power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>;
+ clocks = <&mmsys CLK_MM_MUTEX_32K>;
+ mediatek,gce-events = <CMDQ_EVENT_MUTEX0_STREAM_EOF>,
+ <CMDQ_EVENT_MUTEX1_STREAM_EOF>;
+ };
--
2.31.1.527.g47e6f16901-goog
On Tue, 04 May 2021 13:46:12 +0800, Hsin-Yi Wang wrote:
> This property is used by gce clients.
>
> Signed-off-by: Hsin-Yi Wang <[email protected]>
> ---
> v2->v3: move definition to Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> ---
> .../devicetree/bindings/mailbox/mtk-gce.txt | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
Acked-by: Rob Herring <[email protected]>
Hi Jassi,
On 06/05/2021 22:31, Rob Herring wrote:
> On Tue, 04 May 2021 13:46:12 +0800, Hsin-Yi Wang wrote:
>> This property is used by gce clients.
>>
>> Signed-off-by: Hsin-Yi Wang <[email protected]>
>> ---
>> v2->v3: move definition to Documentation/devicetree/bindings/mailbox/mtk-gce.txt
>> ---
>> .../devicetree/bindings/mailbox/mtk-gce.txt | 15 +++++++++++++++
>> 1 file changed, 15 insertions(+)
>>
>
> Acked-by: Rob Herring <[email protected]>
>
Will you take this through your branch, or do you prefer me taking it through mine?
Regards,
Matthias
On Wed, 12 May 2021 at 10:55, Matthias Brugger <[email protected]> wrote:
>
> Hi Jassi,
>
> On 06/05/2021 22:31, Rob Herring wrote:
> > On Tue, 04 May 2021 13:46:12 +0800, Hsin-Yi Wang wrote:
> >> This property is used by gce clients.
> >>
> >> Signed-off-by: Hsin-Yi Wang <[email protected]>
> >> ---
> >> v2->v3: move definition to Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> >> ---
> >> .../devicetree/bindings/mailbox/mtk-gce.txt | 15 +++++++++++++++
> >> 1 file changed, 15 insertions(+)
> >>
> >
> > Acked-by: Rob Herring <[email protected]>
> >
>
> Will you take this through your branch, or do you prefer me taking it through mine?
>
I see I was not CC'ed on the patch. So I can't.
-j
On Fri, May 14, 2021 at 11:25 AM Jassi Brar <[email protected]> wrote:
>
> On Wed, 12 May 2021 at 10:55, Matthias Brugger <[email protected]> wrote:
> >
> > Hi Jassi,
> >
> > On 06/05/2021 22:31, Rob Herring wrote:
> > > On Tue, 04 May 2021 13:46:12 +0800, Hsin-Yi Wang wrote:
> > >> This property is used by gce clients.
> > >>
> > >> Signed-off-by: Hsin-Yi Wang <[email protected]>
> > >> ---
> > >> v2->v3: move definition to Documentation/devicetree/bindings/mailbox/mtk-gce.txt
> > >> ---
> > >> .../devicetree/bindings/mailbox/mtk-gce.txt | 15 +++++++++++++++
> > >> 1 file changed, 15 insertions(+)
> > >>
> > >
> > > Acked-by: Rob Herring <[email protected]>
> > >
> >
> > Will you take this through your branch, or do you prefer me taking it through mine?
> >
> I see I was not CC'ed on the patch. So I can't.
Hi Jassi,
A resend version is cc'ed to you, thanks.
https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/
>
> -j