2022-12-09 17:51:17

by Rob Herring

Subject: [PATCH] dt-bindings: gpio: Convert Fujitsu MB86S7x GPIO to DT schema

Convert the Fujitsu MB86S7x GPIO binding to DT schema format.

The "socionext,synquacer-gpio" compatible was not documented, but is
compatible with "fujitsu,mb86s70-gpio" and is in use (in u-boot
Synquacer dts).

Signed-off-by: Rob Herring <[email protected]>
---
.../bindings/gpio/fujitsu,mb86s70-gpio.txt | 20 --------
.../bindings/gpio/fujitsu,mb86s70-gpio.yaml | 50 +++++++++++++++++++
2 files changed, 50 insertions(+), 20 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/gpio/fujitsu,mb86s70-gpio.txt
create mode 100644 Documentation/devicetree/bindings/gpio/fujitsu,mb86s70-gpio.yaml

diff --git a/Documentation/devicetree/bindings/gpio/fujitsu,mb86s70-gpio.txt b/Documentation/devicetree/bindings/gpio/fujitsu,mb86s70-gpio.txt
deleted file mode 100644
index bef353f370d8..000000000000
--- a/Documentation/devicetree/bindings/gpio/fujitsu,mb86s70-gpio.txt
+++ /dev/null
@@ -1,20 +0,0 @@
-Fujitsu MB86S7x GPIO Controller
--------------------------------
-
-Required properties:
-- compatible: Should be "fujitsu,mb86s70-gpio"
-- reg: Base address and length of register space
-- clocks: Specify the clock
-- gpio-controller: Marks the device node as a gpio controller.
-- #gpio-cells: Should be <2>. The first cell is the pin number and the
- second cell is used to specify optional parameters:
- - bit 0 specifies polarity (0 for normal, 1 for inverted).
-
-Examples:
- gpio0: gpio@31000000 {
- compatible = "fujitsu,mb86s70-gpio";
- reg = <0 0x31000000 0x10000>;
- gpio-controller;
- #gpio-cells = <2>;
- clocks = <&clk 0 2 1>;
- };
diff --git a/Documentation/devicetree/bindings/gpio/fujitsu,mb86s70-gpio.yaml b/Documentation/devicetree/bindings/gpio/fujitsu,mb86s70-gpio.yaml
new file mode 100644
index 000000000000..d18d95285465
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/fujitsu,mb86s70-gpio.yaml
@@ -0,0 +1,50 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/fujitsu,mb86s70-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Fujitsu MB86S7x GPIO Controller
+
+maintainers:
+ - Jassi Brar <[email protected]>
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - const: socionext,synquacer-gpio
+ - const: fujitsu,mb86s70-gpio
+ - const: fujitsu,mb86s70-gpio
+
+ reg:
+ maxItems: 1
+
+ '#gpio-cells':
+ const: 2
+
+ gpio-controller: true
+ gpio-line-names: true
+
+ clocks:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - '#gpio-cells'
+ - gpio-controller
+ - clocks
+
+additionalProperties: false
+
+examples:
+ - |
+ gpio@31000000 {
+ compatible = "fujitsu,mb86s70-gpio";
+ reg = <0x31000000 0x10000>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ clocks = <&clk 0 2 1>;
+ };
+...
--
2.35.1

2022-12-09 19:59:04

by Jassi Brar

Subject: Re: [PATCH] dt-bindings: gpio: Convert Fujitsu MB86S7x GPIO to DT schema

On Fri, 9 Dec 2022 at 11:16, Rob Herring <[email protected]> wrote:
>
> Convert the Fujitsu MB86S7x GPIO binding to DT schema format.
>
> The "socionext,synquacer-gpio" compatible was not documented, but is
> compatible with "fujitsu,mb86s70-gpio" and is in use (in u-boot
> Synquacer dts).
>
> Signed-off-by: Rob Herring <[email protected]>

Acked-by: Jassi Brar <[email protected]>

2022-12-13 15:36:14

by Krzysztof Kozlowski

Subject: Re: [PATCH] dt-bindings: gpio: Convert Fujitsu MB86S7x GPIO to DT schema

On 09/12/2022 18:16, Rob Herring wrote:
> Convert the Fujitsu MB86S7x GPIO binding to DT schema format.
>
> The "socionext,synquacer-gpio" compatible was not documented, but is
> compatible with "fujitsu,mb86s70-gpio" and is in use (in u-boot
> Synquacer dts).
>


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2022-12-30 13:22:47

by Bartosz Golaszewski

Subject: Re: [PATCH] dt-bindings: gpio: Convert Fujitsu MB86S7x GPIO to DT schema

On Fri, Dec 9, 2022 at 6:16 PM Rob Herring <[email protected]> wrote:
>
> Convert the Fujitsu MB86S7x GPIO binding to DT schema format.
>
> The "socionext,synquacer-gpio" compatible was not documented, but is
> compatible with "fujitsu,mb86s70-gpio" and is in use (in u-boot
> Synquacer dts).
>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> .../bindings/gpio/fujitsu,mb86s70-gpio.txt | 20 --------
> .../bindings/gpio/fujitsu,mb86s70-gpio.yaml | 50 +++++++++++++++++++
> 2 files changed, 50 insertions(+), 20 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/gpio/fujitsu,mb86s70-gpio.txt
> create mode 100644 Documentation/devicetree/bindings/gpio/fujitsu,mb86s70-gpio.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpio/fujitsu,mb86s70-gpio.txt b/Documentation/devicetree/bindings/gpio/fujitsu,mb86s70-gpio.txt
> deleted file mode 100644
> index bef353f370d8..000000000000
> --- a/Documentation/devicetree/bindings/gpio/fujitsu,mb86s70-gpio.txt
> +++ /dev/null
> @@ -1,20 +0,0 @@
> -Fujitsu MB86S7x GPIO Controller
> --------------------------------
> -
> -Required properties:
> -- compatible: Should be "fujitsu,mb86s70-gpio"
> -- reg: Base address and length of register space
> -- clocks: Specify the clock
> -- gpio-controller: Marks the device node as a gpio controller.
> -- #gpio-cells: Should be <2>. The first cell is the pin number and the
> - second cell is used to specify optional parameters:
> - - bit 0 specifies polarity (0 for normal, 1 for inverted).
> -
> -Examples:
> - gpio0: gpio@31000000 {
> - compatible = "fujitsu,mb86s70-gpio";
> - reg = <0 0x31000000 0x10000>;
> - gpio-controller;
> - #gpio-cells = <2>;
> - clocks = <&clk 0 2 1>;
> - };
> diff --git a/Documentation/devicetree/bindings/gpio/fujitsu,mb86s70-gpio.yaml b/Documentation/devicetree/bindings/gpio/fujitsu,mb86s70-gpio.yaml
> new file mode 100644
> index 000000000000..d18d95285465
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/fujitsu,mb86s70-gpio.yaml
> @@ -0,0 +1,50 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/fujitsu,mb86s70-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Fujitsu MB86S7x GPIO Controller
> +
> +maintainers:
> + - Jassi Brar <[email protected]>
> +
> +properties:
> + compatible:
> + oneOf:
> + - items:
> + - const: socionext,synquacer-gpio
> + - const: fujitsu,mb86s70-gpio
> + - const: fujitsu,mb86s70-gpio
> +
> + reg:
> + maxItems: 1
> +
> + '#gpio-cells':
> + const: 2
> +
> + gpio-controller: true
> + gpio-line-names: true
> +
> + clocks:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - '#gpio-cells'
> + - gpio-controller
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + gpio@31000000 {
> + compatible = "fujitsu,mb86s70-gpio";
> + reg = <0x31000000 0x10000>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + clocks = <&clk 0 2 1>;
> + };
> +...
> --
> 2.35.1
>

Applied, thanks!

Bart