2022-11-08 08:38:59

by Kunihiko Hayashi

Subject: [PATCH 4/4] mmc: f-sdh30: Add compatible string for Socionext F_SDH30_E51

Add compatible string for Socionext F_SDH30_E51. Currently there are
no new features for this IP, just add it.

And add missing Copyright and MODULE_AUTHOR.

Signed-off-by: Kunihiko Hayashi <[email protected]>
---
drivers/mmc/host/sdhci_f_sdh30.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/mmc/host/sdhci_f_sdh30.c b/drivers/mmc/host/sdhci_f_sdh30.c
index af30343eaf33..2643ae97b2e7 100644
--- a/drivers/mmc/host/sdhci_f_sdh30.c
+++ b/drivers/mmc/host/sdhci_f_sdh30.c
@@ -5,6 +5,7 @@
* Copyright (C) 2013 - 2015 Fujitsu Semiconductor, Ltd
* Vincent Yang <[email protected]>
* Copyright (C) 2015 Linaro Ltd Andy Green <[email protected]>
+ * Copyright (C) 2019 Socionext Inc.
*/

#include <linux/acpi.h>
@@ -228,6 +229,7 @@ static int sdhci_f_sdh30_remove(struct platform_device *pdev)
#ifdef CONFIG_OF
static const struct of_device_id f_sdh30_dt_ids[] = {
{ .compatible = "fujitsu,mb86s70-sdhci-3.0" },
+ { .compatible = "socionext,f-sdh30-e51-mmc" },
{ /* sentinel */ }
};
MODULE_DEVICE_TABLE(of, f_sdh30_dt_ids);
@@ -258,4 +260,5 @@ module_platform_driver(sdhci_f_sdh30_driver);
MODULE_DESCRIPTION("F_SDH30 SD Card Controller driver");
MODULE_LICENSE("GPL v2");
MODULE_AUTHOR("FUJITSU SEMICONDUCTOR LTD.");
+MODULE_AUTHOR("Socionext Inc.");
MODULE_ALIAS("platform:f_sdh30");
--
2.25.1

2022-11-08 16:41:34

by Jassi Brar

Subject: Re: [PATCH 4/4] mmc: f-sdh30: Add compatible string for Socionext F_SDH30_E51

On Tue, 8 Nov 2022 at 02:25, Kunihiko Hayashi
<[email protected]> wrote:
....
> @@ -228,6 +229,7 @@ static int sdhci_f_sdh30_remove(struct platform_device *pdev)
> #ifdef CONFIG_OF
> static const struct of_device_id f_sdh30_dt_ids[] = {
> { .compatible = "fujitsu,mb86s70-sdhci-3.0" },
> + { .compatible = "socionext,f-sdh30-e51-mmc" },
>
This also needs to be specified in the dt bindings, not just in the driver.
And if this patchset is for the "e51-mmc" type controller, introduce
the compatible first and apply the changes for that controller.


> @@ -258,4 +260,5 @@ module_platform_driver(sdhci_f_sdh30_driver);
> MODULE_DESCRIPTION("F_SDH30 SD Card Controller driver");
> MODULE_LICENSE("GPL v2");
> MODULE_AUTHOR("FUJITSU SEMICONDUCTOR LTD.");
> +MODULE_AUTHOR("Socionext Inc.");
>
Socionext now is what Fujitsu was when this code was written, so this
addition seems ok.
So may be add it as
MODULE_AUTHOR("FUJITSU SEMICONDUCTOR LTD., SOCIONEXT INC.");

cheers.

2022-11-09 08:52:01

by Kunihiko Hayashi

Subject: Re: [PATCH 4/4] mmc: f-sdh30: Add compatible string for Socionext F_SDH30_E51

Hi Jassi-san,

On 2022/11/09 1:03, Jassi Brar wrote:
> On Tue, 8 Nov 2022 at 02:25, Kunihiko Hayashi
> <[email protected]> wrote:
> ....
>> @@ -228,6 +229,7 @@ static int sdhci_f_sdh30_remove(struct platform_device
>> *pdev)
>> #ifdef CONFIG_OF
>> static const struct of_device_id f_sdh30_dt_ids[] = {
>> { .compatible = "fujitsu,mb86s70-sdhci-3.0" },
>> + { .compatible = "socionext,f-sdh30-e51-mmc" },
>>
> This also needs to be specified in the dt bindings, not just in the driver.
> And if this patchset is for the "e51-mmc" type controller, introduce
> the compatible first and apply the changes for that controller.

I understand.
I need to confirm if the extend operations in this patch depend on
new F_SDH30_E51 or common with original F_SDH30.


>> @@ -258,4 +260,5 @@ module_platform_driver(sdhci_f_sdh30_driver);
>> MODULE_DESCRIPTION("F_SDH30 SD Card Controller driver");
>> MODULE_LICENSE("GPL v2");
>> MODULE_AUTHOR("FUJITSU SEMICONDUCTOR LTD.");
>> +MODULE_AUTHOR("Socionext Inc.");
>>
> Socionext now is what Fujitsu was when this code was written, so this
> addition seems ok.
> So may be add it as
> MODULE_AUTHOR("FUJITSU SEMICONDUCTOR LTD., SOCIONEXT INC.");
Although I'm confused how to write this, I'll write it that way.

Thank you,

---
Best Regards
Kunihiko Hayashi