This patch add pwm pins for r40.
Signed-off-by: hao_zhang <[email protected]>
---
arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
index 8c5efe2..6cf6273 100644
--- a/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
+++ b/arch/arm/boot/dts/sun8i-r40-bananapi-m2-ultra.dts
@@ -196,6 +196,12 @@
status = "okay";
};
+&pwm {
+ pinctrl-names = "default";
+ pinctrl-0 = <&pwm_pins>;
+ status = "okay";
+};
+
&uart0 {
pinctrl-names = "default";
pinctrl-0 = <&uart0_pb_pins>;
--
2.7.4
Hi,
On Thu, Jan 11, 2018 at 07:33:23PM +0800, hao_zhang wrote:
> This patch add pwm pins for r40.
>
> Signed-off-by: hao_zhang <[email protected]>
You should order your patches differently. We try to be as bisectable
as possible, and if we just apply this patch the DT will not compile
anymore.
Your patch 4 should come before this one.
Your commit title and log doesn't seem to match the content of the
patch either.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
2018-01-11 20:47 GMT+08:00 Maxime Ripard <[email protected]>:
> Hi,
>
> On Thu, Jan 11, 2018 at 07:33:23PM +0800, hao_zhang wrote:
>> This patch add pwm pins for r40.
>>
>> Signed-off-by: hao_zhang <[email protected]>
>
> You should order your patches differently. We try to be as bisectable
> as possible, and if we just apply this patch the DT will not compile
> anymore.
>
> Your patch 4 should come before this one.
>
Do you mean that the order of patch be applied is from the first to
the last in the patch set ?
because you apply the last patch first also break the DT compile...
Thinks :)
Hao Zhang
> Your commit title and log doesn't seem to match the content of the
> patch either.
>
> Thanks!
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
On Sun, Jan 14, 2018 at 03:07:46PM +0800, Hao Zhang wrote:
> 2018-01-11 20:47 GMT+08:00 Maxime Ripard <[email protected]>:
> > Hi,
> >
> > On Thu, Jan 11, 2018 at 07:33:23PM +0800, hao_zhang wrote:
> >> This patch add pwm pins for r40.
> >>
> >> Signed-off-by: hao_zhang <[email protected]>
> >
> > You should order your patches differently. We try to be as bisectable
> > as possible, and if we just apply this patch the DT will not compile
> > anymore.
> >
> > Your patch 4 should come before this one.
> >
>
> Do you mean that the order of patch be applied is from the first to
> the last in the patch set ?
Yes and each steps should compile and not introduce any regressions
(ideally :)).
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com