2024-02-07 12:20:21

by Miklos Szeredi

[permalink] [raw]
Subject: Re: [Lsf-pc] [LSF/MM/BPF TOPIC] tracing the source of errors

On Wed, 7 Feb 2024 at 13:00, Matthew Wilcox <[email protected]> wrote:

> To be perfectly clear, you're suggesting two things.
>
> Option (a) change "all" code like this:
> - ret = -EINVAL;
> + ret = -ERR(EINVAL);
>
> where ERR would do some magic with __func__ and __LINE__.
>
> Option (b)
>
> -#define EINVAL 22
> +#define E_INVAL 22
> +#define EINVAL ERR(E_INVAL)
>
> and then change all code that does something like:
>
> if (err == -EINVAL)
> to
> if (err == -E_INVAL)
>
> Or have I misunderstood?

Something like that, yes.

Thanks,
Miklos