2019-07-22 07:19:48

by Vasily Averin

Subject: [PATCH] fuse: cleanup fuse_wait_on_page_writeback

From: Maxim Patlasov <[email protected]>
fuse_wait_on_page_writeback() always returns zero and nobody cares.
Let's make it void.

Signed-off-by: Maxim Patlasov <[email protected]>
Signed-off-by: Vasily Averin <[email protected]>
---
fs/fuse/file.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index 5ae2828beb00..e076c2cf65b0 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -383,12 +383,11 @@ static inline bool fuse_page_is_writeback(struct inode *inode, pgoff_t index)
* Since fuse doesn't rely on the VM writeback tracking, this has to
* use some other means.
*/
-static int fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index)
+static void fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index)
{
struct fuse_inode *fi = get_fuse_inode(inode);

wait_event(fi->page_waitq, !fuse_page_is_writeback(inode, index));
- return 0;
}

/*
--
2.17.1

2019-07-22 07:21:34

by Vasily Averin

Subject: Re: [PATCH] fuse: cleanup fuse_wait_on_page_writeback

I forget to add this patch was used in OpenVZ kernels last few years.

On 7/22/19 10:17 AM, Vasily Averin wrote:
> From: Maxim Patlasov <[email protected]>
> fuse_wait_on_page_writeback() always returns zero and nobody cares.
> Let's make it void.
>
> Signed-off-by: Maxim Patlasov <[email protected]>
> Signed-off-by: Vasily Averin <[email protected]>
> ---
> fs/fuse/file.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index 5ae2828beb00..e076c2cf65b0 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -383,12 +383,11 @@ static inline bool fuse_page_is_writeback(struct inode *inode, pgoff_t index)
> * Since fuse doesn't rely on the VM writeback tracking, this has to
> * use some other means.
> */
> -static int fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index)
> +static void fuse_wait_on_page_writeback(struct inode *inode, pgoff_t index)
> {
> struct fuse_inode *fi = get_fuse_inode(inode);
>
> wait_event(fi->page_waitq, !fuse_page_is_writeback(inode, index));
> - return 0;
> }
>
> /*
>

2019-08-01 11:10:44

by Miklos Szeredi

Subject: Re: [PATCH] fuse: cleanup fuse_wait_on_page_writeback

On Mon, Jul 22, 2019 at 9:17 AM Vasily Averin <[email protected]> wrote:
>
> From: Maxim Patlasov <[email protected]>
> fuse_wait_on_page_writeback() always returns zero and nobody cares.
> Let's make it void.

Applied.

Thanks,
Miklos