2016-03-03 16:04:07

by Miklos Szeredi

[permalink] [raw]
Subject: Re: [PATCH] ovl: copy new uid/gid into overlayfs runtime inode

On Sun, Jan 31, 2016 at 2:21 PM, Konstantin Khlebnikov <[email protected]> wrote:
> Overlayfs must update uid/gid after chown, otherwise functions
> like inode_owner_or_capable() will check user against stale uid.
> Catched by xfstests generic/087, it chowns file and calls utimes.

Queued up patch. Thanks.

Miklos


2016-03-03 18:58:29

by Sedat Dilek

[permalink] [raw]
Subject: Re: [PATCH] ovl: copy new uid/gid into overlayfs runtime inode

On 3/3/16, Miklos Szeredi <[email protected]> wrote:
> On Sun, Jan 31, 2016 at 2:21 PM, Konstantin Khlebnikov <[email protected]>
> wrote:
>> Overlayfs must update uid/gid after chown, otherwise functions
>> like inode_owner_or_capable() will check user against stale uid.
>> Catched by xfstests generic/087, it chowns file and calls utimes.
>
> Queued up patch. Thanks.
>

In which Git tree you do that?
[1] points to [2], still true?

- Sedat -

[1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/MAINTAINERS#n8110
[2] http://git.kernel.org/cgit/linux/kernel/git/mszeredi/vfs.git/

> Miklos
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

2016-03-04 05:06:20

by Miklos Szeredi

[permalink] [raw]
Subject: Re: [PATCH] ovl: copy new uid/gid into overlayfs runtime inode

On Thu, Mar 3, 2016 at 7:58 PM, Sedat Dilek <[email protected]> wrote:
> On 3/3/16, Miklos Szeredi <[email protected]> wrote:
>> On Sun, Jan 31, 2016 at 2:21 PM, Konstantin Khlebnikov <[email protected]>
>> wrote:
>>> Overlayfs must update uid/gid after chown, otherwise functions
>>> like inode_owner_or_capable() will check user against stale uid.
>>> Catched by xfstests generic/087, it chowns file and calls utimes.
>>
>> Queued up patch. Thanks.
>>
>
> In which Git tree you do that?
> [1] points to [2], still true?

It is. I just forgot to push yesterday evening. Pushed now.

Thanks,
Miklos


>
> - Sedat -
>
> [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/MAINTAINERS#n8110
> [2] http://git.kernel.org/cgit/linux/kernel/git/mszeredi/vfs.git/
>