2015-05-23 05:09:56

by Shailendra Verma

Subject: [PATCH] kernel:signal - Fix for typos in comments.

Signed-off-by: Shailendra Verma <[email protected]>
---
kernel/signal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index d51c5dd..5c65e7c 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -342,7 +342,7 @@ static bool task_participate_group_stop(struct task_struct *task)
sig->group_stop_count--;

/*
- * Tell the caller to notify completion iff we are entering into a
+ * Tell the caller to notify completion if we are entering into a
* fresh group stop. Read comment in do_signal_stop() for details.
*/
if (!sig->group_stop_count && !(sig->flags & SIGNAL_STOP_STOPPED)) {
@@ -1864,7 +1864,7 @@ static void ptrace_stop(int exit_code, int why, int clear_code, siginfo_t *info)

/*
* If @why is CLD_STOPPED, we're trapping to participate in a group
- * stop. Do the bookkeeping. Note that if SIGCONT was delievered
+ * stop. Do the bookkeeping. Note that if SIGCONT was delivered
* across siglock relocks since INTERRUPT was scheduled, PENDING
* could be clear now. We act as if SIGCONT is received after
* TASK_TRACED is entered - ignore it.
--
1.7.9.5

2015-05-23 09:15:58

by Richard Weinberger

Subject: Re: [PATCH] kernel:signal - Fix for typos in comments.

Am 23.05.2015 um 07:09 schrieb Shailendra Verma:
> Signed-off-by: Shailendra Verma <[email protected]>
> ---
> kernel/signal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index d51c5dd..5c65e7c 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -342,7 +342,7 @@ static bool task_participate_group_stop(struct task_struct *task)
> sig->group_stop_count--;
>
> /*
> - * Tell the caller to notify completion iff we are entering into a

http://en.wikipedia.org/wiki/If_and_only_if

Thanks,
//richard

2015-05-23 17:15:40

by Pranith Kumar

Subject: Re: [PATCH] kernel:signal - Fix for typos in comments.

On Sat, May 23, 2015 at 1:09 AM, Shailendra Verma wrote:

Please include a changelog for every patch you submit exolaining why
you think the change makes sense.

>
> Signed-off-by: Shailendra Verma <[email protected]>
> ---
> kernel/signal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index d51c5dd..5c65e7c 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -342,7 +342,7 @@ static bool task_participate_group_stop(struct task_struct *task)
> sig->group_stop_count--;
>
> /*
> - * Tell the caller to notify completion iff we are entering into a
> + * Tell the caller to notify completion if we are entering into a

iff means "if and only if" and I think it makes perfect sense here. I
encourage you to keep trying :)

Thanks!
--
Pranith