2023-09-13 05:12:10

by Keguang Zhang

[permalink] [raw]
Subject: Re: [PATCH v4 2/4] dt-bindings: net: Add Loongson-1 Ethernet Controller

On Mon, Sep 11, 2023 at 6:47 PM Philippe Mathieu-Daudé
<[email protected]> wrote:
>
> On 30/8/23 15:42, Keguang Zhang wrote:
> > Add devicetree binding document for Loongson-1 Ethernet controller.
> >
> > Signed-off-by: Keguang Zhang <[email protected]>
> > Reviewed-by: Krzysztof Kozlowski <[email protected]>
> > ---
> > V3 -> V4: Add "|" to description part
> > Amend "phy-mode" property
> > V2 -> V3: Split the DT-schema file into loongson,ls1b-gmac.yaml
> > and loongson,ls1c-emac.yaml (suggested by Serge Semin)
> > Change the compatibles to loongson,ls1b-gmac and loongson,ls1c-emac
> > Rename loongson,dwmac-syscon to loongson,ls1-syscon
> > Amend the title
> > Add description
> > Add Reviewed-by tag from Krzysztof Kozlowski(Sorry! I'm not sure)
> > V1 -> V2: Fix "clock-names" and "interrupt-names" property
> > Rename the syscon property to "loongson,dwmac-syscon"
> > Drop "phy-handle" and "phy-mode" requirement
> > Revert adding loongson,ls1b-dwmac/loongson,ls1c-dwmac
> > to snps,dwmac.yaml
> >
> > .../bindings/net/loongson,ls1b-gmac.yaml | 114 ++++++++++++++++++
> > .../bindings/net/loongson,ls1c-emac.yaml | 113 +++++++++++++++++
> > 2 files changed, 227 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/net/loongson,ls1b-gmac.yaml
> > create mode 100644 Documentation/devicetree/bindings/net/loongson,ls1c-emac.yaml
>
> Squash:
>
> -- >8 --
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ff1f273b4f36..2519d06b5aab 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -14344,9 +14344,12 @@ MIPS/LOONGSON1 ARCHITECTURE
> M: Keguang Zhang <[email protected]>
> L: [email protected]
> S: Maintained
> +F: Documentation/devicetree/bindings/*/loongson,ls1x-*.yaml
> +F: Documentation/devicetree/bindings/net/loongson,ls1*.yaml
> F: arch/mips/include/asm/mach-loongson32/
> F: arch/mips/loongson32/
> F: drivers/*/*loongson1*
> ---

Will do.
Thanks!

--
Best regards,

Keguang Zhang