2024-01-31 02:27:13

by Haibo Xu

[permalink] [raw]
Subject: [PATCH 1/4] ACPICA: SRAT: Add RISC-V RINTC affinity structure

ACPICA commit 93caddbf2f620769052c59ec471f018281dc3a24

Add definition of RISC-V Interrupt Controller(RINTC)
affinity structure which was approved by UEFI forum
and will be part of next ACPI spec version(6.6).

Link: https://github.com/acpica/acpica/commit/93caddbf
Signed-off-by: Haibo Xu <[email protected]>
---
include/acpi/actbl3.h | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/include/acpi/actbl3.h b/include/acpi/actbl3.h
index c080d579a546..5202e3fc9b41 100644
--- a/include/acpi/actbl3.h
+++ b/include/acpi/actbl3.h
@@ -192,7 +192,8 @@ enum acpi_srat_type {
ACPI_SRAT_TYPE_GIC_ITS_AFFINITY = 4, /* ACPI 6.2 */
ACPI_SRAT_TYPE_GENERIC_AFFINITY = 5, /* ACPI 6.3 */
ACPI_SRAT_TYPE_GENERIC_PORT_AFFINITY = 6, /* ACPI 6.4 */
- ACPI_SRAT_TYPE_RESERVED = 7 /* 7 and greater are reserved */
+ ACPI_SRAT_TYPE_RINTC_AFFINITY = 7, /* ACPI 6.6 */
+ ACPI_SRAT_TYPE_RESERVED = 8 /* 8 and greater are reserved */
};

/*
@@ -296,6 +297,21 @@ struct acpi_srat_generic_affinity {
#define ACPI_SRAT_GENERIC_AFFINITY_ENABLED (1) /* 00: Use affinity structure */
#define ACPI_SRAT_ARCHITECTURAL_TRANSACTIONS (1<<1) /* ACPI 6.4 */

+/* 7: RINTC Affinity (ACPI 6.6) */
+
+struct acpi_srat_rintc_affinity {
+ struct acpi_subtable_header header;
+ u16 reserved; /* Reserved, must be zero */
+ u32 proximity_domain;
+ u32 acpi_processor_uid;
+ u32 flags;
+ u32 clock_domain;
+};
+
+/* Flags for struct acpi_srat_rintc_affinity */
+
+#define ACPI_SRAT_RINTC_ENABLED (1) /* 00: Use affinity structure */
+
/*******************************************************************************
*
* STAO - Status Override Table (_STA override) - ACPI 6.0
--
2.34.1



2024-02-12 13:40:22

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH 1/4] ACPICA: SRAT: Add RISC-V RINTC affinity structure

On Wed, Jan 31, 2024 at 3:18 AM Haibo Xu <[email protected]> wrote:
>
> ACPICA commit 93caddbf2f620769052c59ec471f018281dc3a24

Not really.

> Add definition of RISC-V Interrupt Controller(RINTC)
> affinity structure which was approved by UEFI forum
> and will be part of next ACPI spec version(6.6).
>
> Link: https://github.com/acpica/acpica/commit/93caddbf

And this doesn't point to an upstream ACPICA PR.

> Signed-off-by: Haibo Xu <[email protected]>
> ---
> include/acpi/actbl3.h | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/include/acpi/actbl3.h b/include/acpi/actbl3.h
> index c080d579a546..5202e3fc9b41 100644
> --- a/include/acpi/actbl3.h
> +++ b/include/acpi/actbl3.h
> @@ -192,7 +192,8 @@ enum acpi_srat_type {
> ACPI_SRAT_TYPE_GIC_ITS_AFFINITY = 4, /* ACPI 6.2 */
> ACPI_SRAT_TYPE_GENERIC_AFFINITY = 5, /* ACPI 6.3 */
> ACPI_SRAT_TYPE_GENERIC_PORT_AFFINITY = 6, /* ACPI 6.4 */
> - ACPI_SRAT_TYPE_RESERVED = 7 /* 7 and greater are reserved */
> + ACPI_SRAT_TYPE_RINTC_AFFINITY = 7, /* ACPI 6.6 */
> + ACPI_SRAT_TYPE_RESERVED = 8 /* 8 and greater are reserved */
> };
>
> /*
> @@ -296,6 +297,21 @@ struct acpi_srat_generic_affinity {
> #define ACPI_SRAT_GENERIC_AFFINITY_ENABLED (1) /* 00: Use affinity structure */
> #define ACPI_SRAT_ARCHITECTURAL_TRANSACTIONS (1<<1) /* ACPI 6.4 */
>
> +/* 7: RINTC Affinity (ACPI 6.6) */
> +
> +struct acpi_srat_rintc_affinity {
> + struct acpi_subtable_header header;
> + u16 reserved; /* Reserved, must be zero */
> + u32 proximity_domain;
> + u32 acpi_processor_uid;
> + u32 flags;
> + u32 clock_domain;
> +};
> +
> +/* Flags for struct acpi_srat_rintc_affinity */
> +
> +#define ACPI_SRAT_RINTC_ENABLED (1) /* 00: Use affinity structure */
> +
> /*******************************************************************************
> *
> * STAO - Status Override Table (_STA override) - ACPI 6.0
> --
> 2.34.1
>

2024-02-18 07:19:02

by Haibo Xu

[permalink] [raw]
Subject: Re: [PATCH 1/4] ACPICA: SRAT: Add RISC-V RINTC affinity structure

On Mon, Feb 12, 2024 at 9:31 PM Rafael J. Wysocki <[email protected]> wrote:
>
> On Wed, Jan 31, 2024 at 3:18 AM Haibo Xu <[email protected]> wrote:
> >
> > ACPICA commit 93caddbf2f620769052c59ec471f018281dc3a24
>
> Not really.
>
> > Add definition of RISC-V Interrupt Controller(RINTC)
> > affinity structure which was approved by UEFI forum
> > and will be part of next ACPI spec version(6.6).
> >
> > Link: https://github.com/acpica/acpica/commit/93caddbf
>
> And this doesn't point to an upstream ACPICA PR.
>

Hi Rafael,

This patch was generated by the acpica/generate/linux/gen-patch.sh and
should be merged
through the ACPICA project. To include it in this series is just to
serve as a reference.

BTW, the corresponding ACPICA patch is still under review and please
refer to the following
link for the status.

https://github.com/acpica/acpica/pull/926

Regards,
Haibo

> > Signed-off-by: Haibo Xu <[email protected]>
> > ---
> > include/acpi/actbl3.h | 18 +++++++++++++++++-
> > 1 file changed, 17 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/acpi/actbl3.h b/include/acpi/actbl3.h
> > index c080d579a546..5202e3fc9b41 100644
> > --- a/include/acpi/actbl3.h
> > +++ b/include/acpi/actbl3.h
> > @@ -192,7 +192,8 @@ enum acpi_srat_type {
> > ACPI_SRAT_TYPE_GIC_ITS_AFFINITY = 4, /* ACPI 6.2 */
> > ACPI_SRAT_TYPE_GENERIC_AFFINITY = 5, /* ACPI 6.3 */
> > ACPI_SRAT_TYPE_GENERIC_PORT_AFFINITY = 6, /* ACPI 6.4 */
> > - ACPI_SRAT_TYPE_RESERVED = 7 /* 7 and greater are reserved */
> > + ACPI_SRAT_TYPE_RINTC_AFFINITY = 7, /* ACPI 6.6 */
> > + ACPI_SRAT_TYPE_RESERVED = 8 /* 8 and greater are reserved */
> > };
> >
> > /*
> > @@ -296,6 +297,21 @@ struct acpi_srat_generic_affinity {
> > #define ACPI_SRAT_GENERIC_AFFINITY_ENABLED (1) /* 00: Use affinity structure */
> > #define ACPI_SRAT_ARCHITECTURAL_TRANSACTIONS (1<<1) /* ACPI 6.4 */
> >
> > +/* 7: RINTC Affinity (ACPI 6.6) */
> > +
> > +struct acpi_srat_rintc_affinity {
> > + struct acpi_subtable_header header;
> > + u16 reserved; /* Reserved, must be zero */
> > + u32 proximity_domain;
> > + u32 acpi_processor_uid;
> > + u32 flags;
> > + u32 clock_domain;
> > +};
> > +
> > +/* Flags for struct acpi_srat_rintc_affinity */
> > +
> > +#define ACPI_SRAT_RINTC_ENABLED (1) /* 00: Use affinity structure */
> > +
> > /*******************************************************************************
> > *
> > * STAO - Status Override Table (_STA override) - ACPI 6.0
> > --
> > 2.34.1
> >