2015-07-31 05:16:20

by Shraddha Barke

Subject: [PATCH] Staging:wilc1000 :Remove braces for single statement blocks

This patch fixes the following checkpatch.pl warning:

WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Shraddha Barke <[email protected]>
---
drivers/staging/wilc1000/coreconfigurator.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
index 4d5bd1c..1143282 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -1055,10 +1055,8 @@ s32 DeallocateSurveyResults(wid_site_survey_reslts_s *pstrSurveyResults)
{
s32 s32Error = WILC_SUCCESS;

- if (pstrSurveyResults != NULL) {
+ if (pstrSurveyResults != NULL)
WILC_FREE(pstrSurveyResults);
- }
-
return s32Error;
}
#endif
--
2.1.0

2015-07-31 05:32:33

by Vaishali Thakkar

Subject: Re: [PATCH] Staging:wilc1000 :Remove braces for single statement blocks

On 31 Jul 2015 10:49, "Shraddha Barke" <[email protected]> wrote:
>
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: braces {} are not necessary for single statement blocks

There should be one line space between your commit log
and Signed-off-by line.

> Signed-off-by: Shraddha Barke <[email protected]>
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index 4d5bd1c..1143282 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -1055,10 +1055,8 @@ s32 DeallocateSurveyResults(wid_site_survey_reslts_s *pstrSurveyResults)
> {
> s32 s32Error = WILC_SUCCESS;
>
> - if (pstrSurveyResults != NULL) {
> + if (pstrSurveyResults != NULL)
> WILC_FREE(pstrSurveyResults);
> - }
> -
> return s32Error;
> }
> #endif
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html