2014-06-23 11:41:33

by Sachin Kamat

Subject: [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe

bcm281xx_pinctrl_probe is local to this file. Make it static.

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/pinctrl/pinctrl-bcm281xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/pinctrl-bcm281xx.c b/drivers/pinctrl/pinctrl-bcm281xx.c
index 3bed792b2c03..c5ca9e633fff 100644
--- a/drivers/pinctrl/pinctrl-bcm281xx.c
+++ b/drivers/pinctrl/pinctrl-bcm281xx.c
@@ -1396,7 +1396,7 @@ static struct pinctrl_desc bcm281xx_pinctrl_desc = {
.owner = THIS_MODULE,
};

-int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
+static int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
{
struct bcm281xx_pinctrl_data *pdata = &bcm281xx_pinctrl;
struct resource *res;
--
1.7.9.5

2014-06-23 18:08:25

by Sherman Yin

Subject: Re: [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe

Hi Sachin,

Looks good, thanks. How did you come across the need for this change?

Regards,
Sherman

On 14-06-23 04:38 AM, Sachin Kamat wrote:
> bcm281xx_pinctrl_probe is local to this file. Make it static.
>
> Signed-off-by: Sachin Kamat <[email protected]>
> ---
> drivers/pinctrl/pinctrl-bcm281xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-bcm281xx.c b/drivers/pinctrl/pinctrl-bcm281xx.c
> index 3bed792b2c03..c5ca9e633fff 100644
> --- a/drivers/pinctrl/pinctrl-bcm281xx.c
> +++ b/drivers/pinctrl/pinctrl-bcm281xx.c
> @@ -1396,7 +1396,7 @@ static struct pinctrl_desc bcm281xx_pinctrl_desc = {
> .owner = THIS_MODULE,
> };
>
> -int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
> +static int __init bcm281xx_pinctrl_probe(struct platform_device *pdev)
> {
> struct bcm281xx_pinctrl_data *pdata = &bcm281xx_pinctrl;
> struct resource *res;
>

2014-06-24 03:44:40

by Sachin Kamat

Subject: Re: [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe

Hi Sherman,

On Mon, Jun 23, 2014 at 11:35 PM, Sherman Yin <[email protected]> wrote:
> Hi Sachin,
>
> Looks good, thanks. How did you come across the need for this change?

Thanks for the review. Sparse threw up a warning while doing a regular build.

Regards,
Sachin.

2014-07-07 15:28:53

by Linus Walleij

Subject: Re: [PATCH 1/1] pinctrl: bcm281xx: Staticize bcm281xx_pinctrl_probe

On Mon, Jun 23, 2014 at 1:38 PM, Sachin Kamat <[email protected]> wrote:

> bcm281xx_pinctrl_probe is local to this file. Make it static.
>
> Signed-off-by: Sachin Kamat <[email protected]>

Patch applied.

Yours,
Linus Walleij