2014-06-02 02:26:37

by Jingoo Han

Subject: Re: [PATCH 1/3] phy: exynos-dp-video: Use PTR_ERR_OR_ZERO

On Thursday, May 29, 2014 3:31 PM, Sachin Kamat wrote:
>
> PTR_ERR_OR_ZERO simplifies the code.
>
> Signed-off-by: Sachin Kamat <[email protected]>
> Cc: Jingoo Han <[email protected]>

Acked-by: Jingoo Han <[email protected]>

Best regards,
Jingoo Han

> ---
> drivers/phy/phy-exynos-dp-video.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/phy/phy-exynos-dp-video.c b/drivers/phy/phy-exynos-dp-video.c
> index 0786fef842e7..098f822a2fa4 100644
> --- a/drivers/phy/phy-exynos-dp-video.c
> +++ b/drivers/phy/phy-exynos-dp-video.c
> @@ -9,6 +9,7 @@
> * published by the Free Software Foundation.
> */
>
> +#include <linux/err.h>
> #include <linux/io.h>
> #include <linux/kernel.h>
> #include <linux/module.h>
> @@ -84,10 +85,8 @@ static int exynos_dp_video_phy_probe(struct platform_device *pdev)
> phy_set_drvdata(phy, state);
>
> phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
> - if (IS_ERR(phy_provider))
> - return PTR_ERR(phy_provider);
>
> - return 0;
> + return PTR_ERR_OR_ZERO(phy_provider);
> }
>
> static const struct of_device_id exynos_dp_video_phy_of_match[] = {
> --
> 1.7.9.5

2014-06-12 09:50:00

by Sachin Kamat

Subject: Re: [PATCH 1/3] phy: exynos-dp-video: Use PTR_ERR_OR_ZERO

Hi Kishon,

On Mon, Jun 2, 2014 at 7:56 AM, Jingoo Han <[email protected]> wrote:
> On Thursday, May 29, 2014 3:31 PM, Sachin Kamat wrote:
>>
>> PTR_ERR_OR_ZERO simplifies the code.
>>
>> Signed-off-by: Sachin Kamat <[email protected]>
>> Cc: Jingoo Han <[email protected]>
>
> Acked-by: Jingoo Han <[email protected]>
>
> Best regards,
> Jingoo Han
>
>> ---
>> drivers/phy/phy-exynos-dp-video.c | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/phy/phy-exynos-dp-video.c b/drivers/phy/phy-exynos-dp-video.c
>> index 0786fef842e7..098f822a2fa4 100644
>> --- a/drivers/phy/phy-exynos-dp-video.c
>> +++ b/drivers/phy/phy-exynos-dp-video.c
>> @@ -9,6 +9,7 @@
>> * published by the Free Software Foundation.
>> */
>>
>> +#include <linux/err.h>
>> #include <linux/io.h>
>> #include <linux/kernel.h>
>> #include <linux/module.h>
>> @@ -84,10 +85,8 @@ static int exynos_dp_video_phy_probe(struct platform_device *pdev)
>> phy_set_drvdata(phy, state);
>>
>> phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
>> - if (IS_ERR(phy_provider))
>> - return PTR_ERR(phy_provider);
>>
>> - return 0;
>> + return PTR_ERR_OR_ZERO(phy_provider);
>> }
>>
>> static const struct of_device_id exynos_dp_video_phy_of_match[] = {
>> --
>> 1.7.9.5
>
>

ping on this series.

--
Regards,
Sachin.

2014-06-12 09:57:47

by Kishon Vijay Abraham I

Subject: Re: [PATCH 1/3] phy: exynos-dp-video: Use PTR_ERR_OR_ZERO

On Thursday 12 June 2014 03:19 PM, Sachin Kamat wrote:
> Hi Kishon,
>
> On Mon, Jun 2, 2014 at 7:56 AM, Jingoo Han <[email protected]> wrote:
>> On Thursday, May 29, 2014 3:31 PM, Sachin Kamat wrote:
>>>
>>> PTR_ERR_OR_ZERO simplifies the code.
>>>
>>> Signed-off-by: Sachin Kamat <[email protected]>
>>> Cc: Jingoo Han <[email protected]>
>>
>> Acked-by: Jingoo Han <[email protected]>
>>
>> Best regards,
>> Jingoo Han
>>
>>> ---
>>> drivers/phy/phy-exynos-dp-video.c | 5 ++---
>>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/phy/phy-exynos-dp-video.c b/drivers/phy/phy-exynos-dp-video.c
>>> index 0786fef842e7..098f822a2fa4 100644
>>> --- a/drivers/phy/phy-exynos-dp-video.c
>>> +++ b/drivers/phy/phy-exynos-dp-video.c
>>> @@ -9,6 +9,7 @@
>>> * published by the Free Software Foundation.
>>> */
>>>
>>> +#include <linux/err.h>
>>> #include <linux/io.h>
>>> #include <linux/kernel.h>
>>> #include <linux/module.h>
>>> @@ -84,10 +85,8 @@ static int exynos_dp_video_phy_probe(struct platform_device *pdev)
>>> phy_set_drvdata(phy, state);
>>>
>>> phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
>>> - if (IS_ERR(phy_provider))
>>> - return PTR_ERR(phy_provider);
>>>
>>> - return 0;
>>> + return PTR_ERR_OR_ZERO(phy_provider);
>>> }
>>>
>>> static const struct of_device_id exynos_dp_video_phy_of_match[] = {
>>> --
>>> 1.7.9.5
>>
>>
>
> ping on this series.

I'll queue to -next once -rc1 is tagged.

-Kishon
>

2014-06-12 09:59:04

by Sachin Kamat

Subject: Re: [PATCH 1/3] phy: exynos-dp-video: Use PTR_ERR_OR_ZERO

On Thu, Jun 12, 2014 at 3:27 PM, Kishon Vijay Abraham I <[email protected]> wrote:
>
>
> On Thursday 12 June 2014 03:19 PM, Sachin Kamat wrote:
>> Hi Kishon,
>>
>> On Mon, Jun 2, 2014 at 7:56 AM, Jingoo Han <[email protected]> wrote:
>>> On Thursday, May 29, 2014 3:31 PM, Sachin Kamat wrote:
>>>>
>>>> PTR_ERR_OR_ZERO simplifies the code.
>>>>
>>>> Signed-off-by: Sachin Kamat <[email protected]>
>>>> Cc: Jingoo Han <[email protected]>
>>>
>>> Acked-by: Jingoo Han <[email protected]>
>>>
>>> Best regards,
>>> Jingoo Han
>>>
>>>> ---
>>>> drivers/phy/phy-exynos-dp-video.c | 5 ++---
>>>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/phy/phy-exynos-dp-video.c b/drivers/phy/phy-exynos-dp-video.c
>>>> index 0786fef842e7..098f822a2fa4 100644
>>>> --- a/drivers/phy/phy-exynos-dp-video.c
>>>> +++ b/drivers/phy/phy-exynos-dp-video.c
>>>> @@ -9,6 +9,7 @@
>>>> * published by the Free Software Foundation.
>>>> */
>>>>
>>>> +#include <linux/err.h>
>>>> #include <linux/io.h>
>>>> #include <linux/kernel.h>
>>>> #include <linux/module.h>
>>>> @@ -84,10 +85,8 @@ static int exynos_dp_video_phy_probe(struct platform_device *pdev)
>>>> phy_set_drvdata(phy, state);
>>>>
>>>> phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
>>>> - if (IS_ERR(phy_provider))
>>>> - return PTR_ERR(phy_provider);
>>>>
>>>> - return 0;
>>>> + return PTR_ERR_OR_ZERO(phy_provider);
>>>> }
>>>>
>>>> static const struct of_device_id exynos_dp_video_phy_of_match[] = {
>>>> --
>>>> 1.7.9.5
>>>
>>>
>>
>> ping on this series.
>
> I'll queue to -next once -rc1 is tagged.

Thanks Kishon.

--
Regards,
Sachin.

2014-07-02 08:44:20

by Sachin Kamat

Subject: Re: [PATCH 1/3] phy: exynos-dp-video: Use PTR_ERR_OR_ZERO

On Thu, Jun 12, 2014 at 3:27 PM, Kishon Vijay Abraham I <[email protected]> wrote:
>
>
> On Thursday 12 June 2014 03:19 PM, Sachin Kamat wrote:
>> Hi Kishon,
>>
>> On Mon, Jun 2, 2014 at 7:56 AM, Jingoo Han <[email protected]> wrote:
>>> On Thursday, May 29, 2014 3:31 PM, Sachin Kamat wrote:
>>>>
>>>> PTR_ERR_OR_ZERO simplifies the code.
>>>>
>>>> Signed-off-by: Sachin Kamat <[email protected]>
>>>> Cc: Jingoo Han <[email protected]>
>>>
>>> Acked-by: Jingoo Han <[email protected]>
>>>
>>> Best regards,
>>> Jingoo Han
>>>
>>>> ---
>>>> drivers/phy/phy-exynos-dp-video.c | 5 ++---
>>>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/drivers/phy/phy-exynos-dp-video.c b/drivers/phy/phy-exynos-dp-video.c
>>>> index 0786fef842e7..098f822a2fa4 100644
>>>> --- a/drivers/phy/phy-exynos-dp-video.c
>>>> +++ b/drivers/phy/phy-exynos-dp-video.c
>>>> @@ -9,6 +9,7 @@
>>>> * published by the Free Software Foundation.
>>>> */
>>>>
>>>> +#include <linux/err.h>
>>>> #include <linux/io.h>
>>>> #include <linux/kernel.h>
>>>> #include <linux/module.h>
>>>> @@ -84,10 +85,8 @@ static int exynos_dp_video_phy_probe(struct platform_device *pdev)
>>>> phy_set_drvdata(phy, state);
>>>>
>>>> phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
>>>> - if (IS_ERR(phy_provider))
>>>> - return PTR_ERR(phy_provider);
>>>>
>>>> - return 0;
>>>> + return PTR_ERR_OR_ZERO(phy_provider);
>>>> }
>>>>
>>>> static const struct of_device_id exynos_dp_video_phy_of_match[] = {
>>>> --
>>>> 1.7.9.5
>>>
>>>
>>
>> ping on this series.
>
> I'll queue to -next once -rc1 is tagged.

Gentle ping..


--
Regards,
Sachin.