Commit e4ac92d (serial: samsung: Neaten dbg uses) contains a typo in the
changed dbg() function regarding the name of the used character buffer.
This breaks the build if actually compiled with CONFIG_SERIAL_SAMSUNG_DEBUG.
Signed-off-by: Christian Engelmayer <[email protected]>
---
Compile tested. Applies against branch tty-next in tree
git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
---
drivers/tty/serial/samsung.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
index 3293377..c1d3ebd 100644
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -66,7 +66,7 @@ static void dbg(const char *fmt, ...)
char buff[256];
va_start(va, fmt);
- vscnprintf(buff, sizeof(buf), fmt, va);
+ vscnprintf(buff, sizeof(buff), fmt, va);
va_end(va);
printascii(buff);
--
1.9.1
Greg? Can you please apply this soon?
Thanks.
On Sat, 2014-06-14 at 22:07 +0200, Christian Engelmayer wrote:
> Commit e4ac92d (serial: samsung: Neaten dbg uses) contains a typo in the
> changed dbg() function regarding the name of the used character buffer.
> This breaks the build if actually compiled with CONFIG_SERIAL_SAMSUNG_DEBUG.
>
> Signed-off-by: Christian Engelmayer <[email protected]>
> ---
> Compile tested. Applies against branch tty-next in tree
> git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git
> ---
> drivers/tty/serial/samsung.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index 3293377..c1d3ebd 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -66,7 +66,7 @@ static void dbg(const char *fmt, ...)
> char buff[256];
>
> va_start(va, fmt);
> - vscnprintf(buff, sizeof(buf), fmt, va);
> + vscnprintf(buff, sizeof(buff), fmt, va);
> va_end(va);
>
> printascii(buff);
On Sun, Jun 15, 2014 at 2:03 AM, Joe Perches <[email protected]> wrote:
> Greg? Can you please apply this soon?
A similar patch has already been posted [1]. Probably Greg will apply it
once 3.16-rc1 is out.
[1] http://www.spinics.net/lists/linux-serial/msg12843.html
Regards,
Sachin.
>
> Thanks.
>
> On Sat, 2014-06-14 at 22:07 +0200, Christian Engelmayer wrote:
>> Commit e4ac92d (serial: samsung: Neaten dbg uses) contains a typo in the
>> changed dbg() function regarding the name of the used character buffer.
>> This breaks the build if actually compiled with CONFIG_SERIAL_SAMSUNG_DEBUG.
>>
>> Signed-off-by: Christian Engelmayer <[email protected]>
On Sun, 2014-06-15 at 23:06 +0530, Sachin Kamat wrote:
> On Sun, Jun 15, 2014 at 2:03 AM, Joe Perches <[email protected]> wrote:
> > Greg? Can you please apply this soon?
>
> A similar patch has already been posted [1]. Probably Greg will apply it
> once 3.16-rc1 is out.
>
> [1] http://www.spinics.net/lists/linux-serial/msg12843.html
I know. It was just another prompt to Greg.
It's just unfortunate to have a compile failure path
in Linus' tree. Especially one I introduced.
He'd said 10 days ago or so it'd be a day or two.
http://www.spinics.net/lists/linux-serial/msg12859.html
cheers, Joe
On Sun, Jun 15, 2014 at 10:46:56AM -0700, Joe Perches wrote:
> On Sun, 2014-06-15 at 23:06 +0530, Sachin Kamat wrote:
> > On Sun, Jun 15, 2014 at 2:03 AM, Joe Perches <[email protected]> wrote:
> > > Greg? Can you please apply this soon?
> >
> > A similar patch has already been posted [1]. Probably Greg will apply it
> > once 3.16-rc1 is out.
> >
> > [1] http://www.spinics.net/lists/linux-serial/msg12843.html
>
> I know. It was just another prompt to Greg.
>
> It's just unfortunate to have a compile failure path
> in Linus' tree. Especially one I introduced.
>
> He'd said 10 days ago or so it'd be a day or two.
>
> http://www.spinics.net/lists/linux-serial/msg12859.html
Life gets in the way, I'll get it merged in time for 3.16-rc2 or -3.
thanks,
greg k-h