2014-06-03 09:54:35

by Arnd Bergmann

Subject: [PATCH] serial: samsung: fix typo in debug code

commit e4ac92df2791 ("serial: samsung: Neaten dbg uses") introduced
a regression in the conversion from vsprintf to vsnprintf.

This fixes the build error by passing the correct variable name.

Signed-off-by: Arnd Bergmann <[email protected]>
Cc: Joe Perches <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Doug Anderson <[email protected]>
Cc: Kukjin Kim <[email protected]>

diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
index 3293377..c1d3ebd 100644
--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c
@@ -66,7 +66,7 @@ static void dbg(const char *fmt, ...)
char buff[256];

va_start(va, fmt);
- vscnprintf(buff, sizeof(buf), fmt, va);
+ vscnprintf(buff, sizeof(buff), fmt, va);
va_end(va);

printascii(buff);

2014-06-03 11:27:31

by Sachin Kamat

Subject: Re: [PATCH] serial: samsung: fix typo in debug code

Hi Arnd,

On Tue, Jun 3, 2014 at 3:23 PM, Arnd Bergmann <[email protected]> wrote:
> commit e4ac92df2791 ("serial: samsung: Neaten dbg uses") introduced
> a regression in the conversion from vsprintf to vsnprintf.
>
> This fixes the build error by passing the correct variable name.

I submitted a similar patch sometime back.
http://www.spinics.net/lists/linux-serial/msg12843.html

Regards,
Sachin

2014-06-05 01:20:47

by Joe Perches

Subject: Re: [PATCH] serial: samsung: fix typo in debug code

On Tue, 2014-06-03 at 11:53 +0200, Arnd Bergmann wrote:
> commit e4ac92df2791 ("serial: samsung: Neaten dbg uses") introduced
> a regression in the conversion from vsprintf to vsnprintf.
>
> This fixes the build error by passing the correct variable name.
>
> Signed-off-by: Arnd Bergmann <[email protected]>
> Cc: Joe Perches <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: Doug Anderson <[email protected]>
> Cc: Kukjin Kim <[email protected]>
>
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index 3293377..c1d3ebd 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -66,7 +66,7 @@ static void dbg(const char *fmt, ...)
> char buff[256];
>
> va_start(va, fmt);
> - vscnprintf(buff, sizeof(buf), fmt, va);
> + vscnprintf(buff, sizeof(buff), fmt, va);
> va_end(va);
>
> printascii(buff);

Greg?

The original has ended up in Linus' -next branch.

Can you please apply this sooner rather than later?

Sorry for the bother. Dunno how it happened.

I thought I compiled it with the appropriate CONFIG
settings.

2014-06-05 02:55:04

by Greg Kroah-Hartman

Subject: Re: [PATCH] serial: samsung: fix typo in debug code

On Wed, Jun 04, 2014 at 06:20:41PM -0700, Joe Perches wrote:
> On Tue, 2014-06-03 at 11:53 +0200, Arnd Bergmann wrote:
> > commit e4ac92df2791 ("serial: samsung: Neaten dbg uses") introduced
> > a regression in the conversion from vsprintf to vsnprintf.
> >
> > This fixes the build error by passing the correct variable name.
> >
> > Signed-off-by: Arnd Bergmann <[email protected]>
> > Cc: Joe Perches <[email protected]>
> > Cc: Greg Kroah-Hartman <[email protected]>
> > Cc: Doug Anderson <[email protected]>
> > Cc: Kukjin Kim <[email protected]>
> >
> > diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> > index 3293377..c1d3ebd 100644
> > --- a/drivers/tty/serial/samsung.c
> > +++ b/drivers/tty/serial/samsung.c
> > @@ -66,7 +66,7 @@ static void dbg(const char *fmt, ...)
> > char buff[256];
> >
> > va_start(va, fmt);
> > - vscnprintf(buff, sizeof(buf), fmt, va);
> > + vscnprintf(buff, sizeof(buff), fmt, va);
> > va_end(va);
> >
> > printascii(buff);
>
> Greg?
>
> The original has ended up in Linus' -next branch.
>
> Can you please apply this sooner rather than later?

Let me work through these 3.4-stable patches first, so give me a day or
so, thanks.

greg k-h