2014-07-21 21:17:44

by Marek Belisko

[permalink] [raw]
Subject: [PATCH] Documentation: dts: tcs6507: Fix wrong statement about #gpio-cells

Update comment about gpio-cells which says not correctly to be set to 0.
When we want to reference tca6507 gpio #gpio-cells must be set to 2 (it is
already correct in example).

Signed-off-by: Marek Belisko <[email protected]>
---
Documentation/devicetree/bindings/leds/tca6507.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/leds/tca6507.txt b/Documentation/devicetree/bindings/leds/tca6507.txt
index d7221b8..bad9102 100644
--- a/Documentation/devicetree/bindings/leds/tca6507.txt
+++ b/Documentation/devicetree/bindings/leds/tca6507.txt
@@ -8,7 +8,7 @@ Required properties:

Optional properties:
- gpio-controller: allows lines to be used as output-only GPIOs.
-- #gpio-cells: if present, must be 0.
+- #gpio-cells: if present, must not be 0.

Each led is represented as a sub-node of the ti,tca6507 device.

--
1.9.1


2014-07-22 23:42:13

by Bryan Wu

[permalink] [raw]
Subject: Re: [PATCH] Documentation: dts: tcs6507: Fix wrong statement about #gpio-cells

On Mon, Jul 21, 2014 at 2:17 PM, Marek Belisko <[email protected]> wrote:
> Update comment about gpio-cells which says not correctly to be set to 0.
> When we want to reference tca6507 gpio #gpio-cells must be set to 2 (it is
> already correct in example).
>

Good fix. I applied it
Thanks,
-Bryan

> Signed-off-by: Marek Belisko <[email protected]>
> ---
> Documentation/devicetree/bindings/leds/tca6507.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/tca6507.txt b/Documentation/devicetree/bindings/leds/tca6507.txt
> index d7221b8..bad9102 100644
> --- a/Documentation/devicetree/bindings/leds/tca6507.txt
> +++ b/Documentation/devicetree/bindings/leds/tca6507.txt
> @@ -8,7 +8,7 @@ Required properties:
>
> Optional properties:
> - gpio-controller: allows lines to be used as output-only GPIOs.
> -- #gpio-cells: if present, must be 0.
> +- #gpio-cells: if present, must not be 0.
>
> Each led is represented as a sub-node of the ti,tca6507 device.
>
> --
> 1.9.1
>