2012-08-01 21:05:41

by Ondrej Zary

Subject: [PATCH 1/2] leds-clevo-mail: add MODULE_DEVICE_TABLE

Enable autoloading of leds-clevo-mail by using MODULE_DEVICE_TABLE.

Signed-off-by: Ondrej Zary <[email protected]>

--- a/drivers/leds/leds-clevo-mail.c
+++ b/drivers/leds/leds-clevo-mail.c
@@ -31,7 +31,7 @@ static int __init clevo_mail_led_dmi_callback(const struct dmi_system_id *id)
}

/*
- * struct mail_led_whitelist - List of known good models
+ * struct clevo_mail_led_dmi_table - List of known good models
*
* Contains the known good models this driver is compatible with.
* When adding a new model try to be as strict as possible. This
@@ -39,7 +39,7 @@ static int __init clevo_mail_led_dmi_callback(const struct dmi_system_id *id)
* detected as working, but in reality it is not) as low as
* possible.
*/
-static struct dmi_system_id __initdata mail_led_whitelist[] = {
+static struct dmi_system_id __initdata clevo_mail_led_dmi_table[] = {
{
.callback = clevo_mail_led_dmi_callback,
.ident = "Clevo D410J",
@@ -89,6 +89,7 @@ static struct dmi_system_id __initdata mail_led_whitelist[] = {
},
{ }
};
+MODULE_DEVICE_TABLE(dmi, clevo_mail_led_dmi_table);

static void clevo_mail_led_set(struct led_classdev *led_cdev,
enum led_brightness value)
@@ -180,7 +181,7 @@ static int __init clevo_mail_led_init(void)

/* Check with the help of DMI if we are running on supported hardware */
if (!nodetect) {
- count = dmi_check_system(mail_led_whitelist);
+ count = dmi_check_system(clevo_mail_led_dmi_table);
} else {
count = 1;
printk(KERN_ERR KBUILD_MODNAME ": Skipping DMI detection. "




--
Ondrej Zary

2012-08-02 03:46:05

by Bryan Wu

Subject: Re: [PATCH 1/2] leds-clevo-mail: add MODULE_DEVICE_TABLE

On Thu, Aug 2, 2012 at 5:04 AM, Ondrej Zary <[email protected]> wrote:
> Enable autoloading of leds-clevo-mail by using MODULE_DEVICE_TABLE.
>

Thanks, applied to my for-next branch
-Bryan

> Signed-off-by: Ondrej Zary <[email protected]>
>
> --- a/drivers/leds/leds-clevo-mail.c
> +++ b/drivers/leds/leds-clevo-mail.c
> @@ -31,7 +31,7 @@ static int __init clevo_mail_led_dmi_callback(const struct dmi_system_id *id)
> }
>
> /*
> - * struct mail_led_whitelist - List of known good models
> + * struct clevo_mail_led_dmi_table - List of known good models
> *
> * Contains the known good models this driver is compatible with.
> * When adding a new model try to be as strict as possible. This
> @@ -39,7 +39,7 @@ static int __init clevo_mail_led_dmi_callback(const struct dmi_system_id *id)
> * detected as working, but in reality it is not) as low as
> * possible.
> */
> -static struct dmi_system_id __initdata mail_led_whitelist[] = {
> +static struct dmi_system_id __initdata clevo_mail_led_dmi_table[] = {
> {
> .callback = clevo_mail_led_dmi_callback,
> .ident = "Clevo D410J",
> @@ -89,6 +89,7 @@ static struct dmi_system_id __initdata mail_led_whitelist[] = {
> },
> { }
> };
> +MODULE_DEVICE_TABLE(dmi, clevo_mail_led_dmi_table);
>
> static void clevo_mail_led_set(struct led_classdev *led_cdev,
> enum led_brightness value)
> @@ -180,7 +181,7 @@ static int __init clevo_mail_led_init(void)
>
> /* Check with the help of DMI if we are running on supported hardware */
> if (!nodetect) {
> - count = dmi_check_system(mail_led_whitelist);
> + count = dmi_check_system(clevo_mail_led_dmi_table);
> } else {
> count = 1;
> printk(KERN_ERR KBUILD_MODNAME ": Skipping DMI detection. "
>
>
>
>
> --
> Ondrej Zary



--
Bryan Wu <[email protected]>
Kernel Developer +86.186-168-78255 Mobile
Canonical Ltd. http://www.canonical.com
Ubuntu - Linux for human beings | http://www.ubuntu.com