2014-10-02 07:12:39

by Linus Walleij

Subject: Re: [PATCH 2/2] led: remove use of gpiochip_remove() retval

On Tue, Sep 30, 2014 at 11:21 PM, Bryan Wu <[email protected]> wrote:
> On Tue, Sep 30, 2014 at 7:35 AM, Pramod Gurav
> <[email protected]> wrote:
>> Get rid of using return value from gpiochip_remove() as it returns
>> void.
>
> Looks good to me. I will merge it.

Please don't.

The issue is already fixed through the GPIO tree, where the
API change is.

Yours,
Linus Walleij

2014-10-03 17:15:45

by Bryan Wu

Subject: Re: [PATCH 2/2] led: remove use of gpiochip_remove() retval

On Thu, Oct 2, 2014 at 12:12 AM, Linus Walleij <[email protected]> wrote:
> On Tue, Sep 30, 2014 at 11:21 PM, Bryan Wu <[email protected]> wrote:
>> On Tue, Sep 30, 2014 at 7:35 AM, Pramod Gurav
>> <[email protected]> wrote:
>>> Get rid of using return value from gpiochip_remove() as it returns
>>> void.
>>
>> Looks good to me. I will merge it.
>
> Please don't.
>
> The issue is already fixed through the GPIO tree, where the
> API change is.
>

Oh, really. I wasn't aware that. Let me drop this change then.

Thanks,
-Bryan