2014-04-24 15:47:28

by Masanari Iida

Subject: [PATCH] video/backlight: Fix string type mismatch in s6e63m0.c

Fix string type mismatch in s6e63m0_sysfs_show_gamma_table().
gamma_table_count is defined as unsigned int.

Signed-off-by: Masanari Iida <[email protected]>
---
drivers/video/backlight/s6e63m0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/backlight/s6e63m0.c b/drivers/video/backlight/s6e63m0.c
index 510a1bc..2d6d481 100644
--- a/drivers/video/backlight/s6e63m0.c
+++ b/drivers/video/backlight/s6e63m0.c
@@ -703,7 +703,7 @@ static ssize_t s6e63m0_sysfs_show_gamma_table(struct device *dev,
struct s6e63m0 *lcd = dev_get_drvdata(dev);
char temp[3];

- sprintf(temp, "%d\n", lcd->gamma_table_count);
+ sprintf(temp, "%u\n", lcd->gamma_table_count);
strcpy(buf, temp);

return strlen(buf);
--
2.0.0.rc0.26.g779792a

2014-04-24 16:36:36

by Bryan Wu

Subject: Re: [PATCH] video/backlight: Fix string type mismatch in s6e63m0.c

On Thu, Apr 24, 2014 at 8:47 AM, Masanari Iida <[email protected]> wrote:
> Fix string type mismatch in s6e63m0_sysfs_show_gamma_table().
> gamma_table_count is defined as unsigned int.
>

Looks good to me,
Acked-by: Bryan Wu <[email protected]>

> Signed-off-by: Masanari Iida <[email protected]>
> ---
> drivers/video/backlight/s6e63m0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/backlight/s6e63m0.c b/drivers/video/backlight/s6e63m0.c
> index 510a1bc..2d6d481 100644
> --- a/drivers/video/backlight/s6e63m0.c
> +++ b/drivers/video/backlight/s6e63m0.c
> @@ -703,7 +703,7 @@ static ssize_t s6e63m0_sysfs_show_gamma_table(struct device *dev,
> struct s6e63m0 *lcd = dev_get_drvdata(dev);
> char temp[3];
>
> - sprintf(temp, "%d\n", lcd->gamma_table_count);
> + sprintf(temp, "%u\n", lcd->gamma_table_count);
> strcpy(buf, temp);
>
> return strlen(buf);
> --
> 2.0.0.rc0.26.g779792a
>

2014-04-28 10:27:46

by Lee Jones

Subject: Re: [PATCH] video/backlight: Fix string type mismatch in s6e63m0.c

> Fix string type mismatch in s6e63m0_sysfs_show_gamma_table().
> gamma_table_count is defined as unsigned int.
>
> Signed-off-by: Masanari Iida <[email protected]>
> ---
> drivers/video/backlight/s6e63m0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog