2012-10-05 08:10:07

by Kim, Milo

Subject: [PATCH 00/28] leds: add common driver for LP5521/5523/55231

LP5521, LP5523 and L55231 have common features as below.

Register access via the I2C.
Device initialization/de-initialization.
Create LED class devices for multiple output channels.
Device attributes for user-space interface.

Therefore, this series of patch set enables removing duplicate code for
lp5521/5523 driver and making coherent driver structure.

All patches have been tested in LP5521, LP5523 and LP55231 boards.

Signed-off-by: Milo(Woogyom) Kim <[email protected]>
Tested-by: Milo(Woogyom) Kim <[email protected]>
---
Documentation/leds/00-INDEX | 2 +
Documentation/leds/leds-lp5521.txt | 63 +-
Documentation/leds/leds-lp5523.txt | 27 +-
Documentation/leds/leds-lp55xx.txt | 104 +++
arch/arm/mach-omap2/board-rx51-peripherals.c | 8 +-
arch/arm/mach-ux500/board-mop500.c | 14 +-
drivers/leds/Kconfig | 15 +-
drivers/leds/Makefile | 1 +
drivers/leds/leds-lp5521.c | 928 +++++++---------------
drivers/leds/leds-lp5523.c | 1065 +++++++-------------------
drivers/leds/leds-lp55xx-common.c | 516 +++++++++++++
drivers/leds/leds-lp55xx-common.h | 138 ++++
include/linux/leds-lp5521.h | 73 --
include/linux/leds-lp5523.h | 49 --
include/linux/platform_data/leds-lp55xx.h | 55 ++
15 files changed, 1374 insertions(+), 1684 deletions(-)
create mode 100644 Documentation/leds/leds-lp55xx.txt
create mode 100644 drivers/leds/leds-lp55xx-common.c
create mode 100644 drivers/leds/leds-lp55xx-common.h
delete mode 100644 include/linux/leds-lp5521.h
delete mode 100644 include/linux/leds-lp5523.h
create mode 100644 include/linux/platform_data/leds-lp55xx.h

Best Regards,
Milo

2012-10-12 16:08:40

by Bryan Wu

Subject: Re: [PATCH 00/28] leds: add common driver for LP5521/5523/55231

Sorry for the delay. These days I'm moving and I will review this
patchset after I settle down.

Thanks a lot,
-Bryan

On Fri, Oct 5, 2012 at 4:09 PM, Kim, Milo <[email protected]> wrote:
> LP5521, LP5523 and L55231 have common features as below.
>
> Register access via the I2C.
> Device initialization/de-initialization.
> Create LED class devices for multiple output channels.
> Device attributes for user-space interface.
>
> Therefore, this series of patch set enables removing duplicate code for
> lp5521/5523 driver and making coherent driver structure.
>
> All patches have been tested in LP5521, LP5523 and LP55231 boards.
>
> Signed-off-by: Milo(Woogyom) Kim <[email protected]>
> Tested-by: Milo(Woogyom) Kim <[email protected]>
> ---
> Documentation/leds/00-INDEX | 2 +
> Documentation/leds/leds-lp5521.txt | 63 +-
> Documentation/leds/leds-lp5523.txt | 27 +-
> Documentation/leds/leds-lp55xx.txt | 104 +++
> arch/arm/mach-omap2/board-rx51-peripherals.c | 8 +-
> arch/arm/mach-ux500/board-mop500.c | 14 +-
> drivers/leds/Kconfig | 15 +-
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-lp5521.c | 928 +++++++---------------
> drivers/leds/leds-lp5523.c | 1065 +++++++-------------------
> drivers/leds/leds-lp55xx-common.c | 516 +++++++++++++
> drivers/leds/leds-lp55xx-common.h | 138 ++++
> include/linux/leds-lp5521.h | 73 --
> include/linux/leds-lp5523.h | 49 --
> include/linux/platform_data/leds-lp55xx.h | 55 ++
> 15 files changed, 1374 insertions(+), 1684 deletions(-)
> create mode 100644 Documentation/leds/leds-lp55xx.txt
> create mode 100644 drivers/leds/leds-lp55xx-common.c
> create mode 100644 drivers/leds/leds-lp55xx-common.h
> delete mode 100644 include/linux/leds-lp5521.h
> delete mode 100644 include/linux/leds-lp5523.h
> create mode 100644 include/linux/platform_data/leds-lp55xx.h
>
> Best Regards,
> Milo
>
>



--
Bryan Wu <[email protected]>
Kernel Developer +86.186-168-78255 Mobile
Canonical Ltd. http://www.canonical.com
Ubuntu - Linux for human beings | http://www.ubuntu.com