2023-05-23 15:19:56

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: core: Streamline debugfs operations

On Tue, May 23, 2023 at 05:03:58PM +0200, Geert Uytterhoeven wrote:

> Fix the error check on the return value of debugfs_create_dir() in
> create_regulator(), which was missed before.
>
> Fixes: 2bf1c45be3b8f3a3 ("regulator: Fix error checking for debugfs_create_dir")

Also: this should be a separate patch.


Attachments:
(No filename) (319.00 B)
signature.asc (499.00 B)
Download all attachments

2023-05-23 16:59:59

by Osama Muhammad

[permalink] [raw]
Subject: Re: [PATCH] regulator: core: Streamline debugfs operations

Hi,

The patch to Fix error checking for debugfs_create_dir has already
been submitted.
Here is the link to the patch :-
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/?id=2bf1c45be3b8f3a3f898d0756c1282f09719debd


On Tue, 23 May 2023 at 20:17, Mark Brown <[email protected]> wrote:
>
> On Tue, May 23, 2023 at 05:03:58PM +0200, Geert Uytterhoeven wrote:
>
> > Fix the error check on the return value of debugfs_create_dir() in
> > create_regulator(), which was missed before.
> >
> > Fixes: 2bf1c45be3b8f3a3 ("regulator: Fix error checking for debugfs_create_dir")
>
> Also: this should be a separate patch.

2023-05-24 06:46:40

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] regulator: core: Streamline debugfs operations

Hi Mark,

On Tue, May 23, 2023 at 5:17 PM Mark Brown <[email protected]> wrote:
> On Tue, May 23, 2023 at 05:03:58PM +0200, Geert Uytterhoeven wrote:
> > Fix the error check on the return value of debugfs_create_dir() in
> > create_regulator(), which was missed before.
> >
> > Fixes: 2bf1c45be3b8f3a3 ("regulator: Fix error checking for debugfs_create_dir")
>
> Also: this should be a separate patch.

I can do that, sure (patch stats++ ;-)

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2023-05-24 06:54:23

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] regulator: core: Streamline debugfs operations

Hi Osama,

On Tue, May 23, 2023 at 6:48 PM Osama Muhammad <[email protected]> wrote:
> The patch to Fix error checking for debugfs_create_dir has already
> been submitted.
> Here is the link to the patch :-
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git/commit/?id=2bf1c45be3b8f3a3f898d0756c1282f09719debd

Your patch fixed two cases, but missed the third.

> On Tue, 23 May 2023 at 20:17, Mark Brown <[email protected]> wrote:
> >
> > On Tue, May 23, 2023 at 05:03:58PM +0200, Geert Uytterhoeven wrote:
> >
> > > Fix the error check on the return value of debugfs_create_dir() in
> > > create_regulator(), which was missed before.
> > >
> > > Fixes: 2bf1c45be3b8f3a3 ("regulator: Fix error checking for debugfs_create_dir")
> >
> > Also: this should be a separate patch.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds