2019-08-10 07:55:04

by Christoph Hellwig

[permalink] [raw]
Subject: can we use mandatory-y for non-uapi headers?

Hi Masahiro,

what is the reason that the documentation says mandatory-y should only
be used for uapi headers? If would also be very useful for normal
asm-generic headers where most people use the generic version and we
only have a few overrides. Two headers that immediately come to mind
are dma-mapping.h, or msi.h.


2019-08-12 15:43:02

by Masahiro Yamada

[permalink] [raw]
Subject: Re: can we use mandatory-y for non-uapi headers?

Christoph,


On Sat, Aug 10, 2019 at 4:52 PM Christoph Hellwig <[email protected]> wrote:
>
> Hi Masahiro,
>
> what is the reason that the documentation says mandatory-y should only
> be used for uapi headers?

Where is it documented?

Documentation/kbuild/makefiles.rst section 7.4 describes
mandatory-y is essentially used by include/(uapi/)asm-generic/Kbuild

include/(uapi/)asm-generic/Kbuild means:

include/uapi/asm-generic/Kbuild
include/asm-generic/Kbuild




--
Best Regards
Masahiro Yamada

2019-08-12 18:03:22

by Christoph Hellwig

[permalink] [raw]
Subject: Re: can we use mandatory-y for non-uapi headers?

On Tue, Aug 13, 2019 at 12:41:20AM +0900, Masahiro Yamada wrote:
> > what is the reason that the documentation says mandatory-y should only
> > be used for uapi headers?
>
> Where is it documented?
>
> Documentation/kbuild/makefiles.rst section 7.4 describes
> mandatory-y is essentially used by include/(uapi/)asm-generic/Kbuild
>
> include/(uapi/)asm-generic/Kbuild means:
>
> include/uapi/asm-generic/Kbuild
> include/asm-generic/Kbuild

Ok, maybe it was just me misreading the documentation. In that
case I'll start submitting patches to use it more.