2022-05-27 18:50:10

by Josh Poimboeuf

[permalink] [raw]
Subject: Re: [PATCH v7 8/8] kbuild: rebuild multi-object modules when objtool is updated

On Fri, May 27, 2022 at 07:01:55PM +0900, Masahiro Yamada wrote:
> When CONFIG_LTO_CLANG or CONFIG_X86_KERNEL_IBT is enabled, objtool for
> multi-object modules is postponed until the objects are linked together.
>
> Make sure to re-run objtool and re-link multi-object modules when
> objtool is updated.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> Reviewed-by: Kees Cook <[email protected]>
> Acked-by: Josh Poimboeuf <[email protected]>
> Tested-by: Nathan Chancellor <[email protected]>
> Reviewed-by: Nicolas Schier <[email protected]>
> Tested-by: Sedat Dilek <[email protected]> # LLVM-14 (x86-64)

Hi Masahiro,

Is it also possible to rebuild vmlinux.o when objtool changes, for
CONFIG_LTO_CLANG, CONFIG_X86_KERNEL_IBT, or CONFIG_NOINSTR_VALIDATION?
That doesn't seem to be happening.

--
Josh


2022-05-28 18:38:29

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH v7 8/8] kbuild: rebuild multi-object modules when objtool is updated

On Sat, May 28, 2022 at 12:50 AM Josh Poimboeuf <[email protected]> wrote:
>
> On Fri, May 27, 2022 at 07:01:55PM +0900, Masahiro Yamada wrote:
> > When CONFIG_LTO_CLANG or CONFIG_X86_KERNEL_IBT is enabled, objtool for
> > multi-object modules is postponed until the objects are linked together.
> >
> > Make sure to re-run objtool and re-link multi-object modules when
> > objtool is updated.
> >
> > Signed-off-by: Masahiro Yamada <[email protected]>
> > Reviewed-by: Kees Cook <[email protected]>
> > Acked-by: Josh Poimboeuf <[email protected]>
> > Tested-by: Nathan Chancellor <[email protected]>
> > Reviewed-by: Nicolas Schier <[email protected]>
> > Tested-by: Sedat Dilek <[email protected]> # LLVM-14 (x86-64)
>
> Hi Masahiro,
>
> Is it also possible to rebuild vmlinux.o when objtool changes, for
> CONFIG_LTO_CLANG, CONFIG_X86_KERNEL_IBT, or CONFIG_NOINSTR_VALIDATION?
> That doesn't seem to be happening.
>
> --
> Josh

Yes.
Actually, it is already on my TODO list,
but it requires more effort.

I will aim for v5.20.







--
Best Regards
Masahiro Yamada