2019-10-05 15:06:20

by Randy Dunlap

Subject: [PATCH] scripts: setlocalversion: fix a bashism

From: Randy Dunlap <[email protected]>

Fix bashism reported by checkbashisms by using only one '=':

possible bashism in scripts/setlocalversion line 96 (should be 'b = a'):
if [ "`hg log -r . --template '{latesttagdistance}'`" == "1" ]; then

Fixes: 38b3439d84f4 ("setlocalversion: update mercurial tag parsing")
Signed-off-by: Randy Dunlap <[email protected]>
Cc: Mike Crowe <[email protected]>
---
Does anyone still use hg for kernel development?

scripts/setlocalversion | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- lnx-54-rc1.orig/scripts/setlocalversion
+++ lnx-54-rc1/scripts/setlocalversion
@@ -93,7 +93,7 @@ scm_version()
# Check for mercurial and a mercurial repo.
if test -d .hg && hgid=`hg id 2>/dev/null`; then
# Do we have an tagged version? If so, latesttagdistance == 1
- if [ "`hg log -r . --template '{latesttagdistance}'`" == "1" ]; then
+ if [ "`hg log -r . --template '{latesttagdistance}'`" = "1" ]; then
id=`hg log -r . --template '{latesttag}'`
printf '%s%s' -hg "$id"
else

2019-10-07 16:13:05

by Masahiro Yamada

Subject: Re: [PATCH] scripts: setlocalversion: fix a bashism

On Sun, Oct 6, 2019 at 12:02 AM Randy Dunlap <[email protected]> wrote:
>
> From: Randy Dunlap <[email protected]>
>
> Fix bashism reported by checkbashisms by using only one '=':
>
> possible bashism in scripts/setlocalversion line 96 (should be 'b = a'):
> if [ "`hg log -r . --template '{latesttagdistance}'`" == "1" ]; then
>
> Fixes: 38b3439d84f4 ("setlocalversion: update mercurial tag parsing")
> Signed-off-by: Randy Dunlap <[email protected]>
> Cc: Mike Crowe <[email protected]>

Applied to linux-kbuild. Thanks.

> ---
> Does anyone still use hg for kernel development?

I have also been wondering in which situation
this code is used...


>
> scripts/setlocalversion | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- lnx-54-rc1.orig/scripts/setlocalversion
> +++ lnx-54-rc1/scripts/setlocalversion
> @@ -93,7 +93,7 @@ scm_version()
> # Check for mercurial and a mercurial repo.
> if test -d .hg && hgid=`hg id 2>/dev/null`; then
> # Do we have an tagged version? If so, latesttagdistance == 1
> - if [ "`hg log -r . --template '{latesttagdistance}'`" == "1" ]; then
> + if [ "`hg log -r . --template '{latesttagdistance}'`" = "1" ]; then
> id=`hg log -r . --template '{latesttag}'`
> printf '%s%s' -hg "$id"
> else
>


--
Best Regards
Masahiro Yamada