2019-03-04 13:52:45

by Luc Van Oostenryck

[permalink] [raw]
Subject: [PATCH] kbuild: use -Werror=implicit-... instead of -Werror-implicit-...

The flag '-Werror-implicit-function-declaration', present in GCC 2.95,
stopped to be documented in GCC 4.3, replaced by the more generic
'-Werror=...' form.

So, use the equivalent '-Werror=implicit-function-declaration' instead.

Signed-off-by: Luc Van Oostenryck <[email protected]>
---
Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index d5713e7b1e50..253e5ede92e7 100644
--- a/Makefile
+++ b/Makefile
@@ -429,7 +429,7 @@ LINUXINCLUDE := \
KBUILD_AFLAGS := -D__ASSEMBLY__ -fno-PIE
KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
-fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE \
- -Werror-implicit-function-declaration -Werror=implicit-int \
+ -Werror=implicit-function-declaration -Werror=implicit-int \
-Wno-format-security \
-std=gnu89
KBUILD_CPPFLAGS := -D__KERNEL__
--
2.21.0



2019-03-06 19:04:00

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH] kbuild: use -Werror=implicit-... instead of -Werror-implicit-...

On Mon, Mar 4, 2019 at 9:55 PM Luc Van Oostenryck
<[email protected]> wrote:
>
> The flag '-Werror-implicit-function-declaration', present in GCC 2.95,
> stopped to be documented in GCC 4.3, replaced by the more generic
> '-Werror=...' form.
>
> So, use the equivalent '-Werror=implicit-function-declaration' instead.
>
> Signed-off-by: Luc Van Oostenryck <[email protected]>
> ---

Applied to linux-kbuild.
Thanks.



> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index d5713e7b1e50..253e5ede92e7 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -429,7 +429,7 @@ LINUXINCLUDE := \
> KBUILD_AFLAGS := -D__ASSEMBLY__ -fno-PIE
> KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
> -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE \
> - -Werror-implicit-function-declaration -Werror=implicit-int \
> + -Werror=implicit-function-declaration -Werror=implicit-int \
> -Wno-format-security \
> -std=gnu89
> KBUILD_CPPFLAGS := -D__KERNEL__
> --
> 2.21.0
>


--
Best Regards
Masahiro Yamada