2021-03-15 06:58:15

by Yang Li

Subject: [PATCH] kconfig: use true and false for bool variable

fixed the following coccicheck:
./scripts/kconfig/confdata.c:36:9-10: WARNING: return of 0/1 in function
'is_dir' with return type bool

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
scripts/kconfig/confdata.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
index 2568dbe..b65b8c3 100644
--- a/scripts/kconfig/confdata.c
+++ b/scripts/kconfig/confdata.c
@@ -33,7 +33,7 @@ static bool is_dir(const char *path)
struct stat st;

if (stat(path, &st))
- return 0;
+ return false;

return S_ISDIR(st.st_mode);
}
--
1.8.3.1

2021-03-25 04:49:50

by Masahiro Yamada

Subject: Re: [PATCH] kconfig: use true and false for bool variable

On Mon, Mar 15, 2021 at 3:55 PM Yang Li <[email protected]> wrote:
>
> fixed the following coccicheck:
> ./scripts/kconfig/confdata.c:36:9-10: WARNING: return of 0/1 in function
> 'is_dir' with return type bool
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---

Applied. Thanks.




> scripts/kconfig/confdata.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
> index 2568dbe..b65b8c3 100644
> --- a/scripts/kconfig/confdata.c
> +++ b/scripts/kconfig/confdata.c
> @@ -33,7 +33,7 @@ static bool is_dir(const char *path)
> struct stat st;
>
> if (stat(path, &st))
> - return 0;
> + return false;
>
> return S_ISDIR(st.st_mode);
> }
> --
> 1.8.3.1
>


--
Best Regards
Masahiro Yamada