2020-08-31 06:55:39

by Denis Efremov (Oracle)

[permalink] [raw]
Subject: [PATCH] kconfig: remove redundant assignment prompt = prompt

Semi-automatic removing of localization macros changed the line
from "prompt = _(prompt);" to "prompt = prompt;". Drop the
reduntand assignment.

Fixes: 694c49a7c01c ("kconfig: drop localization support")
Signed-off-by: Denis Efremov <[email protected]>
---
scripts/kconfig/nconf.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
index daf1c1506ec4..e0f965529166 100644
--- a/scripts/kconfig/nconf.c
+++ b/scripts/kconfig/nconf.c
@@ -755,7 +755,6 @@ static void build_conf(struct menu *menu)
switch (ptype) {
case P_MENU:
child_count++;
- prompt = prompt;
if (single_menu_mode) {
item_make(menu, 'm',
"%s%*c%s",
--
2.26.2


2020-08-31 10:55:40

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH] kconfig: remove redundant assignment prompt = prompt

On Mon, Aug 31, 2020 at 3:52 PM Denis Efremov <[email protected]> wrote:
>
> Semi-automatic removing of localization macros changed the line
> from "prompt = _(prompt);" to "prompt = prompt;". Drop the
> reduntand assignment.
>
> Fixes: 694c49a7c01c ("kconfig: drop localization support")
> Signed-off-by: Denis Efremov <[email protected]>
> ---

Applied to linux-kbuild/fixes. Thanks.


> scripts/kconfig/nconf.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
> index daf1c1506ec4..e0f965529166 100644
> --- a/scripts/kconfig/nconf.c
> +++ b/scripts/kconfig/nconf.c
> @@ -755,7 +755,6 @@ static void build_conf(struct menu *menu)
> switch (ptype) {
> case P_MENU:
> child_count++;
> - prompt = prompt;
> if (single_menu_mode) {
> item_make(menu, 'm',
> "%s%*c%s",
> --
> 2.26.2
>


--
Best Regards
Masahiro Yamada