2024-05-28 20:08:09

by Rob Herring (Arm)

[permalink] [raw]
Subject: [PATCH] dt-bindings: kbuild: Fix dt_binding_check on unconfigured build

The 'dt_binding_check' target shouldn't depend on the kernel
configuration, but it has since commit 604a57ba9781 ("dt-bindings:
kbuild: Add separate target/dependency for processed-schema.json").
That is because CHECK_DT_BINDING make variable was dropped, but
scripts/dtc/Makefile was missed. The CHECK_DTBS variable can be used
instead.

Reported-by: Francesco Dolcini <[email protected]>
Fixes: 604a57ba9781 ("dt-bindings: kbuild: Add separate target/dependency for processed-schema.json")
Signed-off-by: Rob Herring (Arm) <[email protected]>
---
scripts/dtc/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/dtc/Makefile b/scripts/dtc/Makefile
index a18657072541..b47f4daa4515 100644
--- a/scripts/dtc/Makefile
+++ b/scripts/dtc/Makefile
@@ -3,7 +3,7 @@

# *** Also keep .gitignore in sync when changing ***
hostprogs-always-$(CONFIG_DTC) += dtc fdtoverlay
-hostprogs-always-$(CHECK_DT_BINDING) += dtc
+hostprogs-always-$(CHECK_DTBS) += dtc

dtc-objs := dtc.o flattree.o fstree.o data.o livetree.o treesource.o \
srcpos.o checks.o util.o
--
2.43.0



2024-05-29 10:11:44

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: kbuild: Fix dt_binding_check on unconfigured build

On Wed, May 29, 2024 at 5:03 AM Rob Herring (Arm) <[email protected]> wrote:
>
> The 'dt_binding_check' target shouldn't depend on the kernel
> configuration, but it has since commit 604a57ba9781 ("dt-bindings:
> kbuild: Add separate target/dependency for processed-schema.json").
> That is because CHECK_DT_BINDING make variable was dropped, but
> scripts/dtc/Makefile was missed. The CHECK_DTBS variable can be used
> instead.
>
> Reported-by: Francesco Dolcini <[email protected]>
> Fixes: 604a57ba9781 ("dt-bindings: kbuild: Add separate target/dependency for processed-schema.json")
> Signed-off-by: Rob Herring (Arm) <[email protected]>


Applied to linux-kbuild.
Thanks!


--
Best Regards
Masahiro Yamada