2019-08-13 15:50:40

by Masahiro Yamada

[permalink] [raw]
Subject: Re: [PATCH v2] kbuild: Parameterize kallsyms generation and correct reporting

On Wed, Aug 14, 2019 at 12:15 AM Kees Cook <[email protected]> wrote:
>
> When kallsyms generation happens, temporary vmlinux outputs are linked
> but the quiet make output didn't report it, giving the impression that
> the prior command is taking longer than expected.
>
> Instead, report the linking step explicitly. While at it, this
> consolidates the repeated "kallsyms generation step" into a single
> function and removes the existing copy/pasting.
>
> Signed-off-by: Kees Cook <[email protected]>
> ---
> v2:
> - rename $kallsymso_previous to $kallsymso_prev (Masahiro)
> - move location of kallsyms_step() (Masahiro)
> - report linking step instead of folding it into KSYM (Masahiro)

Applied to linux-kbuild.
Thanks!



--
Best Regards
Masahiro Yamada