Hi all,
After merging the kbuild tree, today's linux-next build (powerpc
ppc64_defconfig) produced these warnings:
Presumably introduced by commit
1267f9d3047d ("kbuild: add $(BASH) to run scripts with bash-extension")
and presumably arch/powerpc/tools/unrel_branch_check.sh (which has no
#! line) is a bash script. Yeah, is uses '((' and '))'.
--
Cheers,
Stephen Rothwell
Hi Stephen,
On Wed, Sep 4, 2019 at 9:13 AM Stephen Rothwell <[email protected]> wrote:
>
> Hi all,
>
> After merging the kbuild tree, today's linux-next build (powerpc
> ppc64_defconfig) produced these warnings:
>
>
> Presumably introduced by commit
>
> 1267f9d3047d ("kbuild: add $(BASH) to run scripts with bash-extension")
>
> and presumably arch/powerpc/tools/unrel_branch_check.sh (which has no
> #! line) is a bash script. Yeah, is uses '((' and '))'.
Thanks for catching this.
Could you fix it up as follows?
I will squash it for tomorrow's linux-next.
--- a/arch/powerpc/Makefile.postlink
+++ b/arch/powerpc/Makefile.postlink
@@ -18,7 +18,7 @@ quiet_cmd_relocs_check = CHKREL $@
ifdef CONFIG_PPC_BOOK3S_64
cmd_relocs_check = \
$(CONFIG_SHELL) $(srctree)/arch/powerpc/tools/relocs_check.sh
"$(OBJDUMP)" "$@" ; \
- $(CONFIG_SHELL)
$(srctree)/arch/powerpc/tools/unrel_branch_check.sh "$(OBJDUMP)" "$@"
+ $(BASH) $(srctree)/arch/powerpc/tools/unrel_branch_check.sh
"$(OBJDUMP)" "$@"
else
cmd_relocs_check = \
$(CONFIG_SHELL) $(srctree)/arch/powerpc/tools/relocs_check.sh
"$(OBJDUMP)" "$@"
> --
> Cheers,
> Stephen Rothwell
--
Best Regards
Masahiro Yamada
On Wed, Sep 4, 2019 at 10:00 AM Masahiro Yamada
<[email protected]> wrote:
>
> Hi Stephen,
>
> On Wed, Sep 4, 2019 at 9:13 AM Stephen Rothwell <[email protected]> wrote:
> >
For today's linux-next, please squash the following too.
(This is my fault, since scripts/mkuboot.sh is a bash script)
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 41c50f9461e5..2d72327417a9 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -374,7 +374,7 @@ UIMAGE_ENTRYADDR ?= $(UIMAGE_LOADADDR)
UIMAGE_NAME ?= 'Linux-$(KERNELRELEASE)'
quiet_cmd_uimage = UIMAGE $@
- cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A $(UIMAGE_ARCH) -O linux \
+ cmd_uimage = $(BASE) $(MKIMAGE) -A $(UIMAGE_ARCH) -O linux \
-C $(UIMAGE_COMPRESSION) $(UIMAGE_OPTS-y) \
-T $(UIMAGE_TYPE) \
-a $(UIMAGE_LOADADDR) -e $(UIMAGE_ENTRYADDR) \
--
Best Regards
Masahiro Yamada
Hi Masahiro,
On Wed, 4 Sep 2019 10:00:30 +0900 Masahiro Yamada <[email protected]> wrote:
>
> Could you fix it up as follows?
> I will squash it for tomorrow's linux-next.
>
>
> --- a/arch/powerpc/Makefile.postlink
> +++ b/arch/powerpc/Makefile.postlink
> @@ -18,7 +18,7 @@ quiet_cmd_relocs_check = CHKREL $@
> ifdef CONFIG_PPC_BOOK3S_64
> cmd_relocs_check = \
> $(CONFIG_SHELL) $(srctree)/arch/powerpc/tools/relocs_check.sh
> "$(OBJDUMP)" "$@" ; \
> - $(CONFIG_SHELL)
> $(srctree)/arch/powerpc/tools/unrel_branch_check.sh "$(OBJDUMP)" "$@"
> + $(BASH) $(srctree)/arch/powerpc/tools/unrel_branch_check.sh
> "$(OBJDUMP)" "$@"
> else
> cmd_relocs_check = \
> $(CONFIG_SHELL) $(srctree)/arch/powerpc/tools/relocs_check.sh
> "$(OBJDUMP)" "$@"
I added that in linux-next today.
--
Cheers,
Stephen Rothwell
Hi Masahiro,
On Wed, 4 Sep 2019 15:22:09 +0900 Masahiro Yamada <[email protected]> wrote:
>
> For today's linux-next, please squash the following too.
>
> (This is my fault, since scripts/mkuboot.sh is a bash script)
>
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 41c50f9461e5..2d72327417a9 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -374,7 +374,7 @@ UIMAGE_ENTRYADDR ?= $(UIMAGE_LOADADDR)
> UIMAGE_NAME ?= 'Linux-$(KERNELRELEASE)'
>
> quiet_cmd_uimage = UIMAGE $@
> - cmd_uimage = $(CONFIG_SHELL) $(MKIMAGE) -A $(UIMAGE_ARCH) -O linux \
> + cmd_uimage = $(BASE) $(MKIMAGE) -A $(UIMAGE_ARCH) -O linux \
> -C $(UIMAGE_COMPRESSION) $(UIMAGE_OPTS-y) \
> -T $(UIMAGE_TYPE) \
> -a $(UIMAGE_LOADADDR) -e $(UIMAGE_ENTRYADDR) \
Umm, that seems to have already been done.
--
Cheers,
Stephen Rothwell