2020-04-23 07:43:59

by Masahiro Yamada

Subject: [PATCH 02/16] Revert "objtool: Skip samples subdirectory"

This reverts commit 8728497895794d1f207a836e02dae762ad175d56.

This directory contains no object.

Cc: Josh Poimboeuf <[email protected]>
Signed-off-by: Masahiro Yamada <[email protected]>
---

samples/Makefile | 1 -
1 file changed, 1 deletion(-)

diff --git a/samples/Makefile b/samples/Makefile
index f8f847b4f61f..5ce50ef0f2b2 100644
--- a/samples/Makefile
+++ b/samples/Makefile
@@ -1,6 +1,5 @@
# SPDX-License-Identifier: GPL-2.0
# Makefile for Linux samples code
-OBJECT_FILES_NON_STANDARD := y

obj-$(CONFIG_SAMPLE_ANDROID_BINDERFS) += binderfs/
obj-$(CONFIG_SAMPLE_CONFIGFS) += configfs/
--
2.25.1

2020-04-24 20:37:01

by Josh Poimboeuf

Subject: Re: [PATCH 02/16] Revert "objtool: Skip samples subdirectory"

On Thu, Apr 23, 2020 at 04:39:15PM +0900, Masahiro Yamada wrote:
> This reverts commit 8728497895794d1f207a836e02dae762ad175d56.
>
> This directory contains no object.
>
> Cc: Josh Poimboeuf <[email protected]>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> samples/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/samples/Makefile b/samples/Makefile
> index f8f847b4f61f..5ce50ef0f2b2 100644
> --- a/samples/Makefile
> +++ b/samples/Makefile
> @@ -1,6 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0
> # Makefile for Linux samples code
> -OBJECT_FILES_NON_STANDARD := y
>
> obj-$(CONFIG_SAMPLE_ANDROID_BINDERFS) += binderfs/
> obj-$(CONFIG_SAMPLE_CONFIGFS) += configfs/
> --
> 2.25.1

Hm, somehow I was thinking this would work recursively for
subdirectories. Anyway, you're right:

Acked-by: Josh Poimboeuf <[email protected]>

--
Josh

2020-04-29 02:46:49

by Masahiro Yamada

Subject: Re: [PATCH 02/16] Revert "objtool: Skip samples subdirectory"

On Sat, Apr 25, 2020 at 5:32 AM Josh Poimboeuf <[email protected]> wrote:
>
> On Thu, Apr 23, 2020 at 04:39:15PM +0900, Masahiro Yamada wrote:
> > This reverts commit 8728497895794d1f207a836e02dae762ad175d56.
> >
> > This directory contains no object.
> >
> > Cc: Josh Poimboeuf <[email protected]>
> > Signed-off-by: Masahiro Yamada <[email protected]>
> > ---
> >
> > samples/Makefile | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/samples/Makefile b/samples/Makefile
> > index f8f847b4f61f..5ce50ef0f2b2 100644
> > --- a/samples/Makefile
> > +++ b/samples/Makefile
> > @@ -1,6 +1,5 @@
> > # SPDX-License-Identifier: GPL-2.0
> > # Makefile for Linux samples code
> > -OBJECT_FILES_NON_STANDARD := y
> >
> > obj-$(CONFIG_SAMPLE_ANDROID_BINDERFS) += binderfs/
> > obj-$(CONFIG_SAMPLE_CONFIGFS) += configfs/
> > --
> > 2.25.1
>
> Hm, somehow I was thinking this would work recursively for
> subdirectories. Anyway, you're right:
>
> Acked-by: Josh Poimboeuf <[email protected]>
>
> --
> Josh
>

Applied to linux-kbuild.


--
Best Regards
Masahiro Yamada