2024-02-15 14:12:47

by Masahiro Yamada

Subject: [PATCH] hexagon: select GENERIC_IRQ_PROBE instead of redefining it

Select GENERIC_IRQ_PROBE, as the other architectures do.

Signed-off-by: Masahiro Yamada <[email protected]>
---

arch/hexagon/Kconfig | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
index e922026fef09..a8dd2501f39f 100644
--- a/arch/hexagon/Kconfig
+++ b/arch/hexagon/Kconfig
@@ -21,6 +21,7 @@ config HEXAGON
select HAVE_PERF_EVENTS
# GENERIC_ALLOCATOR is used by dma_alloc_coherent()
select GENERIC_ALLOCATOR
+ select GENERIC_IRQ_PROBE
select GENERIC_IRQ_SHOW
select HAVE_ARCH_KGDB
select HAVE_ARCH_TRACEHOOK
@@ -60,9 +61,6 @@ config GENERIC_CSUM
#
# Use the generic interrupt handling code in kernel/irq/:
#
-config GENERIC_IRQ_PROBE
- def_bool y
-
config GENERIC_HWEIGHT
def_bool y

--
2.40.1

2024-02-15 19:20:28

by Brian Cain

Subject: RE: [PATCH] hexagon: select GENERIC_IRQ_PROBE instead of redefining it

> -----Original Message-----
> From: Masahiro Yamada <[email protected]>
> Sent: Thursday, February 15, 2024 8:08 AM
> To: [email protected]
> Cc: Masahiro Yamada <[email protected]>; Brian Cain
> <[email protected]>; [email protected]; linux-
> [email protected]
> Subject: [PATCH] hexagon: select GENERIC_IRQ_PROBE instead of redefining it
>
> WARNING: This email originated from outside of Qualcomm. Please be wary of
> any links or attachments, and do not enable macros.
>
> Select GENERIC_IRQ_PROBE, as the other architectures do.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> arch/hexagon/Kconfig | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
> index e922026fef09..a8dd2501f39f 100644
> --- a/arch/hexagon/Kconfig
> +++ b/arch/hexagon/Kconfig
> @@ -21,6 +21,7 @@ config HEXAGON
> select HAVE_PERF_EVENTS
> # GENERIC_ALLOCATOR is used by dma_alloc_coherent()
> select GENERIC_ALLOCATOR
> + select GENERIC_IRQ_PROBE
> select GENERIC_IRQ_SHOW
> select HAVE_ARCH_KGDB
> select HAVE_ARCH_TRACEHOOK
> @@ -60,9 +61,6 @@ config GENERIC_CSUM
> #
> # Use the generic interrupt handling code in kernel/irq/:
> #
> -config GENERIC_IRQ_PROBE
> - def_bool y
> -
> config GENERIC_HWEIGHT
> def_bool y
>
> --
> 2.40.1

Acked-by: Brian Cain <[email protected]>

2024-02-15 20:10:05

by Randy Dunlap

Subject: Re: [PATCH] hexagon: select GENERIC_IRQ_PROBE instead of redefining it

On 2/15/24 06:08, Masahiro Yamada wrote:
> Select GENERIC_IRQ_PROBE, as the other architectures do.
>
> Signed-off-by: Masahiro Yamada <[email protected]>

Reviewed-by: Randy Dunlap <[email protected]>


Thanks.

> ---
>
> arch/hexagon/Kconfig | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
> index e922026fef09..a8dd2501f39f 100644
> --- a/arch/hexagon/Kconfig
> +++ b/arch/hexagon/Kconfig
> @@ -21,6 +21,7 @@ config HEXAGON
> select HAVE_PERF_EVENTS
> # GENERIC_ALLOCATOR is used by dma_alloc_coherent()
> select GENERIC_ALLOCATOR
> + select GENERIC_IRQ_PROBE
> select GENERIC_IRQ_SHOW
> select HAVE_ARCH_KGDB
> select HAVE_ARCH_TRACEHOOK
> @@ -60,9 +61,6 @@ config GENERIC_CSUM
> #
> # Use the generic interrupt handling code in kernel/irq/:
> #
> -config GENERIC_IRQ_PROBE
> - def_bool y
> -
> config GENERIC_HWEIGHT
> def_bool y
>

--
#Randy

2024-02-16 02:04:02

by Masahiro Yamada

Subject: Re: [PATCH] hexagon: select GENERIC_IRQ_PROBE instead of redefining it

On Fri, Feb 16, 2024 at 4:12 AM Brian Cain <[email protected]> wrote:
>
>
>
> > -----Original Message-----
> > From: Masahiro Yamada <[email protected]>
> > Sent: Thursday, February 15, 2024 8:08 AM
> > To: [email protected]
> > Cc: Masahiro Yamada <[email protected]>; Brian Cain
> > <[email protected]>; [email protected]; linux-
> > [email protected]
> > Subject: [PATCH] hexagon: select GENERIC_IRQ_PROBE instead of redefining it
> >
> > WARNING: This email originated from outside of Qualcomm. Please be wary of
> > any links or attachments, and do not enable macros.
> >
> > Select GENERIC_IRQ_PROBE, as the other architectures do.
> >
> > Signed-off-by: Masahiro Yamada <[email protected]>
> > ---
> >
> > arch/hexagon/Kconfig | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/arch/hexagon/Kconfig b/arch/hexagon/Kconfig
> > index e922026fef09..a8dd2501f39f 100644
> > --- a/arch/hexagon/Kconfig
> > +++ b/arch/hexagon/Kconfig
> > @@ -21,6 +21,7 @@ config HEXAGON
> > select HAVE_PERF_EVENTS
> > # GENERIC_ALLOCATOR is used by dma_alloc_coherent()
> > select GENERIC_ALLOCATOR
> > + select GENERIC_IRQ_PROBE
> > select GENERIC_IRQ_SHOW
> > select HAVE_ARCH_KGDB
> > select HAVE_ARCH_TRACEHOOK
> > @@ -60,9 +61,6 @@ config GENERIC_CSUM
> > #
> > # Use the generic interrupt handling code in kernel/irq/:
> > #
> > -config GENERIC_IRQ_PROBE
> > - def_bool y
> > -
> > config GENERIC_HWEIGHT
> > def_bool y
> >
> > --
> > 2.40.1
>
> Acked-by: Brian Cain <[email protected]>
>



Thanks for the ack.




I will also delete the comment lines above:

#
# Use the generic interrupt handling code in kernel/irq/:
#





BTW, the reason why I submitted this to linux-kbuild ML
is I did not see any hexagon pull requests
in the past few years.

(I am doing the same for sparc, alpha as well)





--
Best Regards
Masahiro Yamada