2022-06-22 13:25:09

by Tomer Maimon

Subject: [PATCH v5 02/18] clocksource: timer-npcm7xx: Add NPCM845 timer support

Add Nuvoton BMC NPCM845 timer support, The NPCM845 uses the same timer
controller as the NPCM750.

Signed-off-by: Tomer Maimon <[email protected]>
---
drivers/clocksource/timer-npcm7xx.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/clocksource/timer-npcm7xx.c b/drivers/clocksource/timer-npcm7xx.c
index a00520cbb660..1630daad4df5 100644
--- a/drivers/clocksource/timer-npcm7xx.c
+++ b/drivers/clocksource/timer-npcm7xx.c
@@ -210,4 +210,5 @@ static int __init npcm7xx_timer_init(struct device_node *np)

TIMER_OF_DECLARE(wpcm450, "nuvoton,wpcm450-timer", npcm7xx_timer_init);
TIMER_OF_DECLARE(npcm7xx, "nuvoton,npcm750-timer", npcm7xx_timer_init);
+TIMER_OF_DECLARE(npcm8xx, "nuvoton,npcm845-timer", npcm7xx_timer_init);

--
2.33.0

2022-06-23 15:16:18

by Arnd Bergmann

Subject: Re: [PATCH v5 02/18] clocksource: timer-npcm7xx: Add NPCM845 timer support

On Wed, Jun 22, 2022 at 3:22 PM Tomer Maimon <[email protected]> wrote:
>
> Add Nuvoton BMC NPCM845 timer support, The NPCM845 uses the same timer
> controller as the NPCM750.
>
> Signed-off-by: Tomer Maimon <[email protected]>

I think I've commented on this before: if the timer is the same, you should not
need any changes to the timer driver, just mark the device node as compatible
with the older model (as well as its own string) in its "compatible"
property and
drop this patch.

Arnd