2013-10-10 00:30:35

by Chanwoo Choi

[permalink] [raw]
Subject: [PATCH 0/3] ARM: dts: exynos: Add missing dt data to bring up kernel feature

This patchset add missing dt data to bring up kernel feature
- MAUDIO/GPS_ALIVE power domain
- PMU
- Clock data for Multi core timer

Chanwoo Choi (2):
ARM: dts: exynos4212: Add PMU dt data for pmu-irq
ARM: dts: exynos4x12: Add maudio/gps_alive power domain for exynos4x12

Marek Szyprowski (1):
ARM: dts: exynos4212: Add missing clock for multi core timer

arch/arm/boot/dts/exynos4212.dtsi | 8 ++++++++
arch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++++
2 files changed, 18 insertions(+)

--
1.8.0


2013-10-10 00:30:11

by Chanwoo Choi

[permalink] [raw]
Subject: [PATCH 1/3] ARM: dts: exynos4212: Add PMU dt data for pmu-irq

Signed-off-by: Chanwoo Choi <[email protected]>
Signed-off-by: Kyungmin Park <[email protected]>
---
arch/arm/boot/dts/exynos4212.dtsi | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi
index 6f34d7f..3081bae 100644
--- a/arch/arm/boot/dts/exynos4212.dtsi
+++ b/arch/arm/boot/dts/exynos4212.dtsi
@@ -56,4 +56,10 @@
<0x5 0 &gic 1 12 0>;
};
};
+
+ pmu {
+ compatible = "arm,cortex-a9-pmu";
+ interrupt-parent = <&combiner>;
+ interrupts = <2 2>, <3 2>;
+ };
};
--
1.8.0

2013-10-10 00:30:33

by Chanwoo Choi

[permalink] [raw]
Subject: [PATCH 3/3] ARM: dts: exynos4x12: Add maudio/gps_alive power domain for exynos4x12

This patch maudio/gps_alive power domain to exynos4x12.dtsi.

Signed-off-by: Chanwoo Choi <[email protected]>
Signed-off-by: Kyungmin Park <[email protected]>
---
arch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
index ad531fe..c04418e 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -35,6 +35,16 @@
reg = <0x10023CA0 0x20>;
};

+ pd_maudio: maudio-power-domain@10023CC0 {
+ compatible = "samsung,exynos4210-pd";
+ reg = <0x10023CC0 0x20>;
+ };
+
+ pd_gps_alive: gps-alive-power-domain@10023D04 {
+ compatible = "samsung,exynos4210-pd";
+ reg = <0x10023D00 0x20>;
+ };
+
clock: clock-controller@10030000 {
compatible = "samsung,exynos4412-clock";
reg = <0x10030000 0x20000>;
--
1.8.0

2013-10-10 00:30:30

by Chanwoo Choi

[permalink] [raw]
Subject: [PATCH 2/3] ARM: dts: exynos4212: Add missing clock for multi core timer

From: Marek Szyprowski <[email protected]>

Signed-off-by: Marek Szyprowski <[email protected]>
Signed-off-by: Kyungmin Park <[email protected]>
---
arch/arm/boot/dts/exynos4212.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi
index 3081bae..d7a3fbc 100644
--- a/arch/arm/boot/dts/exynos4212.dtsi
+++ b/arch/arm/boot/dts/exynos4212.dtsi
@@ -43,6 +43,8 @@
interrupt-parent = <&mct_map>;
interrupts = <0 0>, <1 0>, <2 0>, <3 0>,
<4 0>, <5 0>;
+ clocks = <&clock 3>, <&clock 344>;
+ clock-names = "fin_pll", "mct";

mct_map: mct-map {
#interrupt-cells = <2>;
--
1.8.0

2013-10-10 03:29:28

by Sachin Kamat

[permalink] [raw]
Subject: Re: [PATCH 3/3] ARM: dts: exynos4x12: Add maudio/gps_alive power domain for exynos4x12

On 10 October 2013 06:00, Chanwoo Choi <[email protected]> wrote:
> This patch maudio/gps_alive power domain to exynos4x12.dtsi.
>
> Signed-off-by: Chanwoo Choi <[email protected]>
> Signed-off-by: Kyungmin Park <[email protected]>
> ---
> arch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
> index ad531fe..c04418e 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -35,6 +35,16 @@
> reg = <0x10023CA0 0x20>;
> };
>
> + pd_maudio: maudio-power-domain@10023CC0 {
> + compatible = "samsung,exynos4210-pd";
> + reg = <0x10023CC0 0x20>;
> + };
> +
> + pd_gps_alive: gps-alive-power-domain@10023D04 {
> + compatible = "samsung,exynos4210-pd";
> + reg = <0x10023D00 0x20>;

There is mismatch between node name and register value.


--
With warm regards,
Sachin

2013-10-10 04:05:54

by Chanwoo Choi

[permalink] [raw]
Subject: Re: [PATCH 3/3] ARM: dts: exynos4x12: Add maudio/gps_alive power domain for exynos4x12

On 10/10/2013 12:29 PM, Sachin Kamat wrote:
> On 10 October 2013 06:00, Chanwoo Choi <[email protected]> wrote:
>> This patch maudio/gps_alive power domain to exynos4x12.dtsi.
>>
>> Signed-off-by: Chanwoo Choi <[email protected]>
>> Signed-off-by: Kyungmin Park <[email protected]>
>> ---
>> arch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
>> index ad531fe..c04418e 100644
>> --- a/arch/arm/boot/dts/exynos4x12.dtsi
>> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
>> @@ -35,6 +35,16 @@
>> reg = <0x10023CA0 0x20>;
>> };
>>
>> + pd_maudio: maudio-power-domain@10023CC0 {
>> + compatible = "samsung,exynos4210-pd";
>> + reg = <0x10023CC0 0x20>;
>> + };
>> +
>> + pd_gps_alive: gps-alive-power-domain@10023D04 {
>> + compatible = "samsung,exynos4210-pd";
>> + reg = <0x10023D00 0x20>;
>
> There is mismatch between node name and register value.
>
>
What is exactly mismatch?

I checked the register address of MAUDIO_CONFIGURATION/GPS_ALIVE_CONFIGURATION regsiter.
- MAUDIO_CONFIGURATION 0x1002_3CC0
- GPS_ALIVE_CONFIGURATION 0x1002_3D00

2013-10-10 04:07:55

by Chanwoo Choi

[permalink] [raw]
Subject: Re: [PATCH 3/3] ARM: dts: exynos4x12: Add maudio/gps_alive power domain for exynos4x12

On 10/10/2013 01:05 PM, Chanwoo Choi wrote:
> On 10/10/2013 12:29 PM, Sachin Kamat wrote:
>> On 10 October 2013 06:00, Chanwoo Choi <[email protected]> wrote:
>>> This patch maudio/gps_alive power domain to exynos4x12.dtsi.
>>>
>>> Signed-off-by: Chanwoo Choi <[email protected]>
>>> Signed-off-by: Kyungmin Park <[email protected]>
>>> ---
>>> arch/arm/boot/dts/exynos4x12.dtsi | 10 ++++++++++
>>> 1 file changed, 10 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi
>>> index ad531fe..c04418e 100644
>>> --- a/arch/arm/boot/dts/exynos4x12.dtsi
>>> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
>>> @@ -35,6 +35,16 @@
>>> reg = <0x10023CA0 0x20>;
>>> };
>>>
>>> + pd_maudio: maudio-power-domain@10023CC0 {
>>> + compatible = "samsung,exynos4210-pd";
>>> + reg = <0x10023CC0 0x20>;
>>> + };
>>> +
>>> + pd_gps_alive: gps-alive-power-domain@10023D04 {
>>> + compatible = "samsung,exynos4210-pd";
>>> + reg = <0x10023D00 0x20>;
>>
>> There is mismatch between node name and register value.
>>
>>
> What is exactly mismatch?
>
> I checked the register address of MAUDIO_CONFIGURATION/GPS_ALIVE_CONFIGURATION regsiter.
> - MAUDIO_CONFIGURATION 0x1002_3CC0
> - GPS_ALIVE_CONFIGURATION 0x1002_3D00

My mistake. I write wrong address about gps-alive-power-domain.

I will fix it.
- gps-alive-power-domain@10023D04 -> gps-alive-power-domain@10023D00

Thanks,
Chanwoo Choi