2012-11-20 11:10:51

by Sachin Kamat

Subject: [PATCH 1/1] pinctrl: pinctrl-single: Fix error check condition

*map should be tested for NULL instead of map.

Signed-off-by: Sachin Kamat <[email protected]>
---
drivers/pinctrl/pinctrl-single.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c
index 726a729..3fc2a22 100644
--- a/drivers/pinctrl/pinctrl-single.c
+++ b/drivers/pinctrl/pinctrl-single.c
@@ -772,7 +772,7 @@ static int pcs_dt_node_to_map(struct pinctrl_dev *pctldev,
pcs = pinctrl_dev_get_drvdata(pctldev);

*map = devm_kzalloc(pcs->dev, sizeof(**map), GFP_KERNEL);
- if (!map)
+ if (!*map)
return -ENOMEM;

*num_maps = 0;
--
1.7.4.1

2012-11-23 07:44:14

by Linus Walleij

Subject: Re: [PATCH 1/1] pinctrl: pinctrl-single: Fix error check condition

On Tue, Nov 20, 2012 at 12:04 PM, Sachin Kamat <[email protected]> wrote:

> *map should be tested for NULL instead of map.
>
> Signed-off-by: Sachin Kamat <[email protected]>

Thanks, patch applied.

As we are late in the kernel cycle and I haven't seen reports about
regressions on this, it will wait for kernel v3.8.

Yours,
Linus Walleij

2012-11-23 08:06:13

by Sachin Kamat

Subject: Re: [PATCH 1/1] pinctrl: pinctrl-single: Fix error check condition

On 23 November 2012 13:14, Linus Walleij <[email protected]> wrote:
> On Tue, Nov 20, 2012 at 12:04 PM, Sachin Kamat <[email protected]> wrote:
>
>> *map should be tested for NULL instead of map.
>>
>> Signed-off-by: Sachin Kamat <[email protected]>
>
> Thanks, patch applied.
>
Thanks

> As we are late in the kernel cycle and I haven't seen reports about
> regressions on this, it will wait for kernel v3.8.

OK.

>
> Yours,
> Linus Walleij



--
With warm regards,
Sachin