2014-02-26 02:28:46

by Pankaj Dubey

Subject: [PATCH] clk: samsung: remove parentheses from return statements

fixed following checkpatch warning message
"return is not a function, parentheses are not required"

Signed-off-by: Pankaj Dubey <[email protected]>
---
drivers/clk/samsung/clk-pll.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/clk/samsung/clk-pll.c b/drivers/clk/samsung/clk-pll.c
index 7fb0a28..32b483f 100644
--- a/drivers/clk/samsung/clk-pll.c
+++ b/drivers/clk/samsung/clk-pll.c
@@ -166,7 +166,7 @@ static inline bool samsung_pll35xx_mp_change(
old_mdiv = (pll_con >> PLL35XX_MDIV_SHIFT) & PLL35XX_MDIV_MASK;
old_pdiv = (pll_con >> PLL35XX_PDIV_SHIFT) & PLL35XX_PDIV_MASK;

- return (rate->mdiv != old_mdiv || rate->pdiv != old_pdiv);
+ return rate->mdiv != old_mdiv || rate->pdiv != old_pdiv;
}

static int samsung_pll35xx_set_rate(struct clk_hw *hw, unsigned long drate,
@@ -274,8 +274,8 @@ static inline bool samsung_pll36xx_mpk_change(
old_pdiv = (pll_con0 >> PLL36XX_PDIV_SHIFT) & PLL36XX_PDIV_MASK;
old_kdiv = (pll_con1 >> PLL36XX_KDIV_SHIFT) & PLL36XX_KDIV_MASK;

- return (rate->mdiv != old_mdiv || rate->pdiv != old_pdiv ||
- rate->kdiv != old_kdiv);
+ return rate->mdiv != old_mdiv || rate->pdiv != old_pdiv ||
+ rate->kdiv != old_kdiv;
}

static int samsung_pll36xx_set_rate(struct clk_hw *hw, unsigned long drate,
@@ -387,8 +387,8 @@ static bool samsung_pll45xx_mp_change(u32 pll_con0, u32 pll_con1,
old_pdiv = (pll_con0 >> PLL45XX_PDIV_SHIFT) & PLL45XX_PDIV_MASK;
old_afc = (pll_con1 >> PLL45XX_AFC_SHIFT) & PLL45XX_AFC_MASK;

- return (old_mdiv != rate->mdiv || old_pdiv != rate->pdiv
- || old_afc != rate->afc);
+ return old_mdiv != rate->mdiv || old_pdiv != rate->pdiv
+ || old_afc != rate->afc;
}

static int samsung_pll45xx_set_rate(struct clk_hw *hw, unsigned long drate,
@@ -534,8 +534,8 @@ static bool samsung_pll46xx_mpk_change(u32 pll_con0, u32 pll_con1,
old_pdiv = (pll_con0 >> PLL46XX_PDIV_SHIFT) & PLL46XX_PDIV_MASK;
old_kdiv = (pll_con1 >> PLL46XX_KDIV_SHIFT) & PLL46XX_KDIV_MASK;

- return (old_mdiv != rate->mdiv || old_pdiv != rate->pdiv
- || old_kdiv != rate->kdiv);
+ return old_mdiv != rate->mdiv || old_pdiv != rate->pdiv
+ || old_kdiv != rate->kdiv;
}

static int samsung_pll46xx_set_rate(struct clk_hw *hw, unsigned long drate,
--
1.7.9.5

2014-02-26 04:12:40

by Sachin Kamat

Subject: Re: [PATCH] clk: samsung: remove parentheses from return statements

Hi Pankaj,

On 26 February 2014 08:14, Pankaj Dubey <[email protected]> wrote:
> fixed following checkpatch warning message
> "return is not a function, parentheses are not required"
>
> Signed-off-by: Pankaj Dubey <[email protected]>

Similar patch has already been submitted:
http://comments.gmane.org/gmane.linux.ports.arm.kernel/294530


--
With warm regards,
Sachin

2014-02-26 04:59:36

by Pankaj Dubey

Subject: Re: [PATCH] clk: samsung: remove parentheses from return statements

Hi Sachin,

On 02/26/2014 01:12 PM, Sachin Kamat wrote:
> Hi Pankaj,
>
> On 26 February 2014 08:14, Pankaj Dubey <[email protected]> wrote:
>> fixed following checkpatch warning message
>> "return is not a function, parentheses are not required"
>>
>> Signed-off-by: Pankaj Dubey <[email protected]>
> Similar patch has already been submitted:
> http://comments.gmane.org/gmane.linux.ports.arm.kernel/294530
>
>
Sorry I missed that.
Since same change already submitted we can ignore my patch.

--
Best Regards,
Pankaj Dubey