2020-09-19 09:48:31

by Liu Shixin

Subject: [PATCH -next] drm/lima: simplify the return expression of lima_devfreq_target

Simplify the return expression.

Signed-off-by: Liu Shixin <[email protected]>
---
drivers/gpu/drm/lima/lima_devfreq.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/lima/lima_devfreq.c b/drivers/gpu/drm/lima/lima_devfreq.c
index bbe02817721b..5914442936ed 100644
--- a/drivers/gpu/drm/lima/lima_devfreq.c
+++ b/drivers/gpu/drm/lima/lima_devfreq.c
@@ -35,18 +35,13 @@ static int lima_devfreq_target(struct device *dev, unsigned long *freq,
u32 flags)
{
struct dev_pm_opp *opp;
- int err;

opp = devfreq_recommended_opp(dev, freq, flags);
if (IS_ERR(opp))
return PTR_ERR(opp);
dev_pm_opp_put(opp);

- err = dev_pm_opp_set_rate(dev, *freq);
- if (err)
- return err;
-
- return 0;
+ return dev_pm_opp_set_rate(dev, *freq);
}

static void lima_devfreq_reset(struct lima_devfreq *devfreq)
--
2.25.1

2020-09-19 10:48:23

by Qiang Yu

Subject: Re: [PATCH -next] drm/lima: simplify the return expression of lima_devfreq_target

Looks good for me, patch is:
Reviewed-by: Qiang Yu <[email protected]>

Regards,
Qiang

On Sat, Sep 19, 2020 at 5:47 PM Liu Shixin <[email protected]> wrote:
>
> Simplify the return expression.
>
> Signed-off-by: Liu Shixin <[email protected]>
> ---
> drivers/gpu/drm/lima/lima_devfreq.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/lima/lima_devfreq.c b/drivers/gpu/drm/lima/lima_devfreq.c
> index bbe02817721b..5914442936ed 100644
> --- a/drivers/gpu/drm/lima/lima_devfreq.c
> +++ b/drivers/gpu/drm/lima/lima_devfreq.c
> @@ -35,18 +35,13 @@ static int lima_devfreq_target(struct device *dev, unsigned long *freq,
> u32 flags)
> {
> struct dev_pm_opp *opp;
> - int err;
>
> opp = devfreq_recommended_opp(dev, freq, flags);
> if (IS_ERR(opp))
> return PTR_ERR(opp);
> dev_pm_opp_put(opp);
>
> - err = dev_pm_opp_set_rate(dev, *freq);
> - if (err)
> - return err;
> -
> - return 0;
> + return dev_pm_opp_set_rate(dev, *freq);
> }
>
> static void lima_devfreq_reset(struct lima_devfreq *devfreq)
> --
> 2.25.1
>

2020-11-16 02:55:12

by Qiang Yu

Subject: Re: [PATCH -next] drm/lima: simplify the return expression of lima_devfreq_target

Applied to drm-misc-next.

On Sat, Sep 19, 2020 at 6:43 PM Qiang Yu <[email protected]> wrote:
>
> Looks good for me, patch is:
> Reviewed-by: Qiang Yu <[email protected]>
>
> Regards,
> Qiang
>
> On Sat, Sep 19, 2020 at 5:47 PM Liu Shixin <[email protected]> wrote:
> >
> > Simplify the return expression.
> >
> > Signed-off-by: Liu Shixin <[email protected]>
> > ---
> > drivers/gpu/drm/lima/lima_devfreq.c | 7 +------
> > 1 file changed, 1 insertion(+), 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/lima/lima_devfreq.c b/drivers/gpu/drm/lima/lima_devfreq.c
> > index bbe02817721b..5914442936ed 100644
> > --- a/drivers/gpu/drm/lima/lima_devfreq.c
> > +++ b/drivers/gpu/drm/lima/lima_devfreq.c
> > @@ -35,18 +35,13 @@ static int lima_devfreq_target(struct device *dev, unsigned long *freq,
> > u32 flags)
> > {
> > struct dev_pm_opp *opp;
> > - int err;
> >
> > opp = devfreq_recommended_opp(dev, freq, flags);
> > if (IS_ERR(opp))
> > return PTR_ERR(opp);
> > dev_pm_opp_put(opp);
> >
> > - err = dev_pm_opp_set_rate(dev, *freq);
> > - if (err)
> > - return err;
> > -
> > - return 0;
> > + return dev_pm_opp_set_rate(dev, *freq);
> > }
> >
> > static void lima_devfreq_reset(struct lima_devfreq *devfreq)
> > --
> > 2.25.1
> >