2024-01-03 17:15:45

by Greg KH

[permalink] [raw]
Subject: [PATCH 6.6 00/49] 6.6.10-rc1 review

This is the start of the stable review cycle for the 6.6.10 release.
There are 49 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.

Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.10-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>
Linux 6.6.10-rc1

Pablo Neira Ayuso <[email protected]>
netfilter: nf_tables: skip set commit for deleted/destroyed sets

Léo Lam <[email protected]>
wifi: nl80211: fix deadlock in nl80211_set_cqm_rssi (6.6.x)

Johannes Berg <[email protected]>
wifi: cfg80211: fix CQM for non-range use

Steven Rostedt (Google) <[email protected]>
tracing: Fix blocked reader of snapshot buffer

Steven Rostedt (Google) <[email protected]>
ftrace: Fix modification of direct_function hash while in use

Steven Rostedt (Google) <[email protected]>
ring-buffer: Fix wake ups when buffer_percent is set to 100

Keith Busch <[email protected]>
Revert "nvme-fc: fix race between error recovery and creating association"

Matthew Wilcox (Oracle) <[email protected]>
mm/memory-failure: check the mapcount of the precise page

Matthew Wilcox (Oracle) <[email protected]>
mm/memory-failure: cast index to loff_t before shifting it

Charan Teja Kalla <[email protected]>
mm: migrate high-order folios in swap cache correctly

Baokun Li <[email protected]>
mm/filemap: avoid buffered read/write race to read inconsistent data

Muhammad Usama Anjum <[email protected]>
selftests: secretmem: floor the memory size to the multiple of page_size

Sidhartha Kumar <[email protected]>
maple_tree: do not preallocate nodes for slot stores

Shin'ichiro Kawasaki <[email protected]>
platform/x86: p2sb: Allow p2sb_bar() calls during PCI device probe

Namjae Jeon <[email protected]>
ksmbd: fix slab-out-of-bounds in smb_strndup_from_utf16()

David E. Box <[email protected]>
platform/x86/intel/pmc: Move GBE LTR ignore to suspend callback

David E. Box <[email protected]>
platform/x86/intel/pmc: Allow reenabling LTRs

David E. Box <[email protected]>
platform/x86/intel/pmc: Add suspend callback

Christoph Hellwig <[email protected]>
block: renumber QUEUE_FLAG_HW_WC

Paolo Abeni <[email protected]>
mptcp: fix inconsistent state on fastopen race

Paolo Abeni <[email protected]>
mptcp: fix possible NULL pointer dereference on close

Paolo Abeni <[email protected]>
mptcp: refactor sndbuf auto-tuning

Helge Deller <[email protected]>
linux/export: Ensure natural alignment of kcrctab array

Helge Deller <[email protected]>
linux/export: Fix alignment for 64-bit ksymtab entries

Arnd Bergmann <[email protected]>
kexec: select CRYPTO from KEXEC_FILE instead of depending on it

Arnd Bergmann <[email protected]>
kexec: fix KEXEC_FILE dependencies

Xuan Zhuo <[email protected]>
virtio_ring: fix syncs DMA memory with different direction

Zizhi Wo <[email protected]>
fs: cifs: Fix atime update check

Jeff Layton <[email protected]>
client: convert to new timestamp accessors

Jeff Layton <[email protected]>
fs: new accessor methods for atime and mtime

Namjae Jeon <[email protected]>
ksmbd: avoid duplicate opinfo_put() call on error of smb21_lease_break_ack()

Namjae Jeon <[email protected]>
ksmbd: lazy v2 lease break on smb2_write()

Namjae Jeon <[email protected]>
ksmbd: send v2 lease break notification for directory

Namjae Jeon <[email protected]>
ksmbd: downgrade RWH lease caching state to RH for directory

Namjae Jeon <[email protected]>
ksmbd: set v2 lease capability

Namjae Jeon <[email protected]>
ksmbd: set epoch in create context v2 lease

Namjae Jeon <[email protected]>
ksmbd: don't update ->op_state as OPLOCK_STATE_NONE on error

Namjae Jeon <[email protected]>
ksmbd: move setting SMB2_FLAGS_ASYNC_COMMAND and AsyncId

Namjae Jeon <[email protected]>
ksmbd: release interim response after sending status pending response

Namjae Jeon <[email protected]>
ksmbd: move oplock handling after unlock parent dir

Namjae Jeon <[email protected]>
ksmbd: separately allocate ci per dentry

Zongmin Zhou <[email protected]>
ksmbd: prevent memory leak on error return

Namjae Jeon <[email protected]>
ksmbd: fix kernel-doc comment of ksmbd_vfs_kern_path_locked()

Namjae Jeon <[email protected]>
ksmbd: no need to wait for binded connection termination at logoff

Namjae Jeon <[email protected]>
ksmbd: add support for surrogate pair conversion

Kangjing Huang <[email protected]>
ksmbd: fix missing RDMA-capable flag for IPoIB device in ksmbd_rdma_capable_netdev()

Namjae Jeon <[email protected]>
ksmbd: fix kernel-doc comment of ksmbd_vfs_setxattr()

Namjae Jeon <[email protected]>
ksmbd: reorganize ksmbd_iov_pin_rsp()

Cheng-Han Wu <[email protected]>
ksmbd: Remove unused field in ksmbd_user struct


-------------

Diffstat:

Makefile | 4 +-
arch/powerpc/Kconfig | 4 +-
arch/riscv/Kconfig | 4 +-
arch/s390/Kconfig | 4 +-
arch/x86/Kconfig | 4 +-
drivers/nvme/host/fc.c | 21 +--
drivers/platform/x86/intel/pmc/adl.c | 9 +-
drivers/platform/x86/intel/pmc/cnp.c | 26 ++-
drivers/platform/x86/intel/pmc/core.c | 12 +-
drivers/platform/x86/intel/pmc/core.h | 7 +-
drivers/platform/x86/intel/pmc/mtl.c | 9 +-
drivers/platform/x86/intel/pmc/tgl.c | 9 +-
drivers/platform/x86/p2sb.c | 178 ++++++++++++++++-----
drivers/virtio/virtio_ring.c | 6 +-
fs/libfs.c | 41 +++--
fs/smb/client/file.c | 18 ++-
fs/smb/client/fscache.h | 6 +-
fs/smb/client/inode.c | 17 +-
fs/smb/client/smb2ops.c | 6 +-
fs/smb/common/smb2pdu.h | 1 +
fs/smb/server/connection.c | 16 --
fs/smb/server/ksmbd_work.c | 51 +++---
fs/smb/server/mgmt/user_config.h | 1 -
fs/smb/server/oplock.c | 118 ++++++++++++--
fs/smb/server/oplock.h | 8 +-
fs/smb/server/smb2misc.c | 15 +-
fs/smb/server/smb2ops.c | 9 +-
fs/smb/server/smb2pdu.c | 258 ++++++++++++++++--------------
fs/smb/server/transport_rdma.c | 40 +++--
fs/smb/server/unicode.c | 187 ++++++++++++++++------
fs/smb/server/vfs.c | 14 +-
fs/smb/server/vfs_cache.c | 30 ++--
fs/smb/server/vfs_cache.h | 9 +-
include/linux/blkdev.h | 2 +-
include/linux/export-internal.h | 6 +-
include/linux/fs.h | 85 ++++++++--
kernel/Kconfig.kexec | 2 +
kernel/trace/ftrace.c | 100 ++++++------
kernel/trace/ring_buffer.c | 12 +-
kernel/trace/trace.c | 20 ++-
lib/maple_tree.c | 11 ++
mm/filemap.c | 9 ++
mm/memory-failure.c | 8 +-
mm/migrate.c | 9 +-
net/mptcp/protocol.c | 27 +++-
net/mptcp/protocol.h | 63 +++++++-
net/mptcp/sockopt.c | 5 +-
net/mptcp/subflow.c | 29 ++--
net/netfilter/nf_tables_api.c | 2 +-
net/wireless/core.h | 1 +
net/wireless/nl80211.c | 56 ++++---
tools/testing/radix-tree/maple.c | 2 +-
tools/testing/selftests/mm/memfd_secret.c | 3 +
53 files changed, 1070 insertions(+), 524 deletions(-)




2024-01-03 17:45:17

by Nam Cao

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

On Wed, 3 Jan 2024 17:55:20 +0100 Greg Kroah-Hartman <[email protected]> wrote:
> This is the start of the stable review cycle for the 6.6.10 release.
> There are 49 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.10-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Works for my Visionfive2 board (riscv64):

Tested-by: Nam Cao <[email protected]>

Best regards,
Nam

2024-01-03 18:08:42

by Ronald Warsow

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

Hi Greg

no regressions here on x86_64
(Intel Rocket Lake: i5-11400)

Thanks

Tested-by: Ronald Warsow <[email protected]>


2024-01-03 18:57:17

by SeongJae Park

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

Hello,

On Wed, 3 Jan 2024 17:55:20 +0100 Greg Kroah-Hartman <[email protected]> wrote:

> This is the start of the stable review cycle for the 6.6.10 release.
> There are 49 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.10-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y
> and the diffstat can be found below.

This rc kernel passes DAMON functionality test[1] on my test machine.
Attaching the test results summary below. Please note that I retrieved the
kernel from linux-stable-rc tree[2].

Tested-by: SeongJae Park <[email protected]>

[1] https://github.com/awslabs/damon-tests/tree/next/corr
[2] 5fd1c89851c4 ("Linux 6.6.10-rc1")

Thanks,
SJ

[...]

---

ok 1 selftests: damon: debugfs_attrs.sh
ok 2 selftests: damon: debugfs_schemes.sh
ok 3 selftests: damon: debugfs_target_ids.sh
ok 4 selftests: damon: debugfs_empty_targets.sh
ok 5 selftests: damon: debugfs_huge_count_read_write.sh
ok 6 selftests: damon: debugfs_duplicate_context_creation.sh
ok 7 selftests: damon: debugfs_rm_non_contexts.sh
ok 8 selftests: damon: sysfs.sh
ok 9 selftests: damon: sysfs_update_removed_scheme_dir.sh
ok 10 selftests: damon: reclaim.sh
ok 11 selftests: damon: lru_sort.sh
ok 1 selftests: damon-tests: kunit.sh
ok 2 selftests: damon-tests: huge_count_read_write.sh
ok 3 selftests: damon-tests: buffer_overflow.sh
ok 4 selftests: damon-tests: rm_contexts.sh
ok 5 selftests: damon-tests: record_null_deref.sh
ok 6 selftests: damon-tests: dbgfs_target_ids_read_before_terminate_race.sh
ok 7 selftests: damon-tests: dbgfs_target_ids_pid_leak.sh
ok 8 selftests: damon-tests: damo_tests.sh
ok 9 selftests: damon-tests: masim-record.sh
ok 10 selftests: damon-tests: build_i386.sh
ok 11 selftests: damon-tests: build_arm64.sh
ok 12 selftests: damon-tests: build_i386_idle_flag.sh
ok 13 selftests: damon-tests: build_i386_highpte.sh
ok 14 selftests: damon-tests: build_nomemcg.sh
[33m
[92mPASS [39m

2024-01-03 22:05:45

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

On 1/3/24 08:55, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.6.10 release.
> There are 49 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.10-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
BMIPS_GENERIC:

Tested-by: Florian Fainelli <[email protected]>
--
Florian


2024-01-03 23:35:54

by Kelsey Steele

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

On Wed, Jan 03, 2024 at 05:55:20PM +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.6.10 release.
> There are 49 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
> Anything received after that time might be too late.

No regressions found on WSL (x86 and arm64).

Built, booted, and reviewed dmesg.

Thank you.

Tested-by: Kelsey Steele <[email protected]>

2024-01-04 00:18:36

by Shuah Khan

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

On 1/3/24 09:55, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.6.10 release.
> There are 49 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.10-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>

Compiled and booted on my test system. No dmesg regressions.

Tested-by: Shuah Khan <[email protected]>

thanks,
-- Shuah

2024-01-04 02:25:05

by Takeshi Ogasawara

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

Hi Greg

On Thu, Jan 4, 2024 at 2:13 AM Greg Kroah-Hartman
<[email protected]> wrote:
>
> This is the start of the stable review cycle for the 6.6.10 release.
> There are 49 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.10-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>

6.6.10-rc1 tested.

Build successfully completed.
Boot successfully completed.
No dmesg regressions.
Video output normal.
Sound output normal.

Lenovo ThinkPad X1 Carbon Gen10(Intel i7-1260P(x86_64) arch linux)

[ 0.000000] Linux version 6.6.10-rc1rv
(takeshi@ThinkPadX1Gen10J0764) (gcc (GCC) 13.2.1 20230801, GNU ld (GNU
Binutils) 2.41.0) #1 SMP PREEMPT_DYNAMIC Thu Jan 4 11:03:04 JST 2024

Thanks

Tested-by: Takeshi Ogasawara <[email protected]>

2024-01-04 04:10:26

by Daniel Díaz

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

Hello!

On 03/01/24 10:55 a. m., Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.6.10 release.
> There are 49 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.10-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

We're seeing a build regression with x86/GCC-8 and allmodconfig:

-----8<-----
In file included from /builds/linux/include/linux/string.h:294,
from /builds/linux/include/linux/bitmap.h:11,
from /builds/linux/include/linux/cpumask.h:12,
from /builds/linux/arch/x86/include/asm/paravirt.h:17,
from /builds/linux/arch/x86/include/asm/cpuid.h:62,
from /builds/linux/arch/x86/include/asm/processor.h:19,
from /builds/linux/arch/x86/include/asm/cpufeature.h:5,
from /builds/linux/arch/x86/include/asm/thread_info.h:53,
from /builds/linux/include/linux/thread_info.h:60,
from /builds/linux/include/linux/uio.h:9,
from /builds/linux/include/linux/socket.h:8,
from /builds/linux/include/uapi/linux/if.h:25,
from /builds/linux/net/wireless/nl80211.c:11:
In function 'nl80211_set_cqm_rssi.isra.44',
inlined from 'nl80211_set_cqm' at /builds/linux/net/wireless/nl80211.c:13000:10:
/builds/linux/include/linux/fortify-string.h:57:29: error: '__builtin_memcpy' pointer overflow between offset 36 and size [-1, 9223372036854775807] [-Werror=array-bounds]
#define __underlying_memcpy __builtin_memcpy
^
/builds/linux/include/linux/fortify-string.h:648:2: note: in expansion of macro '__underlying_memcpy'
__underlying_##op(p, q, __fortify_size); \
^~~~~~~~~~~~~
/builds/linux/include/linux/fortify-string.h:693:26: note: in expansion of macro '__fortify_memcpy_chk'
#define memcpy(p, q, s) __fortify_memcpy_chk(p, q, s, \
^~~~~~~~~~~~~~~~~~~~
/builds/linux/net/wireless/nl80211.c:12939:3: note: in expansion of macro 'memcpy'
memcpy(cqm_config->rssi_thresholds, thresholds,
^~~~~~
cc1: all warnings being treated as errors
make[5]: *** [/builds/linux/scripts/Makefile.build:243: net/wireless/nl80211.o] Error 1
----->8-----

This is currently being bisected, so there is more to follow.


Reported-by: Linux Kernel Functional Testing <[email protected]>

Greetings!

Daniel Díaz
[email protected]


2024-01-04 05:20:25

by Bagas Sanjaya

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

On Wed, Jan 03, 2024 at 05:55:20PM +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.6.10 release.
> There are 49 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>

Successfully compiled and installed the kernel on my computer (Acer
Aspire E15, Intel Core i3 Haswell). No noticeable regressions.

Tested-by: Bagas Sanjaya <[email protected]>

--
An old man doll... just what I always wanted! - Clara


Attachments:
(No filename) (557.00 B)
signature.asc (235.00 B)
Download all attachments

2024-01-04 07:25:59

by Daniel Díaz

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

Hello!

On 03/01/24 10:10 p. m., Daniel Díaz wrote:
> Hello!
>
> On 03/01/24 10:55 a. m., Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 6.6.10 release.
>> There are 49 patches in this series, all will be posted as a response
>> to this one.  If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>>     https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.10-rc1.gz
>> or in the git tree and branch at:
>>     git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
>
> We're seeing a build regression with x86/GCC-8 and allmodconfig:
>
> -----8<-----
>   In file included from /builds/linux/include/linux/string.h:294,
>                    from /builds/linux/include/linux/bitmap.h:11,
>                    from /builds/linux/include/linux/cpumask.h:12,
>                    from /builds/linux/arch/x86/include/asm/paravirt.h:17,
>                    from /builds/linux/arch/x86/include/asm/cpuid.h:62,
>                    from /builds/linux/arch/x86/include/asm/processor.h:19,
>                    from /builds/linux/arch/x86/include/asm/cpufeature.h:5,
>                    from /builds/linux/arch/x86/include/asm/thread_info.h:53,
>                    from /builds/linux/include/linux/thread_info.h:60,
>                    from /builds/linux/include/linux/uio.h:9,
>                    from /builds/linux/include/linux/socket.h:8,
>                    from /builds/linux/include/uapi/linux/if.h:25,
>                    from /builds/linux/net/wireless/nl80211.c:11:
>   In function 'nl80211_set_cqm_rssi.isra.44',
>       inlined from 'nl80211_set_cqm' at /builds/linux/net/wireless/nl80211.c:13000:10:
>   /builds/linux/include/linux/fortify-string.h:57:29: error: '__builtin_memcpy' pointer overflow between offset 36 and size [-1, 9223372036854775807] [-Werror=array-bounds]
>    #define __underlying_memcpy __builtin_memcpy
>                                ^
>   /builds/linux/include/linux/fortify-string.h:648:2: note: in expansion of macro '__underlying_memcpy'
>     __underlying_##op(p, q, __fortify_size);   \
>     ^~~~~~~~~~~~~
>   /builds/linux/include/linux/fortify-string.h:693:26: note: in expansion of macro '__fortify_memcpy_chk'
>    #define memcpy(p, q, s)  __fortify_memcpy_chk(p, q, s,   \
>                             ^~~~~~~~~~~~~~~~~~~~
>   /builds/linux/net/wireless/nl80211.c:12939:3: note: in expansion of macro 'memcpy'
>      memcpy(cqm_config->rssi_thresholds, thresholds,
>      ^~~~~~
>   cc1: all warnings being treated as errors
>   make[5]: *** [/builds/linux/scripts/Makefile.build:243: net/wireless/nl80211.o] Error 1
> ----->8-----
>
> This is currently being bisected, so there is more to follow.

Bisection pointed to:

commit 92045aab1bd9bfd73d816e907ea07739c4550b41
Author: Johannes Berg <[email protected]>
Date: Sat Dec 16 05:47:15 2023 +0000

wifi: cfg80211: fix CQM for non-range use

commit 7e7efdda6adb385fbdfd6f819d76bc68c923c394 upstream.

Reverting that was not possible, so I reverted 47f3694a4259 first ("wifi: nl80211: fix deadlock in nl80211_set_cqm_rssi (6.6.x)"), but that was not enough. After reverting both 47f3694a4259 and 92045aab1bd9, the build passed again.

Reproducer:

tuxmake --runtime podman --target-arch x86_64 --toolchain gcc-8 --kconfig allmodconfig


Greetings!

Daniel Díaz
[email protected]


2024-01-04 07:55:37

by Luna Jernberg

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

Tried to follow this guide:
https://wiki.archlinux.org/title/Kernel/Traditional_compilation to
compile it on Crystal Linux based on Arch Linux on a Dell Latitude
7390 laptop with a Intel i5-8350U and did not get it to boot
but the same process worked for the stable 6.6.9 kernel, so guess i
will just wait for the stable 6.6.10 and try when thats out

Den ons 3 jan. 2024 kl 17:13 skrev Greg Kroah-Hartman
<[email protected]>:
>
> This is the start of the stable review cycle for the 6.6.10 release.
> There are 49 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.10-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
> -------------
> Pseudo-Shortlog of commits:
>
> Greg Kroah-Hartman <[email protected]>
> Linux 6.6.10-rc1
>
> Pablo Neira Ayuso <[email protected]>
> netfilter: nf_tables: skip set commit for deleted/destroyed sets
>
> Léo Lam <[email protected]>
> wifi: nl80211: fix deadlock in nl80211_set_cqm_rssi (6.6.x)
>
> Johannes Berg <[email protected]>
> wifi: cfg80211: fix CQM for non-range use
>
> Steven Rostedt (Google) <[email protected]>
> tracing: Fix blocked reader of snapshot buffer
>
> Steven Rostedt (Google) <[email protected]>
> ftrace: Fix modification of direct_function hash while in use
>
> Steven Rostedt (Google) <[email protected]>
> ring-buffer: Fix wake ups when buffer_percent is set to 100
>
> Keith Busch <[email protected]>
> Revert "nvme-fc: fix race between error recovery and creating association"
>
> Matthew Wilcox (Oracle) <[email protected]>
> mm/memory-failure: check the mapcount of the precise page
>
> Matthew Wilcox (Oracle) <[email protected]>
> mm/memory-failure: cast index to loff_t before shifting it
>
> Charan Teja Kalla <[email protected]>
> mm: migrate high-order folios in swap cache correctly
>
> Baokun Li <[email protected]>
> mm/filemap: avoid buffered read/write race to read inconsistent data
>
> Muhammad Usama Anjum <[email protected]>
> selftests: secretmem: floor the memory size to the multiple of page_size
>
> Sidhartha Kumar <[email protected]>
> maple_tree: do not preallocate nodes for slot stores
>
> Shin'ichiro Kawasaki <[email protected]>
> platform/x86: p2sb: Allow p2sb_bar() calls during PCI device probe
>
> Namjae Jeon <[email protected]>
> ksmbd: fix slab-out-of-bounds in smb_strndup_from_utf16()
>
> David E. Box <[email protected]>
> platform/x86/intel/pmc: Move GBE LTR ignore to suspend callback
>
> David E. Box <[email protected]>
> platform/x86/intel/pmc: Allow reenabling LTRs
>
> David E. Box <[email protected]>
> platform/x86/intel/pmc: Add suspend callback
>
> Christoph Hellwig <[email protected]>
> block: renumber QUEUE_FLAG_HW_WC
>
> Paolo Abeni <[email protected]>
> mptcp: fix inconsistent state on fastopen race
>
> Paolo Abeni <[email protected]>
> mptcp: fix possible NULL pointer dereference on close
>
> Paolo Abeni <[email protected]>
> mptcp: refactor sndbuf auto-tuning
>
> Helge Deller <[email protected]>
> linux/export: Ensure natural alignment of kcrctab array
>
> Helge Deller <[email protected]>
> linux/export: Fix alignment for 64-bit ksymtab entries
>
> Arnd Bergmann <[email protected]>
> kexec: select CRYPTO from KEXEC_FILE instead of depending on it
>
> Arnd Bergmann <[email protected]>
> kexec: fix KEXEC_FILE dependencies
>
> Xuan Zhuo <[email protected]>
> virtio_ring: fix syncs DMA memory with different direction
>
> Zizhi Wo <[email protected]>
> fs: cifs: Fix atime update check
>
> Jeff Layton <[email protected]>
> client: convert to new timestamp accessors
>
> Jeff Layton <[email protected]>
> fs: new accessor methods for atime and mtime
>
> Namjae Jeon <[email protected]>
> ksmbd: avoid duplicate opinfo_put() call on error of smb21_lease_break_ack()
>
> Namjae Jeon <[email protected]>
> ksmbd: lazy v2 lease break on smb2_write()
>
> Namjae Jeon <[email protected]>
> ksmbd: send v2 lease break notification for directory
>
> Namjae Jeon <[email protected]>
> ksmbd: downgrade RWH lease caching state to RH for directory
>
> Namjae Jeon <[email protected]>
> ksmbd: set v2 lease capability
>
> Namjae Jeon <[email protected]>
> ksmbd: set epoch in create context v2 lease
>
> Namjae Jeon <[email protected]>
> ksmbd: don't update ->op_state as OPLOCK_STATE_NONE on error
>
> Namjae Jeon <[email protected]>
> ksmbd: move setting SMB2_FLAGS_ASYNC_COMMAND and AsyncId
>
> Namjae Jeon <[email protected]>
> ksmbd: release interim response after sending status pending response
>
> Namjae Jeon <[email protected]>
> ksmbd: move oplock handling after unlock parent dir
>
> Namjae Jeon <[email protected]>
> ksmbd: separately allocate ci per dentry
>
> Zongmin Zhou <[email protected]>
> ksmbd: prevent memory leak on error return
>
> Namjae Jeon <[email protected]>
> ksmbd: fix kernel-doc comment of ksmbd_vfs_kern_path_locked()
>
> Namjae Jeon <[email protected]>
> ksmbd: no need to wait for binded connection termination at logoff
>
> Namjae Jeon <[email protected]>
> ksmbd: add support for surrogate pair conversion
>
> Kangjing Huang <[email protected]>
> ksmbd: fix missing RDMA-capable flag for IPoIB device in ksmbd_rdma_capable_netdev()
>
> Namjae Jeon <[email protected]>
> ksmbd: fix kernel-doc comment of ksmbd_vfs_setxattr()
>
> Namjae Jeon <[email protected]>
> ksmbd: reorganize ksmbd_iov_pin_rsp()
>
> Cheng-Han Wu <[email protected]>
> ksmbd: Remove unused field in ksmbd_user struct
>
>
> -------------
>
> Diffstat:
>
> Makefile | 4 +-
> arch/powerpc/Kconfig | 4 +-
> arch/riscv/Kconfig | 4 +-
> arch/s390/Kconfig | 4 +-
> arch/x86/Kconfig | 4 +-
> drivers/nvme/host/fc.c | 21 +--
> drivers/platform/x86/intel/pmc/adl.c | 9 +-
> drivers/platform/x86/intel/pmc/cnp.c | 26 ++-
> drivers/platform/x86/intel/pmc/core.c | 12 +-
> drivers/platform/x86/intel/pmc/core.h | 7 +-
> drivers/platform/x86/intel/pmc/mtl.c | 9 +-
> drivers/platform/x86/intel/pmc/tgl.c | 9 +-
> drivers/platform/x86/p2sb.c | 178 ++++++++++++++++-----
> drivers/virtio/virtio_ring.c | 6 +-
> fs/libfs.c | 41 +++--
> fs/smb/client/file.c | 18 ++-
> fs/smb/client/fscache.h | 6 +-
> fs/smb/client/inode.c | 17 +-
> fs/smb/client/smb2ops.c | 6 +-
> fs/smb/common/smb2pdu.h | 1 +
> fs/smb/server/connection.c | 16 --
> fs/smb/server/ksmbd_work.c | 51 +++---
> fs/smb/server/mgmt/user_config.h | 1 -
> fs/smb/server/oplock.c | 118 ++++++++++++--
> fs/smb/server/oplock.h | 8 +-
> fs/smb/server/smb2misc.c | 15 +-
> fs/smb/server/smb2ops.c | 9 +-
> fs/smb/server/smb2pdu.c | 258 ++++++++++++++++--------------
> fs/smb/server/transport_rdma.c | 40 +++--
> fs/smb/server/unicode.c | 187 ++++++++++++++++------
> fs/smb/server/vfs.c | 14 +-
> fs/smb/server/vfs_cache.c | 30 ++--
> fs/smb/server/vfs_cache.h | 9 +-
> include/linux/blkdev.h | 2 +-
> include/linux/export-internal.h | 6 +-
> include/linux/fs.h | 85 ++++++++--
> kernel/Kconfig.kexec | 2 +
> kernel/trace/ftrace.c | 100 ++++++------
> kernel/trace/ring_buffer.c | 12 +-
> kernel/trace/trace.c | 20 ++-
> lib/maple_tree.c | 11 ++
> mm/filemap.c | 9 ++
> mm/memory-failure.c | 8 +-
> mm/migrate.c | 9 +-
> net/mptcp/protocol.c | 27 +++-
> net/mptcp/protocol.h | 63 +++++++-
> net/mptcp/sockopt.c | 5 +-
> net/mptcp/subflow.c | 29 ++--
> net/netfilter/nf_tables_api.c | 2 +-
> net/wireless/core.h | 1 +
> net/wireless/nl80211.c | 56 ++++---
> tools/testing/radix-tree/maple.c | 2 +-
> tools/testing/selftests/mm/memfd_secret.c | 3 +
> 53 files changed, 1070 insertions(+), 524 deletions(-)
>
>
>

2024-01-04 07:57:38

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

On Thu, Jan 04, 2024 at 07:55:02AM +0000, Luna Jernberg wrote:
> Tried to follow this guide:
> https://wiki.archlinux.org/title/Kernel/Traditional_compilation to
> compile it on Crystal Linux based on Arch Linux on a Dell Latitude
> 7390 laptop with a Intel i5-8350U and did not get it to boot
> but the same process worked for the stable 6.6.9 kernel, so guess i
> will just wait for the stable 6.6.10 and try when thats out

Can you use 'git bisect' to find the offending commit?

thanks,

greg k-h

2024-01-04 07:59:16

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

On Thu, Jan 04, 2024 at 01:15:45AM -0600, Daniel D?az wrote:
> Hello!
>
> On 03/01/24 10:10 p.?m., Daniel D?az wrote:
> > Hello!
> >
> > On 03/01/24 10:55 a.?m., Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 6.6.10 release.
> > > There are 49 patches in this series, all will be posted as a response
> > > to this one.? If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > > ????https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.10-rc1.gz
> > > or in the git tree and branch at:
> > > ????git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > We're seeing a build regression with x86/GCC-8 and allmodconfig:
> >
> > -----8<-----
> > ? In file included from /builds/linux/include/linux/string.h:294,
> > ?????????????????? from /builds/linux/include/linux/bitmap.h:11,
> > ?????????????????? from /builds/linux/include/linux/cpumask.h:12,
> > ?????????????????? from /builds/linux/arch/x86/include/asm/paravirt.h:17,
> > ?????????????????? from /builds/linux/arch/x86/include/asm/cpuid.h:62,
> > ?????????????????? from /builds/linux/arch/x86/include/asm/processor.h:19,
> > ?????????????????? from /builds/linux/arch/x86/include/asm/cpufeature.h:5,
> > ?????????????????? from /builds/linux/arch/x86/include/asm/thread_info.h:53,
> > ?????????????????? from /builds/linux/include/linux/thread_info.h:60,
> > ?????????????????? from /builds/linux/include/linux/uio.h:9,
> > ?????????????????? from /builds/linux/include/linux/socket.h:8,
> > ?????????????????? from /builds/linux/include/uapi/linux/if.h:25,
> > ?????????????????? from /builds/linux/net/wireless/nl80211.c:11:
> > ? In function 'nl80211_set_cqm_rssi.isra.44',
> > ????? inlined from 'nl80211_set_cqm' at /builds/linux/net/wireless/nl80211.c:13000:10:
> > ? /builds/linux/include/linux/fortify-string.h:57:29: error: '__builtin_memcpy' pointer overflow between offset 36 and size [-1, 9223372036854775807] [-Werror=array-bounds]
> > ?? #define __underlying_memcpy __builtin_memcpy
> > ?????????????????????????????? ^
> > ? /builds/linux/include/linux/fortify-string.h:648:2: note: in expansion of macro '__underlying_memcpy'
> > ??? __underlying_##op(p, q, __fortify_size);?? \
> > ??? ^~~~~~~~~~~~~
> > ? /builds/linux/include/linux/fortify-string.h:693:26: note: in expansion of macro '__fortify_memcpy_chk'
> > ?? #define memcpy(p, q, s)? __fortify_memcpy_chk(p, q, s,?? \
> > ??????????????????????????? ^~~~~~~~~~~~~~~~~~~~
> > ? /builds/linux/net/wireless/nl80211.c:12939:3: note: in expansion of macro 'memcpy'
> > ???? memcpy(cqm_config->rssi_thresholds, thresholds,
> > ???? ^~~~~~
> > ? cc1: all warnings being treated as errors
> > ? make[5]: *** [/builds/linux/scripts/Makefile.build:243: net/wireless/nl80211.o] Error 1
> > ----->8-----
> >
> > This is currently being bisected, so there is more to follow.
>
> Bisection pointed to:
>
> commit 92045aab1bd9bfd73d816e907ea07739c4550b41
> Author: Johannes Berg <[email protected]>
> Date: Sat Dec 16 05:47:15 2023 +0000
>
> wifi: cfg80211: fix CQM for non-range use
> commit 7e7efdda6adb385fbdfd6f819d76bc68c923c394 upstream.
>
> Reverting that was not possible, so I reverted 47f3694a4259 first ("wifi: nl80211: fix deadlock in nl80211_set_cqm_rssi (6.6.x)"), but that was not enough. After reverting both 47f3694a4259 and 92045aab1bd9, the build passed again.
>
> Reproducer:
>
> tuxmake --runtime podman --target-arch x86_64 --toolchain gcc-8 --kconfig allmodconfig

Very odd, 6.1 works fine with this same compiler? These changes were in
the 6.1.70 release (and the 6.1.66 release) before.

It was also in 6.6.5, before being reverted in 6.6.6, so why is this
causing a problem now?

confused,

greg k-h

2024-01-04 08:22:34

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

On Thu, 2024-01-04 at 08:58 +0100, Greg Kroah-Hartman wrote:
> > >
> > > We're seeing a build regression with x86/GCC-8 and allmodconfig:
> > >
> > > -----8<-----
> > >   In file included from /builds/linux/include/linux/string.h:294,
> > >                    from /builds/linux/include/linux/bitmap.h:11,
> > >                    from /builds/linux/include/linux/cpumask.h:12,
> > >                    from /builds/linux/arch/x86/include/asm/paravirt.h:17,
> > >                    from /builds/linux/arch/x86/include/asm/cpuid.h:62,
> > >                    from /builds/linux/arch/x86/include/asm/processor.h:19,
> > >                    from /builds/linux/arch/x86/include/asm/cpufeature.h:5,
> > >                    from /builds/linux/arch/x86/include/asm/thread_info.h:53,
> > >                    from /builds/linux/include/linux/thread_info.h:60,
> > >                    from /builds/linux/include/linux/uio.h:9,
> > >                    from /builds/linux/include/linux/socket.h:8,
> > >                    from /builds/linux/include/uapi/linux/if.h:25,
> > >                    from /builds/linux/net/wireless/nl80211.c:11:
> > >   In function 'nl80211_set_cqm_rssi.isra.44',
> > >       inlined from 'nl80211_set_cqm' at /builds/linux/net/wireless/nl80211.c:13000:10:
> > >   /builds/linux/include/linux/fortify-string.h:57:29: error: '__builtin_memcpy' pointer overflow between offset 36 and size [-1, 9223372036854775807] [-Werror=array-bounds]

This partially showed up upstream as well, but it was pretty hard to
see, so I think config and this very specific compiler version may be
affecting it as well.

> Very odd, 6.1 works fine with this same compiler? These changes were in
> the 6.1.70 release (and the 6.1.66 release) before.
>
> It was also in 6.6.5, before being reverted in 6.6.6, so why is this
> causing a problem now?

Yeah, it's all a bit weird.

Kees ended up fixing it upstream with commit 172db56d90d2 ("netlink:
Return unsigned value for nla_len()") (in net-next), but I cannot
actually say that I understand all what's going on here.

johannes

2024-01-04 10:28:18

by Ron Economos

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

On 1/3/24 8:55 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.6.10 release.
> There are 49 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.10-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Built and booted successfully on RISC-V RV64 (HiFive Unmatched).

Tested-by: Ron Economos <[email protected]>


2024-01-04 11:55:53

by Harshit Mogalapalli

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

Hi Greg,

On 03/01/24 10:25 pm, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.6.10 release.
> There are 49 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.10-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y
> and the diffstat can be found below.
>

Built and boot tested on x86_64 and aarch64.

Tested-by: Harshit Mogalapalli <[email protected]>

Thanks,
Harshit

> thanks,
>
> greg k-h
>

2024-01-04 12:40:17

by Naresh Kamboju

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

On Thu, 4 Jan 2024 at 13:29, Greg Kroah-Hartman
<[email protected]> wrote:
>
> On Thu, Jan 04, 2024 at 01:15:45AM -0600, Daniel Díaz wrote:
> > Hello!
> >
> > On 03/01/24 10:10 p. m., Daniel Díaz wrote:
> > > Hello!
> > >
> > > On 03/01/24 10:55 a. m., Greg Kroah-Hartman wrote:
> > > > This is the start of the stable review cycle for the 6.6.10 release.
> > > > There are 49 patches in this series, all will be posted as a response
> > > > to this one. If anyone has any issues with these being applied, please
> > > > let me know.
> > > >
> > > > Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
> > > > Anything received after that time might be too late.
> > > >
> > > > The whole patch series can be found in one patch at:
> > > > https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.10-rc1.gz
> > > > or in the git tree and branch at:
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y
> > > > and the diffstat can be found below.
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > >
> > > We're seeing a build regression with x86/GCC-8 and allmodconfig:
> > >
> > > -----8<-----
> > > In file included from /builds/linux/include/linux/string.h:294,
> > > from /builds/linux/include/linux/bitmap.h:11,
> > > from /builds/linux/include/linux/cpumask.h:12,
> > > from /builds/linux/arch/x86/include/asm/paravirt.h:17,
> > > from /builds/linux/arch/x86/include/asm/cpuid.h:62,
> > > from /builds/linux/arch/x86/include/asm/processor.h:19,
> > > from /builds/linux/arch/x86/include/asm/cpufeature.h:5,
> > > from /builds/linux/arch/x86/include/asm/thread_info.h:53,
> > > from /builds/linux/include/linux/thread_info.h:60,
> > > from /builds/linux/include/linux/uio.h:9,
> > > from /builds/linux/include/linux/socket.h:8,
> > > from /builds/linux/include/uapi/linux/if.h:25,
> > > from /builds/linux/net/wireless/nl80211.c:11:
> > > In function 'nl80211_set_cqm_rssi.isra.44',
> > > inlined from 'nl80211_set_cqm' at /builds/linux/net/wireless/nl80211.c:13000:10:
> > > /builds/linux/include/linux/fortify-string.h:57:29: error: '__builtin_memcpy' pointer overflow between offset 36 and size [-1, 9223372036854775807] [-Werror=array-bounds]
> > > #define __underlying_memcpy __builtin_memcpy
> > > ^
> > > /builds/linux/include/linux/fortify-string.h:648:2: note: in expansion of macro '__underlying_memcpy'
> > > __underlying_##op(p, q, __fortify_size); \
> > > ^~~~~~~~~~~~~
> > > /builds/linux/include/linux/fortify-string.h:693:26: note: in expansion of macro '__fortify_memcpy_chk'
> > > #define memcpy(p, q, s) __fortify_memcpy_chk(p, q, s, \
> > > ^~~~~~~~~~~~~~~~~~~~
> > > /builds/linux/net/wireless/nl80211.c:12939:3: note: in expansion of macro 'memcpy'
> > > memcpy(cqm_config->rssi_thresholds, thresholds,
> > > ^~~~~~
> > > cc1: all warnings being treated as errors
> > > make[5]: *** [/builds/linux/scripts/Makefile.build:243: net/wireless/nl80211.o] Error 1
> > > ----->8-----
> > >
> > > This is currently being bisected, so there is more to follow.
> >
> > Bisection pointed to:
> >
> > commit 92045aab1bd9bfd73d816e907ea07739c4550b41
> > Author: Johannes Berg <[email protected]>
> > Date: Sat Dec 16 05:47:15 2023 +0000
> >
> > wifi: cfg80211: fix CQM for non-range use
> > commit 7e7efdda6adb385fbdfd6f819d76bc68c923c394 upstream.
> >
> > Reverting that was not possible, so I reverted 47f3694a4259 first ("wifi: nl80211: fix deadlock in nl80211_set_cqm_rssi (6.6.x)"), but that was not enough. After reverting both 47f3694a4259 and 92045aab1bd9, the build passed again.
> >
> > Reproducer:
> >
> > tuxmake --runtime podman --target-arch x86_64 --toolchain gcc-8 --kconfig allmodconfig
>
> Very odd, 6.1 works fine with this same compiler?

It works on 6.1 with the same compiler.

> These changes were in
> the 6.1.70 release (and the 6.1.66 release) before.
>
> It was also in 6.6.5, before being reverted in 6.6.6, so why is this
> causing a problem now?

It was also noticed on 6.6.5-rc1
git_describe: v6.6.4-135-gb0b05ccdd77d

I have already reported this on a stable mailing list [1] on 6.6.5-rc1.

Please find more details and comments from Arnd [2] and Kees [3].

[1] https://lore.kernel.org/stable/CA+G9fYuL_-Q67t+Y7ST5taYv1XkkoJegH2zBvw_ZUOhF9QRiOg@mail.gmail.com/
[2] https://lore.kernel.org/stable/[email protected]/
[3] https://lore.kernel.org/all/202311301016.84D0010@keescook/

Test results comparison,
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.6.y/build/v6.6.9-50-g5fd1c89851c4/testrun/21921607/suite/build/test/gcc-8-allmodconfig/history/

- Naresh

2024-01-04 12:58:49

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

On Thu, Jan 04, 2024 at 06:09:53PM +0530, Naresh Kamboju wrote:
> On Thu, 4 Jan 2024 at 13:29, Greg Kroah-Hartman
> <[email protected]> wrote:
> >
> > On Thu, Jan 04, 2024 at 01:15:45AM -0600, Daniel D?az wrote:
> > > Hello!
> > >
> > > On 03/01/24 10:10 p. m., Daniel D?az wrote:
> > > > Hello!
> > > >
> > > > On 03/01/24 10:55 a. m., Greg Kroah-Hartman wrote:
> > > > > This is the start of the stable review cycle for the 6.6.10 release.
> > > > > There are 49 patches in this series, all will be posted as a response
> > > > > to this one. If anyone has any issues with these being applied, please
> > > > > let me know.
> > > > >
> > > > > Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
> > > > > Anything received after that time might be too late.
> > > > >
> > > > > The whole patch series can be found in one patch at:
> > > > > https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.10-rc1.gz
> > > > > or in the git tree and branch at:
> > > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y
> > > > > and the diffstat can be found below.
> > > > >
> > > > > thanks,
> > > > >
> > > > > greg k-h
> > > >
> > > > We're seeing a build regression with x86/GCC-8 and allmodconfig:
> > > >
> > > > -----8<-----
> > > > In file included from /builds/linux/include/linux/string.h:294,
> > > > from /builds/linux/include/linux/bitmap.h:11,
> > > > from /builds/linux/include/linux/cpumask.h:12,
> > > > from /builds/linux/arch/x86/include/asm/paravirt.h:17,
> > > > from /builds/linux/arch/x86/include/asm/cpuid.h:62,
> > > > from /builds/linux/arch/x86/include/asm/processor.h:19,
> > > > from /builds/linux/arch/x86/include/asm/cpufeature.h:5,
> > > > from /builds/linux/arch/x86/include/asm/thread_info.h:53,
> > > > from /builds/linux/include/linux/thread_info.h:60,
> > > > from /builds/linux/include/linux/uio.h:9,
> > > > from /builds/linux/include/linux/socket.h:8,
> > > > from /builds/linux/include/uapi/linux/if.h:25,
> > > > from /builds/linux/net/wireless/nl80211.c:11:
> > > > In function 'nl80211_set_cqm_rssi.isra.44',
> > > > inlined from 'nl80211_set_cqm' at /builds/linux/net/wireless/nl80211.c:13000:10:
> > > > /builds/linux/include/linux/fortify-string.h:57:29: error: '__builtin_memcpy' pointer overflow between offset 36 and size [-1, 9223372036854775807] [-Werror=array-bounds]
> > > > #define __underlying_memcpy __builtin_memcpy
> > > > ^
> > > > /builds/linux/include/linux/fortify-string.h:648:2: note: in expansion of macro '__underlying_memcpy'
> > > > __underlying_##op(p, q, __fortify_size); \
> > > > ^~~~~~~~~~~~~
> > > > /builds/linux/include/linux/fortify-string.h:693:26: note: in expansion of macro '__fortify_memcpy_chk'
> > > > #define memcpy(p, q, s) __fortify_memcpy_chk(p, q, s, \
> > > > ^~~~~~~~~~~~~~~~~~~~
> > > > /builds/linux/net/wireless/nl80211.c:12939:3: note: in expansion of macro 'memcpy'
> > > > memcpy(cqm_config->rssi_thresholds, thresholds,
> > > > ^~~~~~
> > > > cc1: all warnings being treated as errors
> > > > make[5]: *** [/builds/linux/scripts/Makefile.build:243: net/wireless/nl80211.o] Error 1
> > > > ----->8-----
> > > >
> > > > This is currently being bisected, so there is more to follow.
> > >
> > > Bisection pointed to:
> > >
> > > commit 92045aab1bd9bfd73d816e907ea07739c4550b41
> > > Author: Johannes Berg <[email protected]>
> > > Date: Sat Dec 16 05:47:15 2023 +0000
> > >
> > > wifi: cfg80211: fix CQM for non-range use
> > > commit 7e7efdda6adb385fbdfd6f819d76bc68c923c394 upstream.
> > >
> > > Reverting that was not possible, so I reverted 47f3694a4259 first ("wifi: nl80211: fix deadlock in nl80211_set_cqm_rssi (6.6.x)"), but that was not enough. After reverting both 47f3694a4259 and 92045aab1bd9, the build passed again.
> > >
> > > Reproducer:
> > >
> > > tuxmake --runtime podman --target-arch x86_64 --toolchain gcc-8 --kconfig allmodconfig
> >
> > Very odd, 6.1 works fine with this same compiler?
>
> It works on 6.1 with the same compiler.
>
> > These changes were in
> > the 6.1.70 release (and the 6.1.66 release) before.
> >
> > It was also in 6.6.5, before being reverted in 6.6.6, so why is this
> > causing a problem now?
>
> It was also noticed on 6.6.5-rc1
> git_describe: v6.6.4-135-gb0b05ccdd77d
>
> I have already reported this on a stable mailing list [1] on 6.6.5-rc1.
>
> Please find more details and comments from Arnd [2] and Kees [3].
>
> [1] https://lore.kernel.org/stable/CA+G9fYuL_-Q67t+Y7ST5taYv1XkkoJegH2zBvw_ZUOhF9QRiOg@mail.gmail.com/
> [2] https://lore.kernel.org/stable/[email protected]/
> [3] https://lore.kernel.org/all/202311301016.84D0010@keescook/
>
> Test results comparison,
> https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-6.6.y/build/v6.6.9-50-g5fd1c89851c4/testrun/21921607/suite/build/test/gcc-8-allmodconfig/history/

Ah, ok, thanks, I forgot about that. All should be good then,

greg k-h

2024-01-04 16:52:53

by Jon Hunter

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

On Wed, 03 Jan 2024 17:55:20 +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.6.10 release.
> There are 49 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.10-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

All tests passing for Tegra ...

Test results for stable-v6.6:
10 builds: 10 pass, 0 fail
26 boots: 26 pass, 0 fail
106 tests: 106 pass, 0 fail

Linux version: 6.6.10-rc1-g5fd1c89851c4
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
tegra20-ventana, tegra210-p2371-2180,
tegra210-p3450-0000, tegra30-cardhu-a04

Tested-by: Jon Hunter <[email protected]>

Jon

2024-01-04 17:16:05

by Allen

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

> This is the start of the stable review cycle for the 6.6.10 release.
> There are 49 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.10-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-6.6.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
>
Compiled and booted on my x86_64 and ARM64 test systems. No errors or
regressions.

Tested-by: Allen Pais <[email protected]>

Thanks.

2024-01-05 01:04:33

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

On Wed, Jan 03, 2024 at 05:55:20PM +0100, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 6.6.10 release.
> There are 49 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
> Anything received after that time might be too late.
>

Build results:
total: 157 pass: 157 fail: 0
Qemu test results:
total: 545 pass: 545 fail: 0

Tested-by: Guenter Roeck <[email protected]>

Guenter

2024-01-05 02:43:56

by Namjae Jeon

[permalink] [raw]
Subject: Re: [PATCH 6.6 00/49] 6.6.10-rc1 review

2024-01-04 1:55 GMT+09:00, Greg Kroah-Hartman <[email protected]>:
> This is the start of the stable review cycle for the 6.6.10 release.
> There are 49 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Fri, 05 Jan 2024 16:47:49 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v6.x/stable-review/patch-6.6.10-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> linux-6.6.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
I have tested smbtorture and tests through windows client against ksmbd.

Tested-by: Namjae Jeon <[email protected]>

Thanks!