2019-02-13 15:46:02

by Rob Clark

[permalink] [raw]
Subject: [PATCH] MAINTAINERS: update entry for drm/msm

We've moved the tree to a shared gitlab tree, so that Sean can help out
with maintainer duties.

Cc: Sean Paul <[email protected]>
Signed-off-by: Rob Clark <[email protected]>
---
I can include this patch in msm-next for v5.1, but wanted to get it
ack'd on list

MAINTAINERS | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 9919840d54cd..2141a1b6653d 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4838,10 +4838,11 @@ F: Documentation/devicetree/bindings/display/multi-inno,mi0283qt.txt

DRM DRIVER FOR MSM ADRENO GPU
M: Rob Clark <[email protected]>
+M: Sean Paul <[email protected]>
L: [email protected]
L: [email protected]
L: [email protected]
-T: git git://people.freedesktop.org/~robclark/linux
+T: git https://gitlab.freedesktop.org/drm/msm.git
S: Maintained
F: drivers/gpu/drm/msm/
F: include/uapi/drm/msm_drm.h
--
A
2.20.1



2019-02-13 15:58:21

by Daniel Vetter

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: update entry for drm/msm

On Wed, Feb 13, 2019 at 10:10:44AM -0500, Rob Clark via dri-devel wrote:
> We've moved the tree to a shared gitlab tree, so that Sean can help out
> with maintainer duties.
>
> Cc: Sean Paul <[email protected]>
> Signed-off-by: Rob Clark <[email protected]>
> ---
> I can include this patch in msm-next for v5.1, but wanted to get it
> ack'd on list

Is the plan to also add this to dim, for full group maintainership fun?
It's more or less adding a few lines to nightly.conf and done (plus
everyone being ok with using the dim tooling).
-Daniel

>
> MAINTAINERS | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9919840d54cd..2141a1b6653d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4838,10 +4838,11 @@ F: Documentation/devicetree/bindings/display/multi-inno,mi0283qt.txt
>
> DRM DRIVER FOR MSM ADRENO GPU
> M: Rob Clark <[email protected]>
> +M: Sean Paul <[email protected]>
> L: [email protected]
> L: [email protected]
> L: [email protected]
> -T: git git://people.freedesktop.org/~robclark/linux
> +T: git https://gitlab.freedesktop.org/drm/msm.git
> S: Maintained
> F: drivers/gpu/drm/msm/
> F: include/uapi/drm/msm_drm.h
> --
> A
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

2019-02-13 16:00:59

by Sean Paul

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: update entry for drm/msm

On Wed, Feb 13, 2019 at 10:10:44AM -0500, Rob Clark via dri-devel wrote:
> We've moved the tree to a shared gitlab tree, so that Sean can help out
> with maintainer duties.
>
> Cc: Sean Paul <[email protected]>

Acked-by: Sean Paul <[email protected]>

> Signed-off-by: Rob Clark <[email protected]>
> ---
> I can include this patch in msm-next for v5.1, but wanted to get it
> ack'd on list
>
> MAINTAINERS | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 9919840d54cd..2141a1b6653d 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4838,10 +4838,11 @@ F: Documentation/devicetree/bindings/display/multi-inno,mi0283qt.txt
>
> DRM DRIVER FOR MSM ADRENO GPU
> M: Rob Clark <[email protected]>
> +M: Sean Paul <[email protected]>
> L: [email protected]
> L: [email protected]
> L: [email protected]
> -T: git git://people.freedesktop.org/~robclark/linux
> +T: git https://gitlab.freedesktop.org/drm/msm.git
> S: Maintained
> F: drivers/gpu/drm/msm/
> F: include/uapi/drm/msm_drm.h
> --
> A
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Sean Paul, Software Engineer, Google / Chromium OS

2019-02-13 16:11:23

by Rob Clark

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: update entry for drm/msm

On Wed, Feb 13, 2019 at 10:28 AM Daniel Vetter <[email protected]> wrote:
>
> On Wed, Feb 13, 2019 at 10:10:44AM -0500, Rob Clark via dri-devel wrote:
> > We've moved the tree to a shared gitlab tree, so that Sean can help out
> > with maintainer duties.
> >
> > Cc: Sean Paul <[email protected]>
> > Signed-off-by: Rob Clark <[email protected]>
> > ---
> > I can include this patch in msm-next for v5.1, but wanted to get it
> > ack'd on list
>
> Is the plan to also add this to dim, for full group maintainership fun?
> It's more or less adding a few lines to nightly.conf and done (plus
> everyone being ok with using the dim tooling).

I think drm/msm is big enough, that it wouldn't make sense to move to
drm-misc.. but possibly using the dim tooling could make sense.

BR,
-R

> -Daniel
>
> >
> > MAINTAINERS | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 9919840d54cd..2141a1b6653d 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -4838,10 +4838,11 @@ F: Documentation/devicetree/bindings/display/multi-inno,mi0283qt.txt
> >
> > DRM DRIVER FOR MSM ADRENO GPU
> > M: Rob Clark <[email protected]>
> > +M: Sean Paul <[email protected]>
> > L: [email protected]
> > L: [email protected]
> > L: [email protected]
> > -T: git git://people.freedesktop.org/~robclark/linux
> > +T: git https://gitlab.freedesktop.org/drm/msm.git
> > S: Maintained
> > F: drivers/gpu/drm/msm/
> > F: include/uapi/drm/msm_drm.h
> > --
> > A
> > 2.20.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > [email protected]
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

2019-02-13 16:18:48

by Daniel Vetter

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: update entry for drm/msm

On Wed, Feb 13, 2019 at 4:43 PM Rob Clark via dri-devel
<[email protected]> wrote:
>
> On Wed, Feb 13, 2019 at 10:28 AM Daniel Vetter <[email protected]> wrote:
> >
> > On Wed, Feb 13, 2019 at 10:10:44AM -0500, Rob Clark via dri-devel wrote:
> > > We've moved the tree to a shared gitlab tree, so that Sean can help out
> > > with maintainer duties.
> > >
> > > Cc: Sean Paul <[email protected]>
> > > Signed-off-by: Rob Clark <[email protected]>
> > > ---
> > > I can include this patch in msm-next for v5.1, but wanted to get it
> > > ack'd on list
> >
> > Is the plan to also add this to dim, for full group maintainership fun?
> > It's more or less adding a few lines to nightly.conf and done (plus
> > everyone being ok with using the dim tooling).
>
> I think drm/msm is big enough, that it wouldn't make sense to move to
> drm-misc.. but possibly using the dim tooling could make sense.

This was about using the dim tooling, not about moving msm to
drm-misc. That indeed doesn't make much sense. And Sean already knows
that tooling. Plus you pretty much need a big script if you want to
add more committers (which imo you guys totally should), since
otherwise you spend up endless amounts of time training people on
trivial hiccups.
-Daniel

> BR,
> -R
>
> > -Daniel
> >
> > >
> > > MAINTAINERS | 3 ++-
> > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 9919840d54cd..2141a1b6653d 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -4838,10 +4838,11 @@ F: Documentation/devicetree/bindings/display/multi-inno,mi0283qt.txt
> > >
> > > DRM DRIVER FOR MSM ADRENO GPU
> > > M: Rob Clark <[email protected]>
> > > +M: Sean Paul <[email protected]>
> > > L: [email protected]
> > > L: [email protected]
> > > L: [email protected]
> > > -T: git git://people.freedesktop.org/~robclark/linux
> > > +T: git https://gitlab.freedesktop.org/drm/msm.git
> > > S: Maintained
> > > F: drivers/gpu/drm/msm/
> > > F: include/uapi/drm/msm_drm.h
> > > --
> > > A
> > > 2.20.1
> > >
> > > _______________________________________________
> > > dri-devel mailing list
> > > [email protected]
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
> > --
> > Daniel Vetter
> > Software Engineer, Intel Corporation
> > http://blog.ffwll.ch
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel



--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

2019-02-13 16:29:58

by Sean Paul

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: update entry for drm/msm

On Wed, Feb 13, 2019 at 05:04:59PM +0100, Daniel Vetter wrote:
> On Wed, Feb 13, 2019 at 4:43 PM Rob Clark via dri-devel
> <[email protected]> wrote:
> >
> > On Wed, Feb 13, 2019 at 10:28 AM Daniel Vetter <[email protected]> wrote:
> > >
> > > On Wed, Feb 13, 2019 at 10:10:44AM -0500, Rob Clark via dri-devel wrote:
> > > > We've moved the tree to a shared gitlab tree, so that Sean can help out
> > > > with maintainer duties.
> > > >
> > > > Cc: Sean Paul <[email protected]>
> > > > Signed-off-by: Rob Clark <[email protected]>
> > > > ---
> > > > I can include this patch in msm-next for v5.1, but wanted to get it
> > > > ack'd on list
> > >
> > > Is the plan to also add this to dim, for full group maintainership fun?
> > > It's more or less adding a few lines to nightly.conf and done (plus
> > > everyone being ok with using the dim tooling).
> >
> > I think drm/msm is big enough, that it wouldn't make sense to move to
> > drm-misc.. but possibly using the dim tooling could make sense.
>
> This was about using the dim tooling, not about moving msm to
> drm-misc. That indeed doesn't make much sense. And Sean already knows
> that tooling. Plus you pretty much need a big script if you want to
> add more committers (which imo you guys totally should), since
> otherwise you spend up endless amounts of time training people on
> trivial hiccups.

Yeah, we've talked about switching to dim a few times already. IMO, the big win
for msm would be inclusion in drm-tip to catch integration issues early, and
dim's sanity checks around tags. Selfishly, this would also reduce dim's
complaints when backmerging drm into drm-misc :-).

That said, would the committers we'd want to add to msm (Qualcomm employees) be
receptive to (or even able to install/download) dim? I'm not sure on this one.

At any rate, last time we discussed dim, we agreed the first step was to get
msm on gitlab so we can easily add commit access and go from there. I think
we're probably just at the end of that transition period, so everything is on
track!

Sean


> -Daniel
>
> > BR,
> > -R
> >
> > > -Daniel
> > >
> > > >
> > > > MAINTAINERS | 3 ++-
> > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index 9919840d54cd..2141a1b6653d 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -4838,10 +4838,11 @@ F: Documentation/devicetree/bindings/display/multi-inno,mi0283qt.txt
> > > >
> > > > DRM DRIVER FOR MSM ADRENO GPU
> > > > M: Rob Clark <[email protected]>
> > > > +M: Sean Paul <[email protected]>
> > > > L: [email protected]
> > > > L: [email protected]
> > > > L: [email protected]
> > > > -T: git git://people.freedesktop.org/~robclark/linux
> > > > +T: git https://gitlab.freedesktop.org/drm/msm.git
> > > > S: Maintained
> > > > F: drivers/gpu/drm/msm/
> > > > F: include/uapi/drm/msm_drm.h
> > > > --
> > > > A
> > > > 2.20.1
> > > >
> > > > _______________________________________________
> > > > dri-devel mailing list
> > > > [email protected]
> > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > >
> > > --
> > > Daniel Vetter
> > > Software Engineer, Intel Corporation
> > > http://blog.ffwll.ch
> > _______________________________________________
> > dri-devel mailing list
> > [email protected]
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

--
Sean Paul, Software Engineer, Google / Chromium OS

2019-02-14 17:05:47

by Daniel Vetter

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: update entry for drm/msm

On Wed, Feb 13, 2019 at 11:23:07AM -0500, Sean Paul wrote:
> On Wed, Feb 13, 2019 at 05:04:59PM +0100, Daniel Vetter wrote:
> > On Wed, Feb 13, 2019 at 4:43 PM Rob Clark via dri-devel
> > <[email protected]> wrote:
> > >
> > > On Wed, Feb 13, 2019 at 10:28 AM Daniel Vetter <[email protected]> wrote:
> > > >
> > > > On Wed, Feb 13, 2019 at 10:10:44AM -0500, Rob Clark via dri-devel wrote:
> > > > > We've moved the tree to a shared gitlab tree, so that Sean can help out
> > > > > with maintainer duties.
> > > > >
> > > > > Cc: Sean Paul <[email protected]>
> > > > > Signed-off-by: Rob Clark <[email protected]>
> > > > > ---
> > > > > I can include this patch in msm-next for v5.1, but wanted to get it
> > > > > ack'd on list
> > > >
> > > > Is the plan to also add this to dim, for full group maintainership fun?
> > > > It's more or less adding a few lines to nightly.conf and done (plus
> > > > everyone being ok with using the dim tooling).
> > >
> > > I think drm/msm is big enough, that it wouldn't make sense to move to
> > > drm-misc.. but possibly using the dim tooling could make sense.
> >
> > This was about using the dim tooling, not about moving msm to
> > drm-misc. That indeed doesn't make much sense. And Sean already knows
> > that tooling. Plus you pretty much need a big script if you want to
> > add more committers (which imo you guys totally should), since
> > otherwise you spend up endless amounts of time training people on
> > trivial hiccups.
>
> Yeah, we've talked about switching to dim a few times already. IMO, the big win
> for msm would be inclusion in drm-tip to catch integration issues early, and
> dim's sanity checks around tags. Selfishly, this would also reduce dim's
> complaints when backmerging drm into drm-misc :-).
>
> That said, would the committers we'd want to add to msm (Qualcomm employees) be
> receptive to (or even able to install/download) dim? I'm not sure on this one.
>
> At any rate, last time we discussed dim, we agreed the first step was to get
> msm on gitlab so we can easily add commit access and go from there. I think
> we're probably just at the end of that transition period, so everything is on
> track!

If you folks want I can add msm-next and msm-fixes (that one doesn't exist
yet) to the dim branches. That way you don't have to reinvent wheels
anymore (you can use dim) and Rob can look into it whenever (dim only
checks stuff you're doing, and doesn't care what other people push).

Oh and ocd me noticed you have some branch chaos :-)
-Daniel

>
> Sean
>
>
> > -Daniel
> >
> > > BR,
> > > -R
> > >
> > > > -Daniel
> > > >
> > > > >
> > > > > MAINTAINERS | 3 ++-
> > > > > 1 file changed, 2 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > > index 9919840d54cd..2141a1b6653d 100644
> > > > > --- a/MAINTAINERS
> > > > > +++ b/MAINTAINERS
> > > > > @@ -4838,10 +4838,11 @@ F: Documentation/devicetree/bindings/display/multi-inno,mi0283qt.txt
> > > > >
> > > > > DRM DRIVER FOR MSM ADRENO GPU
> > > > > M: Rob Clark <[email protected]>
> > > > > +M: Sean Paul <[email protected]>
> > > > > L: [email protected]
> > > > > L: [email protected]
> > > > > L: [email protected]
> > > > > -T: git git://people.freedesktop.org/~robclark/linux
> > > > > +T: git https://gitlab.freedesktop.org/drm/msm.git
> > > > > S: Maintained
> > > > > F: drivers/gpu/drm/msm/
> > > > > F: include/uapi/drm/msm_drm.h
> > > > > --
> > > > > A
> > > > > 2.20.1
> > > > >
> > > > > _______________________________________________
> > > > > dri-devel mailing list
> > > > > [email protected]
> > > > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> > > >
> > > > --
> > > > Daniel Vetter
> > > > Software Engineer, Intel Corporation
> > > > http://blog.ffwll.ch
> > > _______________________________________________
> > > dri-devel mailing list
> > > [email protected]
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
> >
> >
> > --
> > Daniel Vetter
> > Software Engineer, Intel Corporation
> > +41 (0) 79 365 57 48 - http://blog.ffwll.ch
> > _______________________________________________
> > dri-devel mailing list
> > [email protected]
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Sean Paul, Software Engineer, Google / Chromium OS

--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch