2020-11-18 12:17:50

by Zhang Changzhong

[permalink] [raw]
Subject: [PATCH net] bnxt_en: fix error return code in bnxt_init_one()

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: c213eae8d3cd ("bnxt_en: Improve VF/PF link change logic.")
Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zhang Changzhong <[email protected]>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 7c21aaa8..092775e 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -12674,6 +12674,7 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
create_singlethread_workqueue("bnxt_pf_wq");
if (!bnxt_pf_wq) {
dev_err(&pdev->dev, "Unable to create workqueue.\n");
+ rc = -ENOMEM;
goto init_err_pci_clean;
}
}
--
2.9.5


2020-11-19 18:56:55

by Edwin Peer

[permalink] [raw]
Subject: Re: [PATCH net] bnxt_en: fix error return code in bnxt_init_one()

On Wed, Nov 18, 2020 at 4:17 AM Zhang Changzhong
<[email protected]> wrote:

> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: c213eae8d3cd ("bnxt_en: Improve VF/PF link change logic.")
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zhang Changzhong <[email protected]>
> ---
> drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 7c21aaa8..092775e 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -12674,6 +12674,7 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
> create_singlethread_workqueue("bnxt_pf_wq");
> if (!bnxt_pf_wq) {
> dev_err(&pdev->dev, "Unable to create workqueue.\n");
> + rc = -ENOMEM;
> goto init_err_pci_clean;
> }
> }
> --

Reviewed-by: Edwin Peer <[email protected]>

Regards,
Edwin Peer

Attachments:
smime.p7s (4.06 kB)
S/MIME Cryptographic Signature

2020-11-20 05:52:43

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH net] bnxt_en: fix error return code in bnxt_init_one()

On Thu, 19 Nov 2020 10:53:47 -0800 Edwin Peer wrote:
> > Fix to return a negative error code from the error handling
> > case instead of 0, as done elsewhere in this function.
> >
> > Fixes: c213eae8d3cd ("bnxt_en: Improve VF/PF link change logic.")
> > Reported-by: Hulk Robot <[email protected]>
> > Signed-off-by: Zhang Changzhong <[email protected]>
>
> Reviewed-by: Edwin Peer <[email protected]>

Applied, thanks!