2020-09-30 02:08:49

by Kefeng Wang

Subject: [PATCH -next] mm/vmscan: Drop duplicated code in drop_slab_node

The following patches fix same issue and both add fatal
signal check in drop_slab_node, kill a duplicated check.

"mm/vmscan: add a fatal signals check in drop_slab_node"
"mm/vmscan: fix infinite loop in drop_slab_node"

Cc: Chunxin Zang <[email protected]>
Signed-off-by: Kefeng Wang <[email protected]>
---
mm/vmscan.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/mm/vmscan.c b/mm/vmscan.c
index eae57d092931..980155e257bf 100644
--- a/mm/vmscan.c
+++ b/mm/vmscan.c
@@ -699,9 +699,6 @@ void drop_slab_node(int nid)
do {
struct mem_cgroup *memcg = NULL;

- if (fatal_signal_pending(current))
- return;
-
if (fatal_signal_pending(current))
return;

--
2.26.2

2020-09-30 02:49:42

by Chunxin Zang

Subject: Re: [External] [PATCH -next] mm/vmscan: Drop duplicated code in drop_slab_node

On Wed, Sep 30, 2020 at 10:07 AM Kefeng Wang <[email protected]> wrote:
>
> The following patches fix same issue and both add fatal
> signal check in drop_slab_node, kill a duplicated check.
>
> "mm/vmscan: add a fatal signals check in drop_slab_node"
> "mm/vmscan: fix infinite loop in drop_slab_node"
>
> Cc: Chunxin Zang <[email protected]>
> Signed-off-by: Kefeng Wang <[email protected]>
> ---
> mm/vmscan.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index eae57d092931..980155e257bf 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -699,9 +699,6 @@ void drop_slab_node(int nid)
> do {
> struct mem_cgroup *memcg = NULL;
>
> - if (fatal_signal_pending(current))
> - return;
> -
> if (fatal_signal_pending(current))
> return;
>
> --
> 2.26.2
>

Yes, there are the same patch. Because the 'add a fatal signals
check in drop_slab_node' description is more accurate.
The mail list please see https://lkml.org/lkml/2020/9/15/20

Andrew, can you update it , thanks so much.

Best wishes
Chunxin Zang