2023-07-20 12:45:53

by Przemyslaw

Subject: [PATCH] power: supply: max17042_battery: Do not use CONFIG_ prefix in regular C code

From: przemoch <[email protected]>

Using CONFIG_ prefix for macros is not a good practice.
Use CONFIG_ prefix in Kconfig only.

Signed-off-by: Przemyslaw Chwiala <[email protected]>
---
drivers/power/supply/max17042_battery.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c
index 17ac2ab78c4e..e7d37e422c3f 100644
--- a/drivers/power/supply/max17042_battery.c
+++ b/drivers/power/supply/max17042_battery.c
@@ -36,7 +36,7 @@
#define STATUS_BR_BIT (1 << 15)

/* Interrupt mask bits */
-#define CONFIG_ALRT_BIT_ENBL (1 << 2)
+#define CFG_ALRT_BIT_ENBL (1 << 2)

#define VFSOC0_LOCK 0x0000
#define VFSOC0_UNLOCK 0x0080
@@ -1116,8 +1116,8 @@ static int max17042_probe(struct i2c_client *client)
chip);
if (!ret) {
regmap_update_bits(chip->regmap, MAX17042_CONFIG,
- CONFIG_ALRT_BIT_ENBL,
- CONFIG_ALRT_BIT_ENBL);
+ CFG_ALRT_BIT_ENBL,
+ CFG_ALRT_BIT_ENBL);
max17042_set_soc_threshold(chip, 1);
} else {
client->irq = 0;
--
2.25.1

2023-07-20 13:26:46

by Krzysztof Kozlowski

Subject: Re: [PATCH] power: supply: max17042_battery: Do not use CONFIG_ prefix in regular C code

On 20/07/2023 14:31, Przemyslaw wrote:
> From: Przemyslaw Chwiala <[email protected]>
>
> Using CONFIG_ prefix for macros is not a good practice.
> Use CONFIG_ prefix in Kconfig only.
>
> Signed-off-by: Przemyslaw Chwiala <[email protected]>
> ---

For future:
Please provide changelog after --- and version your patches (git
format-patch -v2, or use b4).


Reviewed-by: Krzysztof Kozlowski <[email protected]>


---

This is an automated instruction, just in case, because many review tags
are being ignored. If you do not know the process, here is a short
explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for acks received on the
version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

Best regards,
Krzysztof

2023-07-20 13:27:00

by Lukas Bulwahn

Subject: Re: [PATCH] power: supply: max17042_battery: Do not use CONFIG_ prefix in regular C code

On Thu, Jul 20, 2023 at 2:33 PM Przemyslaw <[email protected]> wrote:
>
> From: Przemyslaw Chwiala <[email protected]>
>
> Using CONFIG_ prefix for macros is not a good practice.
> Use CONFIG_ prefix in Kconfig only.
>

Przemyslaw, thanks for the clean up of kernel config references. One
less to go on my clean-up list.

Reviewed-by: Lukas Bulwahn <[email protected]>

Lukas

> Signed-off-by: Przemyslaw Chwiala <[email protected]>
> ---
> drivers/power/supply/max17042_battery.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c
> index 17ac2ab78c4e..e7d37e422c3f 100644
> --- a/drivers/power/supply/max17042_battery.c
> +++ b/drivers/power/supply/max17042_battery.c
> @@ -36,7 +36,7 @@
> #define STATUS_BR_BIT (1 << 15)
>
> /* Interrupt mask bits */
> -#define CONFIG_ALRT_BIT_ENBL (1 << 2)
> +#define CFG_ALRT_BIT_ENBL (1 << 2)
>
> #define VFSOC0_LOCK 0x0000
> #define VFSOC0_UNLOCK 0x0080
> @@ -1116,8 +1116,8 @@ static int max17042_probe(struct i2c_client *client)
> chip);
> if (!ret) {
> regmap_update_bits(chip->regmap, MAX17042_CONFIG,
> - CONFIG_ALRT_BIT_ENBL,
> - CONFIG_ALRT_BIT_ENBL);
> + CFG_ALRT_BIT_ENBL,
> + CFG_ALRT_BIT_ENBL);
> max17042_set_soc_threshold(chip, 1);
> } else {
> client->irq = 0;
> --
> 2.25.1
>