2019-05-15 14:20:12

by Naveen Kumar Parna

Subject: [PATCH 3/3] char: misc: Move EXPORT_SYMBOL immediately next to the functions/varibles

From: Naveen Kumar Parna <[email protected]>

According to checkpatch: EXPORT_SYMBOL(foo); should immediately follow its
function/variable.

This patch fixes the following checkpatch.pl issues in drivers/char/misc.c:
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable

Signed-off-by: Naveen Kumar Parna <[email protected]>
---
drivers/char/misc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index 53cfe574d8d4..f6a147427029 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -226,6 +226,7 @@ int misc_register(struct miscdevice *misc)
mutex_unlock(&misc_mtx);
return err;
}
+EXPORT_SYMBOL(misc_register);

/**
* misc_deregister - unregister a miscellaneous device
@@ -249,8 +250,6 @@ void misc_deregister(struct miscdevice *misc)
clear_bit(i, misc_minors);
mutex_unlock(&misc_mtx);
}
-
-EXPORT_SYMBOL(misc_register);
EXPORT_SYMBOL(misc_deregister);

static char *misc_devnode(struct device *dev, umode_t *mode)
--
2.17.1

2019-05-15 15:17:31

by Greg Kroah-Hartman

Subject: Re: [PATCH 3/3] char: misc: Move EXPORT_SYMBOL immediately next to the functions/varibles

On Wed, May 15, 2019 at 07:47:31PM +0530, [email protected] wrote:
> From: Naveen Kumar Parna <[email protected]>
>
> According to checkpatch: EXPORT_SYMBOL(foo); should immediately follow its
> function/variable.
>
> This patch fixes the following checkpatch.pl issues in drivers/char/misc.c:
> WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
>
> Signed-off-by: Naveen Kumar Parna <[email protected]>
> ---
> drivers/char/misc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)

Where are patches 1/3 and 2/3 of this series?

2019-05-16 11:08:19

by Naveen Kumar Parna

Subject: Re: [PATCH 3/3] char: misc: Move EXPORT_SYMBOL immediately next to the functions/varibles

On Wed, 15 May 2019 at 20:43, Greg KH <[email protected]> wrote:
>
> On Wed, May 15, 2019 at 07:47:31PM +0530, [email protected] wrote:
> > From: Naveen Kumar Parna <[email protected]>
> >
> > According to checkpatch: EXPORT_SYMBOL(foo); should immediately follow its
> > function/variable.
> >
> > This patch fixes the following checkpatch.pl issues in drivers/char/misc.c:
> > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> >
> > Signed-off-by: Naveen Kumar Parna <[email protected]>
> > ---
> > drivers/char/misc.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
>
> Where are patches 1/3 and 2/3 of this series?
It does not has corresponding 1/3 and 2/3 patches. By mistake I used
wrong argument to 'git format-patch' command.

>

2019-05-16 19:49:47

by Greg Kroah-Hartman

Subject: Re: [PATCH 3/3] char: misc: Move EXPORT_SYMBOL immediately next to the functions/varibles

On Thu, May 16, 2019 at 04:36:08PM +0530, Naveen Kumar Parna wrote:
> On Wed, 15 May 2019 at 20:43, Greg KH <[email protected]> wrote:
> >
> > On Wed, May 15, 2019 at 07:47:31PM +0530, [email protected] wrote:
> > > From: Naveen Kumar Parna <[email protected]>
> > >
> > > According to checkpatch: EXPORT_SYMBOL(foo); should immediately follow its
> > > function/variable.
> > >
> > > This patch fixes the following checkpatch.pl issues in drivers/char/misc.c:
> > > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> > >
> > > Signed-off-by: Naveen Kumar Parna <[email protected]>
> > > ---
> > > drivers/char/misc.c | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > Where are patches 1/3 and 2/3 of this series?
> It does not has corresponding 1/3 and 2/3 patches. By mistake I used
> wrong argument to 'git format-patch' command.

Ok, now dropped, please fix up and resend properly.

greg k-h