2012-06-12 14:27:07

by Namjae Jeon

[permalink] [raw]
Subject: [PATCH v4 3/3] usb: storage: update usb devices for write cache quirk in quirk list.

Update information of Seagate Portable HDD and WD My Passport HDD in
quirk list.

Signed-off-by: Namjae Jeon <[email protected]>
Signed-off-by: Pankaj Kumar <[email protected]>
Signed-off-by: Amit Sahrawat <[email protected]>
---
drivers/usb/storage/unusual_devs.h | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
index 1719886..62a31be 100644
--- a/drivers/usb/storage/unusual_devs.h
+++ b/drivers/usb/storage/unusual_devs.h
@@ -1267,6 +1267,12 @@ UNUSUAL_DEV( 0x0af0, 0xd357, 0x0000, 0x0000,
USB_SC_DEVICE, USB_PR_DEVICE, NULL,
0 ),

+/* Reported by Namjae Jeon <[email protected]> */
+UNUSUAL_DEV(0x0bc2, 0x2300, 0x0000, 0x9999,
+ "Seagate",
+ "Portable HDD",
+ USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
+
/* Reported by Ben Efros <[email protected]> */
UNUSUAL_DEV( 0x0bc2, 0x3010, 0x0000, 0x0000,
"Seagate",
@@ -1468,6 +1474,12 @@ UNUSUAL_DEV( 0x1058, 0x0704, 0x0000, 0x9999,
USB_SC_DEVICE, USB_PR_DEVICE, NULL,
US_FL_SANE_SENSE),

+/* Reported by Namjae Jeon <[email protected]> */
+UNUSUAL_DEV(0x1058, 0x070a, 0x0000, 0x9999,
+ "Western Digital",
+ "My Passport HDD",
+ USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
+
/* Reported by Fabio Venturi <[email protected]>
* The device reports a vendor-specific bDeviceClass.
*/
--
1.7.9.5


2012-06-12 14:31:30

by Alan Stern

[permalink] [raw]
Subject: Re: [PATCH v4 3/3] usb: storage: update usb devices for write cache quirk in quirk list.

On Tue, 12 Jun 2012, Namjae Jeon wrote:

> Update information of Seagate Portable HDD and WD My Passport HDD in
> quirk list.
>
> Signed-off-by: Namjae Jeon <[email protected]>
> Signed-off-by: Pankaj Kumar <[email protected]>
> Signed-off-by: Amit Sahrawat <[email protected]>
> ---
> drivers/usb/storage/unusual_devs.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h
> index 1719886..62a31be 100644
> --- a/drivers/usb/storage/unusual_devs.h
> +++ b/drivers/usb/storage/unusual_devs.h
> @@ -1267,6 +1267,12 @@ UNUSUAL_DEV( 0x0af0, 0xd357, 0x0000, 0x0000,
> USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> 0 ),
>
> +/* Reported by Namjae Jeon <[email protected]> */
> +UNUSUAL_DEV(0x0bc2, 0x2300, 0x0000, 0x9999,
> + "Seagate",
> + "Portable HDD",
> + USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
> +
> /* Reported by Ben Efros <[email protected]> */
> UNUSUAL_DEV( 0x0bc2, 0x3010, 0x0000, 0x0000,
> "Seagate",
> @@ -1468,6 +1474,12 @@ UNUSUAL_DEV( 0x1058, 0x0704, 0x0000, 0x9999,
> USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> US_FL_SANE_SENSE),
>
> +/* Reported by Namjae Jeon <[email protected]> */
> +UNUSUAL_DEV(0x1058, 0x070a, 0x0000, 0x9999,
> + "Western Digital",
> + "My Passport HDD",
> + USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_WRITE_CACHE),
> +
> /* Reported by Fabio Venturi <[email protected]>
> * The device reports a vendor-specific bDeviceClass.
> */

Acked-by: Alan Stern <[email protected]>

2012-06-13 01:12:17

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v4 3/3] usb: storage: update usb devices for write cache quirk in quirk list.

On Tue, Jun 12, 2012 at 10:26:30AM -0400, Namjae Jeon wrote:
> Update information of Seagate Portable HDD and WD My Passport HDD in
> quirk list.
>
> Signed-off-by: Namjae Jeon <[email protected]>
> Signed-off-by: Pankaj Kumar <[email protected]>
> Signed-off-by: Amit Sahrawat <[email protected]>
> ---
> drivers/usb/storage/unusual_devs.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)

What happened to the 2 other patches in this series?

And why is your From: email address different from your Signed-off-by:
address? If you are emailing from a different email account than your
"real" one, please put a "From: My name <email_address>" as the first
line in the body of the text for the patch, so git will get things
correct (see the file, Documentation/SubmittingPatches for details about
this.)

So, care to resend these so I can apply them?

thanks,

greg k-h

2012-06-13 01:27:58

by Namjae Jeon

[permalink] [raw]
Subject: Re: [PATCH v4 3/3] usb: storage: update usb devices for write cache quirk in quirk list.

2012/6/13, Greg KH <[email protected]>:
> On Tue, Jun 12, 2012 at 10:26:30AM -0400, Namjae Jeon wrote:
>> Update information of Seagate Portable HDD and WD My Passport HDD in
>> quirk list.
>>
>> Signed-off-by: Namjae Jeon <[email protected]>
>> Signed-off-by: Pankaj Kumar <[email protected]>
>> Signed-off-by: Amit Sahrawat <[email protected]>
>> ---
>> drivers/usb/storage/unusual_devs.h | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>
Dear Greg.
> What happened to the 2 other patches in this series?
The reason is that I tried to send patch again after making the
mistake(Patch number).
I will resend the patches after arranging.
>
> And why is your From: email address different from your Signed-off-by:
> address? If you are emailing from a different email account than your
> "real" one, please put a "From: My name <email_address>" as the first
> line in the body of the text for the patch, so git will get things
> correct (see the file, Documentation/SubmittingPatches for details about
> this.)
>
> So, care to resend these so I can apply them?
Yes, sure, I will resend the patches after changing.
Thanks.
>
> thanks,
>
> greg k-h
>