LinuxLists.cc - [PATCH][next] smb: Replace one-element array with flexible-array member

2023-06-21 22:07:27

Subject: [PATCH][next] smb: Replace one-element array with flexible-array member

One-element arrays are deprecated, and we are replacing them with flexible
array members instead. So, replace one-element array with flexible-array
member in struct smb_negotiate_req.

This results in no differences in binary output.

Link: https://github.com/KSPP/linux/issues/79
Link: https://github.com/KSPP/linux/issues/317
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
fs/smb/server/smb_common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/smb/server/smb_common.h b/fs/smb/server/smb_common.h
index 6b0d5f1fe85c..aeca0f46068f 100644
--- a/fs/smb/server/smb_common.h
+++ b/fs/smb/server/smb_common.h
@@ -200,7 +200,7 @@ struct smb_hdr {
struct smb_negotiate_req {
struct smb_hdr hdr; /* wct = 0 */
__le16 ByteCount;
- unsigned char DialectsArray[1];
+ unsigned char DialectsArray[];
} __packed;

struct smb_negotiate_rsp {
--
2.34.1

2023-06-21 23:56:39

by Namjae Jeon

[permalink] [raw]

Subject: Re: [PATCH][next] smb: Replace one-element array with flexible-array member

2023-06-22 6:12 GMT+09:00, Gustavo A. R. Silva <[email protected]>:
> One-element arrays are deprecated, and we are replacing them with flexible
> array members instead. So, replace one-element array with flexible-array
> member in struct smb_negotiate_req.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/79
> Link: https://github.com/KSPP/linux/issues/317
> Signed-off-by: Gustavo A. R. Silva <[email protected]>
Acked-by: Namjae Jeon <[email protected]>

Thanks!

2023-06-23 05:20:04

by Sergey Senozhatsky

[permalink] [raw]

Subject: Re: [PATCH][next] smb: Replace one-element array with flexible-array member

On (23/06/21 15:12), Gustavo A. R. Silva wrote:
> One-element arrays are deprecated, and we are replacing them with flexible
> array members instead. So, replace one-element array with flexible-array
> member in struct smb_negotiate_req.
>
> This results in no differences in binary output.
>
> Link: https://github.com/KSPP/linux/issues/79
> Link: https://github.com/KSPP/linux/issues/317
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Reviewed-by: Sergey Senozhatsky <[email protected]>

2023-06-24 04:31:20

by Namjae Jeon

[permalink] [raw]