2022-08-26 10:03:25

by Namjae Jeon

[permalink] [raw]
Subject: Re: [PATCH] exfat: fix overflow for large capacity partition

2022-08-23 12:26 GMT+09:00, Sungjong Seo <[email protected]>:
>> Using int type for sector index, there will be overflow in a large
>> capacity partition.
>>
>> For example, if storage with sector size of 512 bytes and partition
>> capacity is larger than 2TB, there will be overflow.
>>
>> Fixes: 1b6138385499 ("exfat: reduce block requests when zeroing a
>> cluster")
>>
>> Signed-off-by: Yuezhang Mo <[email protected]>
>> Reviewed-by: Andy Wu <[email protected]>
>> Reviewed-by: Aoyama Wataru <[email protected]>
>
> Looks good!
> Acked-by: Sungjong Seo <[email protected]>
Applied, Thanks!
>
>>
>> ---
>> fs/exfat/fatent.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/fs/exfat/fatent.c b/fs/exfat/fatent.c index
>> ee0b7cf51157..41ae4cce1f42 100644
>> --- a/fs/exfat/fatent.c
>> +++ b/fs/exfat/fatent.c
>> @@ -270,8 +270,7 @@ int exfat_zeroed_cluster(struct inode *dir, unsigned
>> int clu)
>> struct super_block *sb = dir->i_sb;
>> struct exfat_sb_info *sbi = EXFAT_SB(sb);
>> struct buffer_head *bh;
>> - sector_t blknr, last_blknr;
>> - int i;
>> + sector_t blknr, last_blknr, i;
>>
>> blknr = exfat_cluster_to_sector(sbi, clu);
>> last_blknr = blknr + sbi->sect_per_clus;
>> --
>> 2.25.1
>
>
>