2023-02-06 07:21:49

by Jiapeng Chong

[permalink] [raw]
Subject: [PATCH] ksmbd: Fix parameter name and comment mismatch

fs/ksmbd/vfs.c:965: warning: Function parameter or member 'attr_value' not described in 'ksmbd_vfs_setxattr'.

Reported-by: Abaci Robot <[email protected]>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3946
Signed-off-by: Jiapeng Chong <[email protected]>
---
fs/ksmbd/vfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/ksmbd/vfs.c b/fs/ksmbd/vfs.c
index aa1300b7bfc2..5ea9229dad2c 100644
--- a/fs/ksmbd/vfs.c
+++ b/fs/ksmbd/vfs.c
@@ -952,9 +952,9 @@ ssize_t ksmbd_vfs_getxattr(struct mnt_idmap *idmap,
* ksmbd_vfs_setxattr() - vfs helper for smb set extended attributes value
* @idmap: idmap of the relevant mount
* @dentry: dentry to set XATTR at
- * @name: xattr name for setxattr
- * @value: xattr value to set
- * @size: size of xattr value
+ * @attr_name: xattr name for setxattr
+ * @attr_value: xattr value to set
+ * @attr_size: size of xattr value
* @flags: destination buffer length
*
* Return: 0 on success, otherwise error
--
2.20.1.7.g153144c



2023-02-06 14:41:24

by Namjae Jeon

[permalink] [raw]
Subject: Re: [PATCH] ksmbd: Fix parameter name and comment mismatch

2023-02-06 16:20 GMT+09:00, Jiapeng Chong <[email protected]>:
> fs/ksmbd/vfs.c:965: warning: Function parameter or member 'attr_value' not
> described in 'ksmbd_vfs_setxattr'.
>
> Reported-by: Abaci Robot <[email protected]>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3946
> Signed-off-by: Jiapeng Chong <[email protected]>
Acked-by: Namjae Jeon <[email protected]>

Thanks.

2023-02-07 01:52:46

by Sergey Senozhatsky

[permalink] [raw]
Subject: Re: [PATCH] ksmbd: Fix parameter name and comment mismatch

On (23/02/06 15:20), Jiapeng Chong wrote:
>
> fs/ksmbd/vfs.c:965: warning: Function parameter or member 'attr_value' not described in 'ksmbd_vfs_setxattr'.
>
> Reported-by: Abaci Robot <[email protected]>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3946
> Signed-off-by: Jiapeng Chong <[email protected]>

Reviewed-by: Sergey Senozhatsky <[email protected]>