2020-01-27 11:39:31

by Colin King

Subject: [PATCH][next][V2] i2c: xiic: fix indentation issue

From: Colin Ian King <[email protected]>

There is a statement that is indented one level too deeply, remove
the extraneous tab.

Signed-off-by: Colin Ian King <[email protected]>
---
V2: fix type in commit message
---
drivers/i2c/busses/i2c-xiic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
index b17d30c9ab40..90c1c362394d 100644
--- a/drivers/i2c/busses/i2c-xiic.c
+++ b/drivers/i2c/busses/i2c-xiic.c
@@ -261,7 +261,7 @@ static int xiic_clear_rx_fifo(struct xiic_i2c *i2c)
xiic_getreg8(i2c, XIIC_DRR_REG_OFFSET);
if (time_after(jiffies, timeout)) {
dev_err(i2c->dev, "Failed to clear rx fifo\n");
- return -ETIMEDOUT;
+ return -ETIMEDOUT;
}
}

--
2.24.0

2020-01-27 12:41:20

by Michal Simek

Subject: Re: [PATCH][next][V2] i2c: xiic: fix indentation issue

On 27. 01. 20 13:08, Colin Ian King wrote:
> On 27/01/2020 12:05, Dan Carpenter wrote:
>> On Mon, Jan 27, 2020 at 12:03:02PM +0100, Michal Simek wrote:
>>> On 27. 01. 20 11:23, Colin King wrote:
>>>> From: Colin Ian King <[email protected]>
>>>>
>>>> There is a statement that is indented one level too deeply, remove
>>>> the extraneous tab.
>>>>
>>>> Signed-off-by: Colin Ian King <[email protected]>
>>>> ---
>>>> V2: fix type in commit message
>>>> ---
>>>> drivers/i2c/busses/i2c-xiic.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
>>>> index b17d30c9ab40..90c1c362394d 100644
>>>> --- a/drivers/i2c/busses/i2c-xiic.c
>>>> +++ b/drivers/i2c/busses/i2c-xiic.c
>>>> @@ -261,7 +261,7 @@ static int xiic_clear_rx_fifo(struct xiic_i2c *i2c)
>>>> xiic_getreg8(i2c, XIIC_DRR_REG_OFFSET);
>>>> if (time_after(jiffies, timeout)) {
>>>> dev_err(i2c->dev, "Failed to clear rx fifo\n");
>>>> - return -ETIMEDOUT;
>>>> + return -ETIMEDOUT;
>>>> }
>>>> }
>>>>
>>>>
>>>
>>> As was suggested by Peter you should also add Fixes: <sha1> ("patch
>>> subject")
>>>
>>
>> It's not really a bugfix, it's just a cleanup.
>
> I'm surprised i wasn't asked for a bug number too.

ok. Up2you.

Thanks,
Michal

2020-01-27 12:56:47

by Shubhrajyoti Datta

Subject: Re: [PATCH][next][V2] i2c: xiic: fix indentation issue

On Mon, Jan 27, 2020 at 4:46 PM Colin King <[email protected]> wrote:
>
> From: Colin Ian King <[email protected]>
>
> There is a statement that is indented one level too deeply, remove
> the extraneous tab.
>
Reviewed-by: Shubhrajyoti Datta <[email protected]>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> V2: fix type in commit message
> ---
> drivers/i2c/busses/i2c-xiic.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c
> index b17d30c9ab40..90c1c362394d 100644
> --- a/drivers/i2c/busses/i2c-xiic.c
> +++ b/drivers/i2c/busses/i2c-xiic.c
> @@ -261,7 +261,7 @@ static int xiic_clear_rx_fifo(struct xiic_i2c *i2c)
> xiic_getreg8(i2c, XIIC_DRR_REG_OFFSET);
> if (time_after(jiffies, timeout)) {
> dev_err(i2c->dev, "Failed to clear rx fifo\n");
> - return -ETIMEDOUT;
> + return -ETIMEDOUT;
> }
> }
>
> --
> 2.24.0
>