On Mon, Apr 8, 2024 at 6:39 AM Yunsheng Lin <[email protected]> wrote:
>
> On 2024/4/8 2:13, Alexander H Duyck wrote:
> > On Sun, 2024-04-07 at 21:08 +0800, Yunsheng Lin wrote:
> >> Update documentation about design, implementation and API usages
> >> for page_frag.
> >>
> >> Also update MAINTAINERS for page_frag. Alexander seems to be the
> >> orginal author for page_frag, we can add him to the MAINTAINERS
> >> later if we have an ack from him.
> >>
> >> CC: Alexander Duyck <[email protected]>
> >> Signed-off-by: Yunsheng Lin <[email protected]>
> >
> > Again, this seems more like 2 different pathches at least. One for the
> > Documentation and MAINTAINERS changes, and one for the function
> > documentation.
>
> Sure.
>
[...]
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -16683,6 +16683,16 @@ F: mm/page-writeback.c
> >> F: mm/readahead.c
> >> F: mm/truncate.c
> >>
> >> +PAGE FRAG
> >> +M: Yunsheng Lin <[email protected]>
> >> +L: [email protected]
> >> +L: [email protected]
> >> +S: Supported
> >> +F: Documentation/mm/page_frags.rst
> >> +F: include/linux/page_frag_cache.h
> >> +F: mm/page_frag_cache.c
> >> +F: mm/page_frag_test.c
> >> +
> >
> > I would appreciate it if you could add me as I usually am having to
> > deal with issues people have with this anyway. You can probably just go
> > with:
> > Alexander Duyck <[email protected]>
>
> Sure, good to your ack here.
Just to be clear this isn't an Ack, but if you are going to list
maintainers for this my name should be on the list so this is the
preferred format. There are still some things to be cleaned up in this
patch.
On 2024/4/9 0:13, Alexander Duyck wrote:
> On Mon, Apr 8, 2024 at 6:39 AM Yunsheng Lin <[email protected]> wrote:
>>
>> On 2024/4/8 2:13, Alexander H Duyck wrote:
>>> On Sun, 2024-04-07 at 21:08 +0800, Yunsheng Lin wrote:
>>>> Update documentation about design, implementation and API usages
>>>> for page_frag.
>>>>
>>>> Also update MAINTAINERS for page_frag. Alexander seems to be the
>>>> orginal author for page_frag, we can add him to the MAINTAINERS
>>>> later if we have an ack from him.
>>>>
>>>> CC: Alexander Duyck <[email protected]>
>>>> Signed-off-by: Yunsheng Lin <[email protected]>
>>>
>>> Again, this seems more like 2 different pathches at least. One for the
>>> Documentation and MAINTAINERS changes, and one for the function
>>> documentation.
>>
>> Sure.
>>
>
> [...]
>
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -16683,6 +16683,16 @@ F: mm/page-writeback.c
>>>> F: mm/readahead.c
>>>> F: mm/truncate.c
>>>>
>>>> +PAGE FRAG
>>>> +M: Yunsheng Lin <[email protected]>
>>>> +L: [email protected]
>>>> +L: [email protected]
>>>> +S: Supported
>>>> +F: Documentation/mm/page_frags.rst
>>>> +F: include/linux/page_frag_cache.h
>>>> +F: mm/page_frag_cache.c
>>>> +F: mm/page_frag_test.c
>>>> +
>>>
>>> I would appreciate it if you could add me as I usually am having to
>>> deal with issues people have with this anyway. You can probably just go
>>> with:
>>> Alexander Duyck <[email protected]>
>>
>> Sure, good to your ack here.
>
> Just to be clear this isn't an Ack, but if you are going to list
> maintainers for this my name should be on the list so this is the
> preferred format. There are still some things to be cleaned up in this
> patch.
Sure, I was talking about "Alexander seems to be the orginal author for
page_frag, we can add him to the MAINTAINERS later if we have an ack from
him." in the commit log.
> .
>